Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp645098rdb; Thu, 18 Jan 2024 14:32:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFZjszFfLl1NaWkcRqQwZSvbhfGceLNfzGTdL4ngESLVrQPey5D3z3jRe5qVTEDfW8KbSKA X-Received: by 2002:a05:6830:3296:b0:6dd:e85f:2451 with SMTP id m22-20020a056830329600b006dde85f2451mr1461421ott.70.1705617171406; Thu, 18 Jan 2024 14:32:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705617171; cv=pass; d=google.com; s=arc-20160816; b=iiF7US4kYkHLJe52Yir+a0uALb3QqmT0RlsPcNr7PAcZ6K9l1WChcsj4KbkH4TMXfy IjiksPxIOOtZyLd08+FjXPurCBMHEGPfi/Wv7SfzolLVUJM5ZKAHxEsWmd2NQptXBzGn Yk2S6dVkhvht+7ryHIsDxxjuQnRam9XS7Jl10vXoNXrJLcX8IV9K4wVVOVD+SmTfeCTj TZtjlOMPjzC83zV3d6c3WSPn8YH/2iNrtGP6PTgBcPyskPEdPKf0G+xgAp9LUHnVsfTg eegfYU0k2G3S9axsQZKv6GNjpILq6FAGMJJkmjWD0PF1gg2eKsfgUbeMw9z9th08n6y3 gmtg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=z7Ga1PrZhviwyhWdstpoS5TcnXPX4KWerzR54KDAnLM=; fh=U3DCOikkIuOf9ecqgW/S6QALN/iW9BR3gKiyTd8Ay3M=; b=wK7DCRg+PQ6EuP/qS9gxNXeK9bApiJg2d5WUa29wZopy3eu4MbqcoZ9mWL7pHyuEy4 ZG6S173pRSpHA+EGEX0KNGI3jziBaZEMORuf3vQEJumEfYx4fyDUJL1rrv/33f5Vz7IL 61YMiIOxtE+sb8jmnzAI3m+XVEXT9eo1IhboXHBbiusrxl8rkxgGnbr3/BpdQyymdzL4 XnvynABmpNB2MGAA9UXK2LUzrgxvdpx14F0cculnK49OCYnjLMMiSn3FxSVsm+a/a2B4 VBPKOF6qhdyONsqwxpHZ/ameaSjbNJCmCAMJWvt6WKHkJItQVdjinkphhykCMhfVKo6k /P5A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LGa5PxRq; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-30601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30601-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id c7-20020ac85a87000000b0042a1c757654si1840775qtc.626.2024.01.18.14.32.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 14:32:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LGa5PxRq; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-30601-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30601-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2BE1E1C231C0 for ; Thu, 18 Jan 2024 22:32:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3E2918F7D; Thu, 18 Jan 2024 22:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LGa5PxRq" Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06B069461; Thu, 18 Jan 2024 22:32:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705617163; cv=none; b=Tf8Ruh/d0gmaSr2AZgKfw9qX2b8Hi9epmng8PB+1EuIECcTRGV8X+i/2hfzIZzm7F8DDL/4MHipXZlcC4+wsXo39tmk2UwQ/CWAXeflsgt5rr8OJVVwt2w63uxl8ymcS+CcrZhlsexdvaVWPFGhK3Be9daislWTwwnQG/Kb2s+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705617163; c=relaxed/simple; bh=M4FC5RFpU+gBs/4jHvsgu9SOSEyqfP0aIO99aZepvQU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Qr4NbdRdKfUBBWaCTbxayntRIGb9wPAZBUuA1q7P8xVP9G+oi9WbPGlpU8iRTwVv3ePphMrWDyk7dHjyhjsCJq9h/Yli9iQbdvG3o68GPMGEcJGIgfWrn/VWDif7j0VhlfEG66J3wdxwpR85I5PZmJfUATATMCgmMp5tduHOJSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LGa5PxRq; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1d6ff29293dso1194305ad.0; Thu, 18 Jan 2024 14:32:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705617161; x=1706221961; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z7Ga1PrZhviwyhWdstpoS5TcnXPX4KWerzR54KDAnLM=; b=LGa5PxRqz4C4SSinW9SAlJj16JdIlUaH6N1tntWrc78cCgOhfiNmJmakqFHhgsdgea mRlbcu2Xkis6TQ2yKXhZuElxTg6HYti+9uqiLS3zbJTPnua7lXx9dB+pdRdXU21JCwQv Xrh/wImRXUizTkvKyFVV350ON3zUijFod8oJdNrMc+7oIQHqv/E1MKMtZ7ZjdpZFJSjy m5Fnwx8l3NS7YTkJ4opOcGYdBkiVMe48jdILEtl3l5OJbdahy24gLzGAnH3uCDbkwa9B FTwBvxBjtAZXYJDD0O4xvK6EVYrppGXxjMb2d27D7rgdGjn+SThRbVIpX85eZO9g4Emv VQNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705617161; x=1706221961; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z7Ga1PrZhviwyhWdstpoS5TcnXPX4KWerzR54KDAnLM=; b=OsdAlJL7yzMCDenm2KKzYJIisVkK+AdXis59G+dxlx3be4Jlc+OBP3BpsSMfCHB2JN xXHawLuoNlC68XvdN7X3sSi+2lphLsHAnHu6pm/qyMBwW46J3SVN6v+3kwXc8ULTiSrT JV5YanJRzbJEY2mrD+fveQDELevkSkLvDOXyPgi1N2IOzPGMGH5aNiSZlRQ60UEkKBie 2DoRokFMyn+ByNFmFKnaV7a6138lnF83Zg3sQnfxhDsO6zehUV7UHGBdToGKvHItKfj7 PWoyrVpoG5EN2uXIhPuu3N2QDnGmgZShg5TfgbY51wPVIcXu0BN3QvS8AsMeNZgEO/A/ Utqg== X-Gm-Message-State: AOJu0YzN9FybKPSSben+Q3qHy2aLpAtVAVR8jbm7RLY2y1i75ZyLRlad HR4avQ1OuLDt545Wa4/BzW3mszdQEC4r7inDwupcx+AYuOuZDmRh X-Received: by 2002:a17:902:d485:b0:1d5:6a6f:6e71 with SMTP id c5-20020a170902d48500b001d56a6f6e71mr1526895plg.68.1705617161145; Thu, 18 Jan 2024 14:32:41 -0800 (PST) Received: from google.com ([2620:15c:9d:2:f04f:73f4:b79:a70c]) by smtp.gmail.com with ESMTPSA id mq3-20020a170902fd4300b001d5dad79fd6sm1865451plb.84.2024.01.18.14.32.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 14:32:40 -0800 (PST) Date: Thu, 18 Jan 2024 14:32:38 -0800 From: Dmitry Torokhov To: Kunwu Chan Cc: aduggan@synaptics.com, cheiny@synaptics.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Input: synaptics-rmi4: Add a null pointer check to the rmi_driver_probe Message-ID: References: <20240117073124.143636-1-chentao@kylinos.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240117073124.143636-1-chentao@kylinos.cn> Hi Kunwu, On Wed, Jan 17, 2024 at 03:31:24PM +0800, Kunwu Chan wrote: > devm_kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. Ensure the allocation was successful > by checking the pointer validity. > > Signed-off-by: Kunwu Chan > Suggested-by: Dmitry Torokhov I did not suggest the patch, I merely provided feedback on it, so I dropped this tag, reworded commit message slightly, and applied. Thanks. -- Dmitry