Received-SPF: pass (google.com: domain of linux-kernel+bounces-30625-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
To: Kees Cook <keescook@chromium.org>
Cc: Tyrel Datwyler <turtle.in.the.kernel@gmail.com>,
        Justin Stitt
 <justinstitt@google.com>,
        Michael Cyr <mikecyr@linux.ibm.com>,
        "James
 E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen"
 <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] scsi: ibmvscsi_tgt: replace deprecated strncpy with
 strscpy
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1h6ja1bhs.fsf@ca-mkp.ca.oracle.com>
References: <20231212-strncpy-drivers-scsi-ibmvscsi_tgt-ibmvscsi_tgt-c-v2-1-bdb9a7cd96c8@google.com>
	<202312121321.E15E09BF@keescook>
	<9f246fbc-b2e4-4585-912d-a5a00ac8cd04@gmail.com>
	<202401181442.ABC133B203@keescook>
Date: Thu, 18 Jan 2024 18:13:45 -0500
In-Reply-To: <202401181442.ABC133B203@keescook> (Kees Cook's message of "Thu,
	18 Jan 2024 14:43:16 -0800")
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?kGLtEWbV1RD/StUs4rMcXkThgSEhaLUqIpe7IyzW8ZO95NIU0ijEC5Qw5+Go?=
 =?us-ascii?Q?GGkl5mhypJit0g0yJn6Y1yHZveHZ48P/VPrzu49logSVZAzOD7TFhOv7fAxQ?=
 =?us-ascii?Q?xZzJHy1gX2hdJCVe9IUJR+LXqGIdxiZbAYen77wFE1Uroqcy9V1fhYmduJYl?=
 =?us-ascii?Q?bZs8bIB4I5cB1i0IP/mWCUQSXXHxwjfK8w4TcS5eB32NqtwjQTq3uMxdYc6z?=
 =?us-ascii?Q?pOsn2WGLh+AZeoUMjeKdGHYf2wOhAvHb/C0K9BwTuWYkUKQR+73Te7lPY9N1?=
 =?us-ascii?Q?ZEIv91HRL3Wx/t9KUlgG/IzEYqptm8r+3EYywhtnV+r7CRA7rAY7Ud5S+Icr?=
 =?us-ascii?Q?g4JIpXeqKjkSAcgnXjlO8rvv6X/cIlME/HuObBBYOEGUP9IX/SmdvCwscl2s?=
 =?us-ascii?Q?aHON69RTxI2OD5LqiLLPW/Tdbajim16N2yLKwmyR2ID+fG9sn5xO0VsHewr8?=
 =?us-ascii?Q?scGiGaBmeTrhURxWPTzJHcWbAMl9jbM+V7pRJSGf235lM2cZK1bTaMcMQS3r?=
 =?us-ascii?Q?NrysfG0qEASvaP7+/GtntNK7AwSpwWoVz2B7psJiAJduN9PeWgcNwX2CFHay?=
 =?us-ascii?Q?5MCmiMW890wrB+P+a1pNER7icSj0wr1B5HHf/r+KCUo3qsXni/zNLe11A/eS?=
 =?us-ascii?Q?oCt+kjk4yyt/R54RgMjasXSwDKyvWNQcvnRDC0kpJmUb+jbu+7ZOdnn+NJys?=
 =?us-ascii?Q?0cyEgvUZZs6ZPDtadchxVAzOU22hICSND7ffqqJM+FI/QMoJ52GfoUbw9ald?=
 =?us-ascii?Q?LmFcR/nIOnKchOE9sVJ60My9i4fvqHywzEsIUJ4HN/FroNDHHF8uiZT4mMyy?=
 =?us-ascii?Q?P/D4zAbKHvX0NWw5WlXJseVQwVSzXHN2cXX5IdfZyU+tDz5tWB3KWaKzZQrQ?=
 =?us-ascii?Q?q3UkzNQGwO7MfUlAK87UuM2dcOF9wpjN9M221z0cf0MKUanQvEZRMFYd+4dw?=
 =?us-ascii?Q?e6iZXtp0pSDn3u0J0tiV0hFfhnz02Ucxc76peo4ADm1znDjlL/WbnkZnPy+A?=
 =?us-ascii?Q?XpCAyow3bzJ+PF9RohpaIadk1KPZ3f39+7V2sQeDZGPSSlukOMvW4Hd1uQ69?=
 =?us-ascii?Q?r1i3nKzzK/KM/FD/96gyjgcTt1CDZefoUkgNgUyedW2CMVBYoRuq8NA4Bcg6?=
 =?us-ascii?Q?QFVwevLMJ8OJJCDjf4QYV7JqgQ9H9agABCcvKNifHn7dDyYfOZdIeYkHUk7g?=
 =?us-ascii?Q?qrkPWksVVU0Ud4OqQskvx0mdERClfDAR3OeoDzuMT5bQFeiXlP33QyofFKnz?=
 =?us-ascii?Q?F+AzvD0t6UNOVxKF5mWBoynA1KZimH/FIKGZUSRmAx3WvOd3OkX8AF+yLNw+?=
 =?us-ascii?Q?iu3tRjOocZSh68QCMnXVCBEzjuWnG1l2QFSMliG797lTlCx19sWAxECVIRth?=
 =?us-ascii?Q?H1FlYWKWZD82GMRnPE2CzEM2N+wBCMJRv3NF8HU0C0q02eXIfDSWVkIND/X4?=
 =?us-ascii?Q?BXw/ybdFxF0oqTK0ZlOs+tMlxEnK5M6rmFOVxQVoMDfkd9AptL9l8jvQjpVq?=
 =?us-ascii?Q?rSW0japV/J/WlUIIZIt8Mu8G0vNbO4sMOGpcPUJluJ2dG1TrBpmDB1W/Y8sd?=
 =?us-ascii?Q?8iDWYFrMu/4S6GW3ZqFMXdvS0c7WwSrv+F2fJpgnNULHWKa8gdpzI7O7skO7?=
 =?us-ascii?Q?0g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	ZESWDr7y2Iwa2MbPgaayClAM20JEUa/g3BlZXVxDSDcgihPh8jjNe6TU9vhyo34Zd0t8+JGmAQFtgzuqmXwvhRyhJsrsAVx5Cz5iLYGZJFAbEgQ7hIveqA5QzLydnn2WhrEj7HBwoIdia8iq/zNU9C76rAk5Ixp8rD+faWJpMGQ68b/Pnkltjsp6zdxhkltXfNhEA3K7IcZPcJySXBavexbL1cld/Ov2K07K7luO7OpjiRlU1obucVW7gZZVgcW3ofVElpabe02X/eG2dD0bJ8xfe9tVcU3pWklY/BBqdwF9wlEDkXIytx+kEBvTKAoGFpYslwjf9PcCXkKCU18TiwT8rdqbtRL+wTz4z1U7a+YKxha3gNEwhyQBSogD/UPsySkONnK20Z5iH6Y5ei7/e16AfOLJ/A5YVLV8/e5SqadpLySG6rerzw2fDfUJagt7+t128nA5RUnFCdr9nmpF8qb0BoCG10m1CircEpGbUGWusSDpOKWKnzRqm3UcECbuL+IQq6JuqAQePnPgt57+nAdQsr7YevTC35mLtaEXn1QFDkDHDUqNlnvm4m6EiIUQP2NJAIV5c2Cpg569i2yuvNr0/hz83rCuCP53690bP7Y=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54a93948-20eb-4679-da90-08dc187b1f46
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2024 23:13:46.5869
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LGeXA/k3z1J3+WiLX1ZqD0rrB3k2RQfsaVvmbUzDhM0f5iSXEcgewkOhJFNSJdN0DN5IJFO3D5e7/Ve0cfZ5yGk96gdZj0fiq8D9R8ujntI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4447
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-18_10,2024-01-17_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 phishscore=0
 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=594 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401180156
X-Proofpoint-ORIG-GUID: kbNlDXhl-CQY34NuyXuJKERRpgwe7yUl
X-Proofpoint-GUID: kbNlDXhl-CQY34NuyXuJKERRpgwe7yUl


Kees,

> Great; thanks! Are you taking this, or should I carry it in the
> hardening tree?

I'll pick it up now that Tyrel has reviewed it.

-- 
Martin K. Petersen	Oracle Linux Engineering