Received-SPF: pass (google.com: domain of linux-kernel+bounces-30629-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
IronPort-PHdr: A9a23:b09/jB+5j0I9dP9uWOnoyV9kXcBvk7zwOghQ7YIolPcSNK+i5J/le
 kfY4KYlgFzIWNDD4ulfw6rNsq/mUHAd+5vJrn0YcZJNWhNEwcUblgAtGoiEXGXwLeXhaGoxG
 8ERHER98SSDOFNOUN37e0WUp3Sz6TAIHRCqNgNvOuXxE436hMWs3Of08JrWME1EgTOnauZqJ
 Q6t5UXJ49Mbg4ZpNu49ywCcpHxOdqUeyTZjJEmYmFD34cLYwQ==
IronPort-Data: A9a23:To/4ta2eKpCZTnsqBfbD5fVxkn2cJEfYwER7XKvMYLTBsI5bpzEOx
 2tOX2vQM/qCNmTyfNl3PYy39k1Vu5OGztIxTQNp3Hw8FHgiRegpqji6wuYcGwvIc6UvmWo+t
 512huHodZ1yFjmE4E71btANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq8wIDqtYAbeORXUXV5
 Lsen+WFYAX5g2ctYjpOg06+gEoHUMra6WtwUmMWPZinjHeG/1EJAZQWI72GLneQauG4ycbjG
 o4vZJnglo/o109F5uGNy94XQWVWKlLmBjViv1INM0SUbreukQRpukozHKJ0hU66EFxllfgpo
 DlGncTYpQvEosQglcxFOyS0HR2SMoVK+uPrDUS0oPXN6FHcWjjM/NNtUGU5aNhwFuZfWQmi9
 NQCIzwLKxuEne/zmfSwS/JngYIoK8yD0IE34y47i2qGS6d9B8meGc0m5vcAtNs0rsNHB+rfY
 8MaQTFudx/HJRZIPz/7Dbpnw7331yajK2QwRFS9o5Mbw1rpxxJN36HIKdGIVtWNY+4LgRPNz
 o7B1z+kWk5BboP3JSC+2natgPLf2DjwQ4M6CrK17LhpjUeVy2hVDwcZPXO/oP+kmgu9VshZJ
 kg85CUjt+4x+VatQ927WAe3yENopTYGUNZWVuY98gzIk+zf4h2SAS4PSTsphMEaWNEeST52+
 nO1lMLQWxtzqpTWaU279euwombnUcQKFlMqaSgBRAoDxtDspoAvkx7CJuqP9obo3rUZ/hmtk
 1i3QDgCulkFsSIcO0yGEb3vmTmgoN3CSRQ4o1yRVWO+5QQ/b4mgD2BJ1bQ5xagdRGp6ZgDd1
 JThpyR4xLtRZX1qvHfSKNjh5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9bIWK3O
 BWN6VwMucY70J6WgUlfPtPZ5yMCkPmIKDgZfqC8gidmO8EuJFHdoEmCm2bJgz6z+KTTrU3PE
 czGKZn3Vyly5VVPxzutTOBVyq4w2i073ivSQ5u9pylLIpLADEN5vYwtaQPUBshgtfvsiFyMr
 753aZDQoz0BC7KWX8Ui2dNJRbz8BSJlVcmeRg0+XrPrHzeK70l/UKGAnu99ININcmY8vr6gw
 0xRk3RwkTLXrXbGMg6NLHtkbdvSsVxX9BrX4QRE0Y6U5kUe
IronPort-HdrOrdr: A9a23:WN6BTKlDJOIU1UBlBvmSIgd8h4LpDfNjiWdD5ihNYBxZY6Wkfp
 +V7ZcmPE7P6Ar5BktApTnZAtj/fZq9z/JICYl4B8bFYOCUghrYEGgE1/qs/9SAIVyzygcz79
 YbT0ETMqyVMbE+t7eE3ODaKadv/DDkytHUuQ629R4EJm8aCdAE0+46MHfmLqQcfng+OXNNLu
 vm2iMxnUvZRZ14VLXdOlA1G8L4i5ngkpXgbRQaBxghxjWvoFqTgoLSIlyz5DtbdylA74sD3A
 H+/jAR4J/Nj9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVIQdS5zXAIidDqzGxvvM
 jHoh8mMcg2wWjWZHuJrRzk3BSl+Coy6kXl1USTjRLY0I/ErXMBeoh8bLBiA1/kAnkbzZZBOW
 VwriSkXq9sfFb9deLGloH1vl9R5xKJSDEZ4J4uZjRkIPgjgflq3M0iFIc/KuZbIMo8g7pXS9
 VGHYXS4u1bfkidaG2ctm5zwMa0VnB2BRueRFMe0/blmAS+sUoJhnfw/vZv1kso5dY4Ud1J9u
 7EOqNnmPVHSdIXd7t0AKMETdGsAmLATBrQOCbKSG6XWZ0vKjbIsdr68b817OaldNgBy4Yzgo
 3IVBdduXQpc0zjBMWS1NlA8wzLQm+6QTPxo/suraRRq/n5Xv7mICeDQFchn4+ppOgeGNTSX7
 KpNJdfE5bYXB3T8EZyrnrDsrVpWA0juZcuy6QGsnq107f2FrE=
From: "Karan Tilak Kumar (kartilak)" <kartilak@cisco.com>
To: Li Zhijian <lizhijian@fujitsu.com>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: "Satish Kharat (satishkh)" <satishkh@cisco.com>,
        "Sesidhar Baddela
 (sebaddel)" <sebaddel@cisco.com>,
        "James E.J. Bottomley"
	<jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [PATCH 22/42] drivers/scsi/fnic: Convert snprintf to sysfs_emit
Thread-Topic: [PATCH 22/42] drivers/scsi/fnic: Convert snprintf to sysfs_emit
Thread-Index: AQHaSDfVBhod7SGWYUO+jzBBMDUZobDgOdlQ
Date: Thu, 18 Jan 2024 23:24:51 +0000
Message-ID:
 <SJ0PR11MB58966A005DB6136D106A1DA6C3712@SJ0PR11MB5896.namprd11.prod.outlook.com>
References: <20240116041129.3937800-1-lizhijian@fujitsu.com>
 <20240116045151.3940401-1-lizhijian@fujitsu.com>
 <20240116045151.3940401-20-lizhijian@fujitsu.com>
In-Reply-To: <20240116045151.3940401-20-lizhijian@fujitsu.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?BWZzrXrYjME55mDQFxo8vCHHVvuxW8VTvQMZUv7MN10R4/OqDA8g08BsAvOQ?=
 =?us-ascii?Q?RW7ANLKACXyUgLVovoHXdLBX/uEh7R7iqcrtLUkf65RfJhkSPOgv4rK1wEfL?=
 =?us-ascii?Q?8yRUbewqyWSAKogkOO7J6rbIzVjhUz+LMNsnbZ8RyJnLZw/J0cAleR8mi59n?=
 =?us-ascii?Q?VJi9ewiaBGRbgJKxWXPg0EiiH+sJKGKawxhnl4fl+bTp9yyMrwr85lanUQz6?=
 =?us-ascii?Q?9YqHi+jjMUk1QoJs1tTpcix5SuHTcl39IcJawYPjN3xXDtdCJhkXZziRp0BW?=
 =?us-ascii?Q?XDKUe0pILuNAKm9ajj5K5L2Tdsuvxmnn3j377oaN/mH56SQG5q9X28vdBBqb?=
 =?us-ascii?Q?Jth3GVWYC+kZC08QS/lS15e7Zh7qgjIXWHHPtOTstBULPEMA93uHJkpJh+wf?=
 =?us-ascii?Q?+flCqn85niNz+7RmsqC8WXcof0QoBH3K2s+3SJPkQtY7z1rqkMTRIzVexg9Y?=
 =?us-ascii?Q?fFB/84TKTHnux3kZbG1lGGptlj+4UmcOw1yKrFrY6owxEiS5nqJXki3j0lij?=
 =?us-ascii?Q?T6i/jERjAVTw+CDQ7qDNyzn+mEz//Amsavq/jGjjsFx0o77yyTHaLXrJ7K/L?=
 =?us-ascii?Q?Eg2tSX8xr1m7H8mbdNSuZVUM73BxLRCglH8XUctw73bwUTIiQROnsf+lp1MZ?=
 =?us-ascii?Q?pFnhfD+8mLhrCLo0hp5bL6Qu9RKv1ppUpk+WbSr3DSg1pZz0sA6Or5V7L9Xl?=
 =?us-ascii?Q?lXa6I5+9dOm0H7YRUSvZSG1EQV3dMlNJU9fr0iQD9TyUZMwNRGGDAr1IrDiY?=
 =?us-ascii?Q?UeKyWj4C33jZ3GuNnplkGsEe+FRy+lufc98E0Qxpuf/yf78wwqogCmi6pama?=
 =?us-ascii?Q?J8C1jg+AWBHtS7J3IXqb8xy0YKPRS61hk2+TeYbkz18O3ZQVM+/7KEZ+VHRZ?=
 =?us-ascii?Q?wpZiGhvk8AlO19vBnZrSN/54fU7xV1yr0r6qNPCQD3i5B8JKZmCcIUi10iIG?=
 =?us-ascii?Q?LX52TUqWUIm+6YqHG6lSeNPtaOFkxSYVnGH/jx4OUWwfJxazxQ7FgAeYLAm0?=
 =?us-ascii?Q?EYOEKMumOB7wk3ncOFeEPXM1wuCuLRxFI6/v9xFVBhseo80znKKV9uUjCntU?=
 =?us-ascii?Q?7Y7zUZq0Ph2hALUEVNE7VnpCWa8H5NfVAX573iGnbAvAeH0cAByVHqOxw7zo?=
 =?us-ascii?Q?Ld7h05Djukc0qA9AjpC8Sj+H3ipZUhVmG4B5tKNcFB9YDT+3m4+Go6rzKdNw?=
 =?us-ascii?Q?dPHgsNMllzdIflNjtKhhrpyTXbta70iaDC+ZoeL3GdaOtxz+mlHRDpJ4isp3?=
 =?us-ascii?Q?zrgusA4Ssb50QLMj3b+iGv2kd42+/1DIBx/l+xEeZPJnO2XLxy0infKcSFyi?=
 =?us-ascii?Q?LTxJjzhYbPcaPCfV1UgVhpBfn2JErrM/tgJCL6ozaeMj1ajPqsb/LQ+9Sb3h?=
 =?us-ascii?Q?T3HTm570JzPgMnN2uph1mynvZnmezuxAWTJgB5BZE6vthsQPFUj8OV5gOONW?=
 =?us-ascii?Q?yphpAllOvV+MFvsYkzm7WUtCWFrUjP23+WrIxhKjLNbUMK7rdu2mWW64P6mC?=
 =?us-ascii?Q?QzrQ+YqzvcTiQfKLu2y9TnvH94CVVtizEXhEZpnGYV8ijEz7VVo/69/BXZCP?=
 =?us-ascii?Q?JpPx+fZNzPLbQGpQpVjpxLbAB1jPKkG1KKR+7oPobCXUvTU9glkLvnQCdz0L?=
 =?us-ascii?Q?yMshvxWhWhYF36TX8NYzSt8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: cisco.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5896.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c0260d1c-e9aa-4b99-c8b2-08dc187cab9e
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2024 23:24:51.3913
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: l9uelnZMRUM7guvyNP1M8GtbaBG9AARkq/Kt7A/7nlKD0OgsEocoT/Feid8Zw+Vxknwq5CX/OnwUp9rjxOYZig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6413
X-Outbound-SMTP-Client: 173.37.147.252, alln-opgw-4.cisco.com
X-Outbound-Node: rcdn-core-1.cisco.com

On Monday, January 15, 2024 8:52 PM, Li Zhijian <lizhijian@fujitsu.com> wro=
te:
>
> Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_e=
mit_at() when formatting the value to be returned to user space.
>
> coccinelle complains that there are still a couple of functions that use =
snprintf(). Convert them to sysfs_emit().
>
> > ./drivers/scsi/fnic/fnic_attrs.c:17:8-16: WARNING: please use
> > sysfs_emit
> > ./drivers/scsi/fnic/fnic_attrs.c:23:8-16: WARNING: please use
> > sysfs_emit
> > ./drivers/scsi/fnic/fnic_attrs.c:31:8-16: WARNING: please use
> > sysfs_emit
>
> No functional change intended
>
> CC: Satish Kharat <satishkh@cisco.com>
> CC: Sesidhar Baddela <sebaddel@cisco.com>
> CC: Karan Tilak Kumar <kartilak@cisco.com>
> CC: "James E.J. Bottomley" <jejb@linux.ibm.com>
> CC: "Martin K. Petersen" <martin.petersen@oracle.com>
> CC: linux-scsi@vger.kernel.org
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> drivers/scsi/fnic/fnic_attrs.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/fnic/fnic_attrs.c b/drivers/scsi/fnic/fnic_attr=
s.c index a61e0c5e6506..0c5e57c7e322 100644
> --- a/drivers/scsi/fnic/fnic_attrs.c
> +++ b/drivers/scsi/fnic/fnic_attrs.c
> @@ -14,13 +14,13 @@ static ssize_t fnic_show_state(struct device *dev,
> struct fc_lport *lp =3D shost_priv(class_to_shost(dev));
> struct fnic *fnic =3D lport_priv(lp);
>
> -     return snprintf(buf, PAGE_SIZE, "%s\n", fnic_state_str[fnic->state]=
);
> +     return sysfs_emit(buf, "%s\n", fnic_state_str[fnic->state]);
> }
>
> static ssize_t fnic_show_drv_version(struct device *dev,
> struct device_attribute *attr, char *buf)  {
> -     return snprintf(buf, PAGE_SIZE, "%s\n", DRV_VERSION);
> +     return sysfs_emit(buf, "%s\n", DRV_VERSION);
> }
>
> static ssize_t fnic_show_link_state(struct device *dev, @@ -28,8 +28,7 @@=
 static ssize_t fnic_show_link_state(struct device *dev,  {
> struct fc_lport *lp =3D shost_priv(class_to_shost(dev));
>
> -     return snprintf(buf, PAGE_SIZE, "%s\n", (lp->link_up)
> -                     ? "Link Up" : "Link Down");
> +     return sysfs_emit(buf, "%s\n", (lp->link_up) ? "Link Up" : "Link
> +Down");
> }
>
> static DEVICE_ATTR(fnic_state, S_IRUGO, fnic_show_state, NULL);
> --
> 2.29.2
>
>

Looks good to me.

Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com>

Regards,
Karan