Received-SPF: pass (google.com: domain of linux-kernel+bounces-30631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 18 Jan 2024 17:29:33 -0600
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Rae Moar <rmoar@google.com>
CC: <linux-kernel@vger.kernel.org>, <kunit-dev@googlegroups.com>,
	<linux-kselftest@vger.kernel.org>, David Gow <davidgow@google.com>, "Brendan
 Higgins" <brendan.higgins@linux.dev>, <intel-xe@lists.freedesktop.org>
Subject: Re: Re: [PATCH] kunit: Mark filter_glob param as rw
Message-ID: <rxbsgrgk35tuolfskj6kca26y7ikawg2agmibtfhszi6iiak26@gnroerafwuw5>
References: <20240112001240.1710962-1-lucas.demarchi@intel.com>
 <CA+GJov4-sWm=MHp6S+4+WsZJjeFjEdLTB462j0sOym8P_sjKLA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CA+GJov4-sWm=MHp6S+4+WsZJjeFjEdLTB462j0sOym8P_sjKLA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2dNS2R0SFBoQk1GZnovajhueXpXamdXM3h6TjFIYUpMMnJaMW5QOTllWlp4?=
 =?utf-8?B?ZVk5bG4rT3JpM29laDY3cUZuRDFleE1VUWx6MWp3d05mcWVYa1lxbllmdWtL?=
 =?utf-8?B?YTUrMSt2VHpCVEZVcE5mbjZzcEkyYTNyUjMzbWhMenRTRjFidytNOW83U1JS?=
 =?utf-8?B?UlVsWVc2dkVRamtNQy9mZTlycWJVTy9tZExwZXczMzIzcEJLeDI2RW8zZHp5?=
 =?utf-8?B?aXBpenJoL1IzZUxBdlByNGFhek42UW9zZmQyOGtGckE0cCtrVnFORVVyZkZw?=
 =?utf-8?B?dmVlODdGSW5sclN0anVHamRPNDF5UEpOWE9yZWQ4SmZ5a3ZzbUdmUUgycVU1?=
 =?utf-8?B?TDJ5VU9obExSUE5FTGJnMFprTlA1T2FKMldWSDl6VlM2OGczcVAwenlkZ3hx?=
 =?utf-8?B?NkpYd1JCWk43aFdHTlJOSGRPM3VVV2tQQ3FJc09vbUhHTWJULzlja2hGeEZJ?=
 =?utf-8?B?d0svc2YyeVpLbllpbjhTYTNGVW02RG1CRmYxZlZ0SXdGTTAzWkxGOFBGelpo?=
 =?utf-8?B?cFM0OCtXZkpJSzViUXUwZmNMOEdNMmFMQmcxeXN5Zm8wZXlITS94V1FNcGtU?=
 =?utf-8?B?OG10djJjRnFETGZqMjVQWDE2cldjRmp5MElVU0gxNitLSVJwVVFwZkpxeDRZ?=
 =?utf-8?B?NWpteS9DdDJYUWFybnR5WWI5T2hvRDNuSUZkTlFyZHdiNUlPQTBuQXZFMXQ5?=
 =?utf-8?B?T0VEV2ZOL1VkOUFLUExramVwVVQ3eWdkOVhFZTFObll0SzhEcEYxa05OYVZH?=
 =?utf-8?B?OEFWbzhDNmZ2UmtzL0lwNTFGckJrbm9zZlVQY2Q5YjVMTE14bmNTT3NuVmFO?=
 =?utf-8?B?aXdSTVRwSDRSUHo0cmNDTFdqSU5vMVF3S1YwUVZ1LzkrTTFSOVYrUnZEUmM3?=
 =?utf-8?B?SHJ5MUxRdE50U1BIbjVMdFZmakMrcmhMN3FOMi9YUDZIVElGM2RvR0J1Lzlv?=
 =?utf-8?B?VTRrY0dYc3hPQVlXVnpINzNKbVdTWTZhZ1ZqMjY2dVdWcHdVMElVNFNVQk82?=
 =?utf-8?B?VzhmUjQwRDhGbjRMYjFiSlFOcVVBK3pkQk50aEtjY0pkUWxYQUhLRldZcDlr?=
 =?utf-8?B?Nno3Z25sOHM1MXBzU0JJNXpiWjVJODFuYXlLSnlnUVVmekhSYU9LM2w2Q3pk?=
 =?utf-8?B?TlVXVlNyUEYwNi9ZZVQxOS9XSWdzQlVMUjhobnVmN21Tc0p6TGZhYWRFbnFq?=
 =?utf-8?B?WDFTYVQ2OGdTR3BvQkxDYW1KV29XbTFnMTgzQzhiOWFYcmN5Ull2VWxPR2NZ?=
 =?utf-8?B?aVJ0Q2svTDR6U2hZcGVudDNhRTZiU2FHK0srMTlBQ1NvY2FHWE5lVEN6MStq?=
 =?utf-8?B?ck9ZZnBRUzhnaDB6SDZWcTFqVVYwbE5nTjRJUExEN1FTUHB3em80ekY4bEcv?=
 =?utf-8?B?ZUhmNnA4UFFBTS9OTEo2dkFyUDNySTZLNHlPcVJTTGN1bVdkZ0RCVHdIZFRq?=
 =?utf-8?B?YnBBbXcreWlKcWJBOWJobWFuazF2SDBXR2tLdVZVQkF0S1BJdVpiRVhYT3ZZ?=
 =?utf-8?B?SHJEU091UUpXL0dmcDFKRWo5RXRoWW9uWVdnK0l1WW5RSFlER1JUVW9KRFMr?=
 =?utf-8?B?TnRTNnlRenZQbXhjVU5Ya2RjSFJCUzc1UFdMd1ZCZEs3ZkVYSktQcFJCNmpY?=
 =?utf-8?B?NzVyOEN5ajZYS0tXUWxyTWlKNDcvN0llVm1mTmdodWNpRVhoUlZvTTlOWnZ0?=
 =?utf-8?B?T2NiTUJjNXNOaXJ6Y3RVMzl2OVBGUGdCc2YybHNZWFpxZkV3TEl3L0hMR3dP?=
 =?utf-8?B?NjI3Y2JBenc4UVo3cVM2Z0h6MmplbDZWdmpML1pYZUlGNEo4dUVyYVVHYWVu?=
 =?utf-8?B?K3l2UE5hMlJ2ZjZiY0Fack5iVnl1Z1pHS1B6UTM1Z0ZlOUtkeEdtZGZjSjc0?=
 =?utf-8?B?RWx3ZlZlZzBySU5QVEIzNXRlYnhFSCtLOHhTSnJIMVNQb3RMVUJZL1pWNGVt?=
 =?utf-8?B?VS8yUzBrVXB1Ti9rSGNyRm5SYU41TFZINXFScnhpQTY2aldtY2NTbzlkc21r?=
 =?utf-8?B?Snd2V0JqMFRteC9VdWZMMDJxcFdjeHNhVTlnM3BMSFFQMjV2T0M3Yzlma0Zq?=
 =?utf-8?B?eU1HdnBkVFZvUHh0MDBycmVSSlZGdDdMMXcrbUJnNUZQQkx1SWVRckJlSkhK?=
 =?utf-8?B?M3AyVWJsK3FnazJQMkkzNXhiOEVVQkRXZzBsQkdRM0JzaHYvZExsNFFVMmFr?=
 =?utf-8?B?Qmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ae70bb36-0866-41e8-7669-08dc187d552e
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2024 23:29:36.0145
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: smAt5UW8qXNKkQb2CkLMeoQmOhlZqBb0gcgBEz6G5KgwbRmxeUWTm+qSl+KikSvRD3IT3vz83vJ3FfDK8evQvovE2+BocPVIHrQxW4pVF0Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7880
X-OriginatorOrg: intel.com

On Thu, Jan 18, 2024 at 05:23:33PM -0500, Rae Moar wrote:
>On Thu, Jan 11, 2024 at 7:13 PM Lucas De Marchi
><lucas.demarchi@intel.com> wrote:
>>
>> By allowing the filter_glob parameter to be written to, it's possible to
>> tweak the testsuites that will be executed on new module loads. This
>> makes it easier to run specific tests without having to reload kunit and
>> provides a way to filter tests on real HW even if kunit is builtin.
>> Example for xe driver:
>>
>> 1) Run just 1 test
>>         # echo -n xe_bo > /sys/module/kunit/parameters/filter_glob
>>         # modprobe -r xe_live_test
>>         # modprobe xe_live_test
>>         # ls /sys/kernel/debug/kunit/
>>         xe_bo
>>
>> 2) Run all tests
>>         # echo \* > /sys/module/kunit/parameters/filter_glob
>>         # modprobe -r xe_live_test
>>         # modprobe xe_live_test
>>         # ls /sys/kernel/debug/kunit/
>>         xe_bo  xe_dma_buf  xe_migrate  xe_mocs
>>
>> References: https://lore.kernel.org/intel-xe/dzacvbdditbneiu3e3fmstjmttcbne44yspumpkd6sjn56jqpk@vxu7sksbqrp6/
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
>
>Hello!
>
>I have tested this and this looks good to me. I agree this is very
>helpful and I wonder if we should do the same with the other module
>parameters (filter, filter_action).

yeah, after I sent this I was wondering about the other parameters. I
don't have a use for them right now, but I can try a few things and spin
a new version if people find it useful.

>
>It did worry me to make filter_glob writable due to the recent patch
>that requires the output of filtering to be a valid virtual address
>but I think there is a sufficient amount of checking of filter_glob.
>
>Thanks!
>-Rae
>
>Reviewed-by: Rae Moar <rmoar@google.com>

thanks
Lucas De Marchi