Received-SPF: pass (google.com: domain of linux-kernel+bounces-30634-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 18 Jan 2024 23:34:05 +0000
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Andre Werner <andre.werner@systec-electronic.com>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: adin1100: Fix nullptr exception for phy
 interrupts
Message-ID: <Zam1bWV+yZqq07FR@shell.armlinux.org.uk>
References: <20240118104341.10832-1-andre.werner@systec-electronic.com>
 <322d5543-4d13-48a7-af58-daa8cc840f05@lunn.ch>
 <727d83ab-3315-4b5c-84da-25f8ffd6aca5@gmail.com>
 <4e30f871-c7b7-4dc5-ba4c-629a63dc3261@lunn.ch>
 <70a4f7de-6032-4247-a484-56d1fdcee7f8@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <70a4f7de-6032-4247-a484-56d1fdcee7f8@gmail.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

On Thu, Jan 18, 2024 at 10:24:03PM +0100, Heiner Kallweit wrote:
> This would save us here, but can't prevent that phydev->irq may be set
> even later. I think, ideally nobody should ever access phydev->irq directly.
> There should be a setter which performs the needed checks.
> But it may be a longer journey to make parts of struct phy_device private
> to phylib.

Yes, I have been thinking over the last couple of days through reading
these emails that's a path that's needed to go down to stop drivers
poking around in stuff that should be private to phylib. So it's
something I would support.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!