Received-SPF: pass (google.com: domain of linux-kernel+bounces-30655-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Paller, Kim Seer" <KimSeer.Paller@analog.com>
To: Conor Dooley <conor@kernel.org>
CC: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Jonathan
 Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        "Hennerich,
 Michael" <Michael.Hennerich@analog.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>, Crt Mori <cmo@melexis.com>,
        Linus Walleij
	<linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>
Subject: RE: [PATCH v6 1/2] dt-bindings: iio: frequency: add admfm2000
Thread-Topic: [PATCH v6 1/2] dt-bindings: iio: frequency: add admfm2000
Thread-Index: AQHaSeyhcow0swT57keZetZEWhgOabDfvaqAgACHJ3A=
Date: Fri, 19 Jan 2024 00:30:09 +0000
Message-ID: 
 <PH0PR03MB71410860593D3C7253B200FCF9702@PH0PR03MB7141.namprd03.prod.outlook.com>
References: <20240118085856.70758-1-kimseer.paller@analog.com>
 <20240118085856.70758-2-kimseer.paller@analog.com>
 <20240118-steadily-coauthor-de8275118901@spud>
In-Reply-To: <20240118-steadily-coauthor-de8275118901@spud>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?+7j8FAqLfnxmAiI0zq83y8L9xMnyyfepHZyfQnhfkB2Pf347m7nXKIxeezcu?=
 =?us-ascii?Q?mYkvk9InxXWfWkblKEQk5EI6tCRhwMJqBG4BkFsWxRT9WYpH/NtIUn9vle5H?=
 =?us-ascii?Q?kK3Wlev0+zIN5/S269nuAil7VCnYG4LIhGOH8FPo5hneEtYRblY88AfW2DI9?=
 =?us-ascii?Q?CRWsEtJA4poRi4ML6xTiJWeohhVbOZ2T5GCw8lyFmbfdG8aS0vm26WC+l183?=
 =?us-ascii?Q?EmqjLBrCfeFWyQ6EoXepC0Lnw5M9TPQez4sZspnVg/+rd6psciML23zZmiGm?=
 =?us-ascii?Q?/fI/V+LzqeFMtLwnJqFuNK1io+KcOZdqvEadjMFUxw1YdrDxEFIp5SgJccGd?=
 =?us-ascii?Q?AGBXE9eH2K3Nui1o3qt7r7kMUxHu+42B2PPuePlAAbqtJLYNn6q6xI8WrI3l?=
 =?us-ascii?Q?vP8Buy+Sv/RsfsdJ6mj0AG+Eoqy/+MuPTRh9SYAc60sy8NXT0kwkUv2e9BSO?=
 =?us-ascii?Q?GNdXijN9U872u73k4HPkwTFRFzgAP7phxjan+iDo9LUcWrmfrs5LOQ8pN37h?=
 =?us-ascii?Q?KG9pLRsyTfPPULmkCypxV35WDLvKaRABjcaQCLD3PKx/Sy702FNnf7JDPyYc?=
 =?us-ascii?Q?eHwOCMVSwq+zkZCq5NC3tuFA8VUdtrw0HG1UHC6tOyiv0a98/1a/Vfz7MfgN?=
 =?us-ascii?Q?lIANelvp+vCxdxJ/y3VECZSu/XRFyIdOZW7JiDscIa+gfwxpqFc2z15QU2wE?=
 =?us-ascii?Q?UpqZ3aIc7notzsc+VCNCvPH1KTcSqxrWL0frxCK4lRqB7hVmiT6IZVUZslqV?=
 =?us-ascii?Q?TjUi/EOI5HqkqRBhL/JMKEnoHK1/yGuMrPVuidEvJweXLxwWmKfKYjK2EykY?=
 =?us-ascii?Q?emDkKA0Msubj6fyPL6e4osmJcX+sESw2S6w5FiRuOK7mgGmz1IeVhAQxom40?=
 =?us-ascii?Q?3Vzp88MItYBZ9sUbMW9kR3ObhrdWI20zRzEbf6Zvry9ozp0sNq5FZxRNFNyy?=
 =?us-ascii?Q?dDAQonRXWKJqO9K7sGcyONb//XJ62hYlNsok4hTDn1VzdqCXUDL3/m7jyMxZ?=
 =?us-ascii?Q?H1uBAzqEwK8HwHYSx2QQcEeF8OjLeGC3mb210W5ai0Y9SczqvCsErgk5RA4g?=
 =?us-ascii?Q?+piDG6CF5i2VGMUOOiMsym8YDFnKuShQ+3bw6b+CL9MzCzSwv/aPOhNTJ6j+?=
 =?us-ascii?Q?6j1YYdKQda0yhbNOxuwY14iP8uvN3IPyjTg9Kyi2ApL0S6P9H4Ih6rMb0RCY?=
 =?us-ascii?Q?0iAx4P4wHz9pjqkSBxkrS/0euk2JCTPeyz/k5T5UPg9dB5JEz4Y17XaocIrp?=
 =?us-ascii?Q?NfEyKzluxT8YOFV+3ds53UXloxUyWzwpXfI6FAKOspoNFZuOIDNKU9XTZ+JY?=
 =?us-ascii?Q?Tv3X2v56OnWbKfET6kHBTiLFZ9KXR35IMFXhBxFaU2ZQoLJlHrRzd+UtOjbJ?=
 =?us-ascii?Q?jgYULTyVrpo1DtvGrvggVHwu2vncUsStPhhtBGpTNWPLQjhqPxbOKViRhx1s?=
 =?us-ascii?Q?yo84s+cVUTjmYEGczs7qF6BiAheUtFK2whZsEEh1jVu3D6XtumqCXKLZy4Mc?=
 =?us-ascii?Q?XTDAy5GAHCrXrSxnJzXVQosirW76f9IwTWvfdA5fgtxF5bA40YC3XFLYl3L1?=
 =?us-ascii?Q?CdWqOTtpEQliY5/ps/eGZX0m78SLsbHskpdPpkYDDamv9sLMPY19dp33aUeU?=
 =?us-ascii?Q?fA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB7141.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2acf857-12d7-4476-1d4b-08dc1885cb11
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2024 00:30:09.6088
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Db0OV0k5D9mXrnVVW7WpMPjQpwteBhaCOlkySVukeZazli8bncj+lWxPrGVBhx9WDa+dTVqlAaob/UtWJ/wqAlQKye55xt2P6xFyXfovNsg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6434
X-Proofpoint-GUID: LuEio_kkwe7yShR-_nd9QVBHrM5oW1cZ
X-Proofpoint-ORIG-GUID: LuEio_kkwe7yShR-_nd9QVBHrM5oW1cZ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-18_11,2024-01-17_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0
 clxscore=1011 priorityscore=1501 mlxlogscore=999 spamscore=0 adultscore=0
 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2311290000 definitions=main-2401190001

> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Friday, January 19, 2024 12:10 AM
> To: Paller, Kim Seer <KimSeer.Paller@analog.com>
> Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; Jonathan Cameron <jic23@kernel.org>; Lars-Peter
> Clausen <lars@metafoo.de>; Hennerich, Michael
> <Michael.Hennerich@analog.com>; Rob Herring <robh+dt@kernel.org>;
> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> <conor+dt@kernel.org>; Crt Mori <cmo@melexis.com>; Linus Walleij
> <linus.walleij@linaro.org>; Bartosz Golaszewski <brgl@bgdev.pl>
> Subject: Re: [PATCH v6 1/2] dt-bindings: iio: frequency: add admfm2000
>=20
> [External]
>=20
> Hey,
>=20
> On Thu, Jan 18, 2024 at 04:58:55PM +0800, Kim Seer Paller wrote:
> > Dual microwave down converter module with input RF and LO frequency
> > ranges from 0.5 to 32 GHz and an output IF frequency range from 0.1 to
> > 8 GHz. It consists of a LNA, mixer, IF filter, DSA, and IF amplifier
> > for each down conversion path.
> >
> > Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
> > ---
> > V5 -> V6: Moved array of switch and attenuation GPIOs to the channel no=
de.
> >           Changed pin coords with friendly names. Removed Reviewed-by t=
ag.
> > V4 -> V5: Added Reviewed-by tag.
> > V3 -> V4: Updated the description of the properties with multiple entri=
es and
> >           defined the order.
> > V2 -> V3: Adjusted indentation to resolve wrong indentation warning.
> >           Changed node name to converter. Updated the descriptions to c=
larify
> >           the properties.
> > V1 -> V2: Removed '|' after description. Specified the pins connected t=
o
> >           the GPIOs. Added additionalProperties: false. Changed node na=
me to
> gpio.
> >           Aligned < syntax with the previous syntax in the examples.
> >
> >  .../bindings/iio/frequency/adi,admfm2000.yaml | 129 ++++++++++++++++++
> >  MAINTAINERS                                   |   7 +
> >  2 files changed, 136 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/iio/frequency/adi,admfm2000.yaml
> >
> > diff --git
> a/Documentation/devicetree/bindings/iio/frequency/adi,admfm2000.yaml
> b/Documentation/devicetree/bindings/iio/frequency/adi,admfm2000.yaml
> > new file mode 100644
> > index 000000000000..6f2c91c38666
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/iio/frequency/adi,admfm2000.yaml
> > @@ -0,0 +1,129 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright 2023 Analog Devices Inc.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/frequency/adi,admfm2000.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ADMFM2000 Dual Microwave Down Converter
> > +
> > +maintainers:
> > +  - Kim Seer Paller <kimseer.paller@analog.com>
> > +
> > +description:
> > +  Dual microwave down converter module with input RF and LO frequency
> ranges
> > +  from 0.5 to 32 GHz and an output IF frequency range from 0.1 to 8 GH=
z.
> > +  It consists of a LNA, mixer, IF filter, DSA, and IF amplifier for ea=
ch down
> > +  conversion path.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,admfm2000
> > +
> > +  '#address-cells':
> > +    const: 1
> > +
> > +  '#size-cells':
> > +    const: 0
> > +
> > +patternProperties:
> > +  "^channel@[0-1]$":
> > +    type: object
> > +    description: Represents a channel of the device.
> > +
> > +    additionalProperties: false
> > +
> > +    properties:
> > +      reg:
> > +        description:
> > +          The channel number.
> > +        minimum: 0
> > +        maximum: 1
> > +
> > +      adi,mode:
> > +        description:
> > +          RF path selected for the channel.
> > +            0 - Direct IF mode
> > +            1 - Mixer mode
> > +        $ref: /schemas/types.yaml#/definitions/uint32
> > +        enum: [0, 1]
>=20
> How come this is an enum, rather than a boolean property such as
> "adi,mixer-mode"?

I used an enum, perhaps because it was easier to implement. However, this
could be changed if a boolean property might be more suitable in this case.
Is that the preferred option?

Best regards,
Kim Seer Paller