Received-SPF: pass (google.com: domain of linux-kernel+bounces-30683-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Subject: Re: [PATCH] block: Move checking GENHD_FL_NO_PART to
 bdev_add_partition()
To: Jens Axboe <axboe@kernel.dk>, Li Lingfeng <lilingfeng@huaweicloud.com>,
 allison.karlitskaya@redhat.com, hch@infradead.org, yukuai1@huaweicloud.com
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
 houtao1@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com,
 "yukuai (C)" <yukuai3@huawei.com>
References: <20240118130401.792757-1-lilingfeng@huaweicloud.com>
 <f6e687cc-debd-4864-901a-fb35be9f2adc@kernel.dk>
From: Yu Kuai <yukuai1@huaweicloud.com>
Message-ID: <00c59648-bbf3-7ae4-4cea-aeccbb2bfe0c@huaweicloud.com>
Date: Fri, 19 Jan 2024 09:27:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <f6e687cc-debd-4864-901a-fb35be9f2adc@kernel.dk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

在 2024/01/18 23:20, Jens Axboe 写道:
> On 1/18/24 6:04 AM, Li Lingfeng wrote:
>> From: Li Lingfeng <lilingfeng3@huawei.com>
>>
>> Commit 1a721de8489f ("block: don't add or resize partition on the disk
>> with GENHD_FL_NO_PART") prevented all operations about partitions on disks
>> with GENHD_FL_NO_PART in blkpg_do_ioctl() since they are meaningless.
>> However, it changed error code in some scenarios. So move checking
>> GENHD_FL_NO_PART to bdev_add_partition() to eliminate impact.
> 
> This looks fine, but it's identical to the one sent out by Yu two days
> ago. Hmm? Who's the proper author?

Lingfeng is my collegue and I told him that he should send a fix for his
formal patch. Sorry for the confusion :)

Reviewed-by: Yu Kuai <yukuai3@huawei.com>

> 
> Adding Yu.
>