Received-SPF: pass (google.com: domain of linux-kernel+bounces-30744-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Ankit Agrawal <ankita@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
CC: Jason Gunthorpe <jgg@nvidia.com>, Yishai Hadas <yishaih@nvidia.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "kevin.tian@intel.com"
	<kevin.tian@intel.com>, "eric.auger@redhat.com" <eric.auger@redhat.com>,
	"brett.creeley@amd.com" <brett.creeley@amd.com>, "horms@kernel.org"
	<horms@kernel.org>, Aniket Agashe <aniketa@nvidia.com>, Neo Jia
	<cjia@nvidia.com>, Kirti Wankhede <kwankhede@nvidia.com>, "Tarun Gupta
 (SW-GPU)" <targupta@nvidia.com>, Vikram Sethi <vsethi@nvidia.com>, Andy
 Currid <acurrid@nvidia.com>, Alistair Popple <apopple@nvidia.com>, John
 Hubbard <jhubbard@nvidia.com>, Dan Williams <danw@nvidia.com>, "Anuj Aggarwal
 (SW-GPU)" <anuaggarwal@nvidia.com>, Matt Ochs <mochs@nvidia.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v16 2/3] vfio/pci: implement range_intesect_range to
 determine range overlap
Thread-Topic: [PATCH v16 2/3] vfio/pci: implement range_intesect_range to
 determine range overlap
Thread-Index: AQHaR/f+hq/WnUlfoUWt4169ze8Rb7DeiekAgAHl30o=
Date: Fri, 19 Jan 2024 03:34:04 +0000
Message-ID:
 <SA1PR12MB7199D0108377FDC8AD4671E3B0702@SA1PR12MB7199.namprd12.prod.outlook.com>
References: <20240115211516.635852-1-ankita@nvidia.com>
	<20240115211516.635852-3-ankita@nvidia.com>
 <20240117143418.5696b00e.alex.williamson@redhat.com>
In-Reply-To: <20240117143418.5696b00e.alex.williamson@redhat.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=nvidia.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SA1PR12MB7199:EE_|PH7PR12MB5805:EE_
x-ms-office365-filtering-correlation-id: 49d18cc8-2626-4b48-9750-08dc189f7c6b
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 VBPhn1rDY+0aVjFRfrK53WXiYo6Xl3zQCS3SI7erjxG2aTbxmPfI1egIwz9v6jmM7pgELt8pUl5ORArr9Ay7dBVwnzkGLQeWp+MpEDjLvr5RhByqiyQOjCkxr26gDMa8RlxAIRdPgWAVwPk9UsM+HfUJbGu4ztl8OsdpNr7yA/qT+s4JfrGPgQBMn5Ngo/o4//jnc1ngk/1gjUcCgfujaQ44cNwL4Z1Qa0ugzvLuX6kCr6/H9EX/BAeO1BrA51iGYBPXSQ9pqOdB/F/z9YLlOZMbORaiwFk2SgDzu/lPN7zNuB9nuCVOMewjaujKp3H9JIKcb28IFGpcIEfJ9xabyMaVpk+j3qggpw3/Pe4ME9JQCVl+5gE6jAKvo0kZ5G4DMHih8mxVK0UiTYtYA56d/j28jNNGUIdSd/sWoisixk5DYoarQXUYALI42GIiW8fq3gEepcfK4kjie1Yauyh5g1tJ1/Y1hg338p47dBEP3RFnJJ9gP5JsfONp6Q9dN3OkbBOp3uLi2cVK1tSxUz/nLmaPRsztdBVHH2amr1Bh0vXu2TwrP71jxTwmD+MoWjL40TjxyuNSmnJEk0Pf3x6aebZ3zEO41WhWDgSenRzW6iB5ItzPtjCgNrpa67ckgdOWxsEc4bUOCZHA3g6gFE5NRg==
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR12MB7199.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(136003)(376002)(366004)(346002)(39860400002)(396003)(230922051799003)(64100799003)(186009)(451199024)(1800799012)(55016003)(83380400001)(38070700009)(33656002)(86362001)(316002)(5660300002)(26005)(9686003)(122000001)(4326008)(8936002)(478600001)(91956017)(966005)(66946007)(8676002)(7696005)(71200400001)(66446008)(54906003)(66556008)(76116006)(6916009)(64756008)(38100700002)(66476007)(41300700001)(6506007)(2906002)(52536014);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-1?Q?JGB2l8J6z3X6uIkCtD/JR46rcIjo9EXNVIq5LxTddnwx9s+jb8rofDBqDg?=
 =?iso-8859-1?Q?860HfXL0GCp8EagC7+AyxkKbrJH3TMeDcEYxrpm0zY18/uHGNq+pXEIoe6?=
 =?iso-8859-1?Q?PWJPBZa7/jTLPLtPdoE0104FfeLEbTG8eF6gjqYtKJ7wdixHDeSZ5CI7jL?=
 =?iso-8859-1?Q?GBgyQGMkM8vlR7VhkiEVF2/QYbkusIKd9RzSAOLbwXEQyijzu2QHyvOJ4m?=
 =?iso-8859-1?Q?8/+YytqUpdymBC+/HdE+ZvybXMzORg4rT13p+9U5FhsahpJFWH42CuzSwJ?=
 =?iso-8859-1?Q?bpxjoP6J8DUvcH/zn3dOoFbWPlHiRl3DmLNUVhyDi7oVM/+R/O0a2k3/mK?=
 =?iso-8859-1?Q?WkftgOSEBoiTmsOpGNYJkE7LNBCYjOVEAZHcL4jvM0X3D5lgkHeD8UiGnk?=
 =?iso-8859-1?Q?szE9rXz535RnMzGUeVqfm5tyHIYU7lNG6ZS1kmLmVXi6KAnW5gY9Vpsqkq?=
 =?iso-8859-1?Q?RPu1ue9NjXlk3KjHaEB/gouupIMbfdEIAWiYG9QExA/sg0XjtHlFjP/7Mu?=
 =?iso-8859-1?Q?rsrIlrRtrUhA3qOMOJn8B2STj0upTlHUGsBYdTvxlcmmBB3QITZOxJ06PC?=
 =?iso-8859-1?Q?sL9LBThR1zXURjsfoJj2KmZvr00iMQlVQa5J6jBix0BsyaSfvQ1AYu0tiP?=
 =?iso-8859-1?Q?IcgWgAkGfRys3VINFhdxpuuxywZzeoMw37Vcb2BZLfTtZN92ILKduP47ZK?=
 =?iso-8859-1?Q?bhWDxXHo1WvkwMx7FjAOeyBAwQRoAWIZl62oXsqR4qK501IHB0AFkCV5dN?=
 =?iso-8859-1?Q?S9LxW7ksUpB1x0alFP12u6Pm8LuYURO+VuipRpXBDcnvXQYXfNSllt4OMG?=
 =?iso-8859-1?Q?tSJfJdFEYXjms29EBngox6mvcbf1dXtHnO781fx9Mo1ziKvOPA5uYRRZwh?=
 =?iso-8859-1?Q?KNy+gNWsOAg+X481wx7AgdCzRpTDKhl4fj9dzY9cV2nvthfRH4BEud2rus?=
 =?iso-8859-1?Q?GHTbkJpmAi+9f9cV+sz4l8DXQtaWuzsYI5iLsF1U0Jq2R+VG6Z+XgoMGGf?=
 =?iso-8859-1?Q?FzbsztZLmP4vGU5NclKLayR2P70GKgzeB5xLkYc/64rkAfXI0OJZNLAUVC?=
 =?iso-8859-1?Q?6/G8dzd0LXWGbk707+SLn61bwdQ/K6C6XVR3iy//q4AmoRp5WHZZ36h+sm?=
 =?iso-8859-1?Q?7OfrWcec/LzWMp076DQtS0PwmXSxX88CT0qHh+BVA53+RAcL+uCnL1CBak?=
 =?iso-8859-1?Q?ZSYLaCU9IcZaWKSnBA+69vaBbX7gAhGdwtfKAMZfRxo22Fj7CTmZhxAFtL?=
 =?iso-8859-1?Q?N1fp57XPcHu6hywceLJsmnRiu/jgE19KwQOXiqMB5sHHIpvpgRtkNsxmVS?=
 =?iso-8859-1?Q?LePQXFxx+e367aBm0NPspHWv/hStRfCz1iZOatpvuNP39M+a0niB15AMvW?=
 =?iso-8859-1?Q?FzQxvlvCCSkhri5x85lxFOyud2CZVZAp/94k5dqaUswOdzqUhwVzqFf7wK?=
 =?iso-8859-1?Q?L+X+WIVPcLTBvEVXwQG9xEfhnT5eW3zNCujw5NKI1DkJ/sbuElv1bxpbas?=
 =?iso-8859-1?Q?3wL5tIh2cbYoJ55x0fic64NWA/Wdk9VuJvs4Gdc67FdkOTCQgXLojGe8EA?=
 =?iso-8859-1?Q?Le04E48UsFX/tk+olDBqpzQ+XC4/3BAvFYiMjaC5PVEkDCwgb80eskw5YL?=
 =?iso-8859-1?Q?+XFHp8X2Hf4fg=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SA1PR12MB7199.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49d18cc8-2626-4b48-9750-08dc189f7c6b
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2024 03:34:04.5878
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FkCN1zH273F+kUQ4GtxzYcl9FJlelllU/txyRZ/d/4oUtjkaaedLgOR9hF6BNTb0l6r733M7OmzHCchtc21qJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5805

=0A=
>> Add a helper function to determine an overlap between two ranges.=0A=
>> If an overlap, the function returns the overlapping offset and size.=0A=
>>=0A=
>> The VFIO PCI variant driver emulates the PCI config space BAR offset=0A=
>> registers. These offset may be accessed for read/write with a variety=0A=
>> of lengths including sub-word sizes from sub-word offsets. The driver=0A=
>> makes use of this helper function to read/write the targeted part of=0A=
>> the emulated register.=0A=
>>=0A=
>> This is replicated from Yishai's work in=0A=
>> https://lore.kernel.org/all/20231207102820.74820-10-yishaih@nvidia.com=
=0A=
>=0A=
> The virtio-vfio-net changes have been accepted, so this will need to be=
=0A=
> rebased on the vfio next branch or v6.8-rc1 when Linus comes back=0A=
> online to process the pull request.=A0 The revised patch should=0A=
> consolidate so that virtio-vfio-pci also uses the new shared function.=0A=
=0A=
Thanks for pointing that out. I'll rebase it with v6.8-rc1.=0A=
=0A=
> As noted by Rahul, the name should be updated to align with the=0A=
> vfio-pci-core namespace.=A0 Kerneldoc would also be a nice addition since=
=0A=
> this is a somewhat complicated helper.=A0 Thanks,=0A=
=0A=
Ack.=0A=