Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp756072rdb; Thu, 18 Jan 2024 19:42:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IE0yXSZMJNT5mE+Fjdt3/ZGOqoLOGzCckaGpAbCs9X89GAOzMsqQ3jmrf1adUVhgZM/WcPs X-Received: by 2002:a05:6a20:3950:b0:19b:5b1c:a36e with SMTP id r16-20020a056a20395000b0019b5b1ca36emr2271171pzg.119.1705635721067; Thu, 18 Jan 2024 19:42:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705635721; cv=pass; d=google.com; s=arc-20160816; b=uxCoeDjTWYXQIbUChvQ0hbkHO3H0SRYyqjzF10hYqB2Sbyf1b4Vnz608vMUwGZj/VA QPxpCK/KUD2XL7oAi5ZTX0sZc1tstzK5dxtY3pg2KQCag1/1DKY5u5cpZ8nDVuiHawmn 5IFvbceItSrt8IGD10KhWV1gAMq7u0LmtE1LgIgw1t1blyyKOOK0UX8ZRh61yZQPra9C NKzJCYBpJHYnyOnJhtpnsix2TEinl1ITeqv7/vzEM71Jrtm56DEFy5HUfK5E31S4EBE+ qOwn2l/ODu/EFJRp5UQ11I8hX9NPPbRUd1Qp0agw1kWImHPPCtYtU5naw3zBGX4EhXna oR3w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=veCiEsqVWvr855N8CsNecs1JVSOHJt/OkhWeWPcyX1c=; fh=hoqdMAsEIC8LSB17poZ3ZBgrVML2MboGEKUNLojR/Ts=; b=zcjkHknmWXGojd8XWFHYOehZW4USpFrcmlGPVy3D6Bf3s5rUqrTmPKB6nHPeg/kWp2 tcqMsaXw17TapNwff90ZK4BKCX5cyKUFYCuuB1H/1m+x2lUk8/XBIFQj3lqTH0zAhp+z FnJefGNmPFjAKvbILf5FseZrnsCVgh1JA53ykGHkF1EjzDHm+zunWiL5nhJY5qFEGXLN JLH/c/eMeMNhahMYw59qBsZeFSmLlzzaU3hdsYCrDnThMsNuL8oTkZkGs4okKn+vLcYz mBM6892Dem2ifzV5yBS/GeIdnbQO5G/EdD3Y94ikMa4i/TMktSUK4uWASX4u+pXhNfrv oFyQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="o/odK3UZ"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-30745-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30745-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id kp19-20020a056a00465300b006d99ed4ae9fsi4913932pfb.8.2024.01.18.19.42.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 19:42:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30745-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="o/odK3UZ"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-30745-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30745-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B1EBF286F0C for ; Fri, 19 Jan 2024 03:42:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D985920FD; Fri, 19 Jan 2024 03:41:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o/odK3UZ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDFE217F5; Fri, 19 Jan 2024 03:41:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705635714; cv=none; b=IevBV759+3gMMJkeT9SGBd6hM0zWEeG3bXnppkJ3n0uJFq+UsnrnHwFJA1qFQmWgkSyR6402C/Af8Gp47n3WPjSEyHIZ9xN+mWOnrpz7fSsItEHp+EG1KLy5S4G4bVCqb61a+gDXGg0h7/yitLUMYVo6f8Ya+quJLE2CtHno52k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705635714; c=relaxed/simple; bh=mE+18RpMxNDEldgrD0ZJ5krlhYOEQVs6xBkuGihScaM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TILmOqgN0H/htfL8cQv2c1A+YaQ3O5850uwsFsjPhDrgq85fO3IlWijmjDM4mSe9LgoHWJ2BilJyLN4J6B7imlrSlVHeT6V1XfxLCevL4hdgVNjpyECpFckU//OPSbKhmnN65+zHfOKBqt8253g7x7MmZdRGw/8RaKZ16TV6k2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o/odK3UZ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A91A7C433F1; Fri, 19 Jan 2024 03:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705635713; bh=mE+18RpMxNDEldgrD0ZJ5krlhYOEQVs6xBkuGihScaM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o/odK3UZhAspATqM8LiRbUA7EABwH9DjMp+ceJHh5JQ1JVKYaRnUd1pPU/sSD+C+b ZMmKNEyeuw6/MPDubdth0gVEFrv0fg6nseI2ehENKkQzHZxS967z3NBsJOFssWtgTg wKQzVf6b442uqXHj3DVLPsCNJsNsJxr+Pd97qM5gZaaELPn/AQXFg9Jcprn4g4Zfxj O97TCssQKtpeWZMF97wnomxE97pi6Rd4fttLcxFWVsyjT5i+kEI5BjS8HcbraM9ClZ i3sfIZR0XRrB1R43NHOwuoP6lc9cAEi+lK0Tv6yNdEDiagsrLJ/z2hxFU7LNV/o602 NUtpcd1g8JC8w== Date: Fri, 19 Jan 2024 11:41:49 +0800 From: Tzung-Bi Shih To: Lukasz Majczak Cc: Gwendal Grignou , Radoslaw Biernacki , Wim Van Sebroeck , Lee Jones , Benson Leung , Guenter Roeck , Krzysztof Kozlowski , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Subject: Re: [PATCH v2 1/3] platform/chrome: Update binary interface for EC-based watchdog Message-ID: References: <20240118195325.2964918-1-lma@chromium.org> <20240118195325.2964918-2-lma@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118195325.2964918-2-lma@chromium.org> On Thu, Jan 18, 2024 at 07:53:22PM +0000, Lukasz Majczak wrote: > +#define EC_HANG_DETECT_MIN_TIMEOUT 5 > +#define EC_HANG_DETECT_MAX_TIMEOUT 65535 EC_HANG_DETECT_MAX_TIMEOUT isn't in the latest ec_commands.h [1]. Could you either add EC_HANG_DETECT_MAX_TIMEOUT to ec_commands.h or drop the macro here? [1] https://crrev.com/5a76e67210b15fcf67d8a6f90439993598949ae4/include/ec_commands.h#4749