Received-SPF: pass (google.com: domain of linux-kernel+bounces-30770-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <e0fc158239e73f22405c78d5b3219c266e3763be.1705506665.git.jan.kundrat@cesnet.cz>
In-Reply-To: <e0fc158239e73f22405c78d5b3219c266e3763be.1705506665.git.jan.kundrat@cesnet.cz>
From: Namhyung Kim <namhyung@kernel.org>
Date: Thu, 18 Jan 2024 21:16:01 -0800
Message-ID: <CAM9d7cikvOQvUXMrRPM9g6W34zHJsbNquhJYiV9AgS40eGC3qw@mail.gmail.com>
Subject: Re: [PATCH] perf build: don't hardcode pkg-config path
To: =?UTF-8?B?SmFuIEt1bmRyw6F0?= <jan.kundrat@cesnet.cz>
Cc: linux-perf-users@vger.kernel.org, 
	"Yann E. MORIN" <yann.morin.1998@free.fr>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

On Wed, Jan 17, 2024 at 7:58=E2=80=AFAM Jan Kundr=C3=A1t <jan.kundrat@cesne=
t.cz> wrote:
>
> On Buildroot and when building for Arm using the Bootlin toolchain, the
> actual `pkg-config` is named just `pkg-config`, not
> `arm-linux-pkg-config`. This patch allows the external build system
> (such as Buildroot) to pass a working path.
>
> This is already done correctly in tools/build/feature/Makefile and
> tools/thermal/tmon/Makefile and also fixed in other places many years
> ago (9961aa665b70e47d6c80141c4a2482266010f246), but for some reason it
> was never fixed in this file.
>
> Signed-off-by: Jan Kundr=C3=A1t <jan.kundrat@cesnet.cz>
> To: linux-perf-users@vger.kernel.org
> Cc: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: linux-kernel@vger.kernel.org

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> ---
>  tools/perf/Makefile.perf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> index 86569f230e60..b69ab2ae77c6 100644
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -188,7 +188,7 @@ HOSTLD  ?=3D ld
>  HOSTAR  ?=3D ar
>  CLANG   ?=3D clang
>
> -PKG_CONFIG =3D $(CROSS_COMPILE)pkg-config
> +PKG_CONFIG ?=3D $(CROSS_COMPILE)pkg-config
>
>  RM      =3D rm -f
>  LN      =3D ln -f
> --
> 2.43.0
>
>
>