Received-SPF: pass (google.com: domain of linux-kernel+bounces-30776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240118191727.5547-1-palmer@rivosinc.com>
In-Reply-To: <20240118191727.5547-1-palmer@rivosinc.com>
From: Masahiro Yamada <masahiroy@kernel.org>
Date: Fri, 19 Jan 2024 14:29:47 +0900
Message-ID: <CAK7LNAQvGpf7zFR49-5TwE-mknGE_Kbw3JuQ+3Qf0dp+DvmSVA@mail.gmail.com>
Subject: Re: [PATCH] Makefile: Add HOST_GCC_SUFFIX and CROSS_GCC_SUFFIX
To: Palmer Dabbelt <palmer@rivosinc.com>
Cc: nicolas@fjasle.eu, nathan@kernel.org, linux-kbuild@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 19, 2024 at 4:20=E2=80=AFAM Palmer Dabbelt <palmer@rivosinc.com=
> wrote:
>
> From: Palmer Dabbelt <palmer@rivosinc.com>
>
> I was just trying to track down a build bug with an old toolchain.
> Turns out Ubuntu installs old GCCs as something like
> riscv64-linux-gnu-gcc-10, which is a bit clunky to point the build at
> without a way to append a suffix to CC.


You can do:

make CROSS_COMPILE=3Driscv64-linux-gnu- CC=3Driscv64-linux-gnu-gcc-10


>
> There's already LLVM_SUFFIX, but nothing similar for GCC.  I've split
> out the host and target suffixes as users probably don't have the same
> version of for both (unlike LLVM, where the cross compiler is likely to
> support the host target).
>
> Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
> ---
> I've only given this some very minimal testing, but it at least works
> for my simple use case.
> ---
>  Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index f1b2fd977275..36ce336cda3b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -433,8 +433,8 @@ endif
>  HOSTCC =3D $(LLVM_PREFIX)clang$(LLVM_SUFFIX)
>  HOSTCXX        =3D $(LLVM_PREFIX)clang++$(LLVM_SUFFIX)
>  else
> -HOSTCC =3D gcc
> -HOSTCXX        =3D g++
> +HOSTCC =3D gcc$(HOST_GCC_SUFFIX)
> +HOSTCXX        =3D g++$(HOST_GCC_SUFFIX)
>  endif
>  HOSTRUSTC =3D rustc
>  HOSTPKG_CONFIG =3D pkg-config
> @@ -480,7 +480,7 @@ OBJDUMP             =3D $(LLVM_PREFIX)llvm-objdump$(L=
LVM_SUFFIX)
>  READELF                =3D $(LLVM_PREFIX)llvm-readelf$(LLVM_SUFFIX)
>  STRIP          =3D $(LLVM_PREFIX)llvm-strip$(LLVM_SUFFIX)
>  else
> -CC             =3D $(CROSS_COMPILE)gcc
> +CC             =3D $(CROSS_COMPILE)gcc$(CROSS_GCC_SUFFIX)
>  LD             =3D $(CROSS_COMPILE)ld
>  AR             =3D $(CROSS_COMPILE)ar
>  NM             =3D $(CROSS_COMPILE)nm
> --
> 2.43.0
>
>


--=20
Best Regards
Masahiro Yamada