Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp793491rdb; Thu, 18 Jan 2024 21:36:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWbAuxvpHYEI14fBE8bhwFAYWds8sgbjQPlCAVfzdhPKmmNrbynpJaER3JIikVSz4nNp5v X-Received: by 2002:a05:620a:424f:b0:783:7eac:1d7f with SMTP id w15-20020a05620a424f00b007837eac1d7fmr1165576qko.28.1705642619772; Thu, 18 Jan 2024 21:36:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705642619; cv=pass; d=google.com; s=arc-20160816; b=Uq5+l5s1fWtInEdBX5TDIihTQifASeerdEsSJ5LJBXtWaqiE2r53k5hPAR61cIFXTU yd0W+lHC3b5RMGhJ0c0ew3aGnwQSlGKN82yPqf3qQqVcrCAn+oEnh+CEJc1X9twbjiRb l0OY8ASdGSNnLcNG8s8OYcVsY8jXBAr8laGLUOnlk6B7V38IoEcYosz6tzhA/3huDgQM ZdBz5heraCSwUzPS9hFtiVDlH9qTRb+4X1sByMUd32WxsD8l8Gt0z/0JDpLOpNZD3bbV TYzYhfhQnw54R8rsWhDjFOmAWKlH6Q5vhJGYdyE6B+IZvun03YvFT4dOKwd23ThoTs7q MA9g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2ojAQrKurCVDTpDyr9Ud8UUA59iisRxNip7GO8MCjIo=; fh=Ia2guUmqLCCjVtTFFHZfndI7a0m4akKZ7BOO68qaQMk=; b=ZRXsni2aQM9U9YlFTT7Hw8oPuR8hzy2JQ682A5OIGwQo0Iqk7fDqSBNtmIjAmQIhQl 1dcfCcakhEzWOi7RvkCPbFTBYzGgZZsdfvVtRBKvnn/U4+GxBeBNlCAtQFVtwQEJwFkJ DBmy9kBkbHR9VK0gLFJZ37N/k+zKL3pYSd6dreO/6xELboX/b52hPsPw0xEGnhcrfQ4Q lGxysUyKBGfLxfyLlxXIPoRS6786dlpTDTj8ex8ftnZMNigc1TnC7c5w5Gh5lEKqIkta Ki7Tk76dZq0KmLjSeQGscLkob4HcCYSwa13v1+8Q5D26mFBk37FiPkl0PM3LHKdwN9lC UvtA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M8nWbyiV; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-30779-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30779-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id g11-20020a17090a9b8b00b00290026a37cdsi2678325pjp.2.2024.01.18.21.36.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 21:36:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30779-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=M8nWbyiV; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-30779-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30779-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D7646283EF6 for ; Fri, 19 Jan 2024 05:36:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 923564A3C; Fri, 19 Jan 2024 05:36:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="M8nWbyiV" Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33A7328E8 for ; Fri, 19 Jan 2024 05:36:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705642589; cv=none; b=ml4Shao5oFeiGtPH580Y83GL8/oO3P6zZD86RLSifGOjMKziPh0mdkFyXTqxbgm98bPeWHmQHCsRbcy/nx9TQ5qFEBZehIPGADiVJHWkD3tmNEJ+3hz+9EC6gJg4T/vZk7snapY6KEB9/mIWytyBWCn5Q3m3ZexfK1ZmLGsHuTI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705642589; c=relaxed/simple; bh=UovGzvb+o3TQm+lhjDvRfALrmTsObXHmB90BgTkj5mI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eHtRIV1Se+z0nS7mkF4kFtWBZ32NYCimGYvKNxtpILtJz00qYznEsP2s4I4V+Og8s4p8xgx/12XkHHDgFmRe8M8H5UFLfNozJWTXMyKBGOQuaJoL1dyBk1yxuYxiUP76jgk/y3da3CBjkgNkEe6rKYYk0zaFKtly5/emXt2/pB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=M8nWbyiV; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40e8801221cso3557955e9.1 for ; Thu, 18 Jan 2024 21:36:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705642586; x=1706247386; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2ojAQrKurCVDTpDyr9Ud8UUA59iisRxNip7GO8MCjIo=; b=M8nWbyiV3JVQFiqHOTnAgiA21RbmosLbk4Oz6t9/b6rgOIJUcDuiQXUW1/URtYWkY3 BBQfoWsGSNLEf8LJ3mom1/sMPIxVsP4O+JL/KE1EWV/zqxbzNIgv+pb33TE6i/S0Y60d xwBRV5QQn0VBWp8v6T3H6f5jRS6i9ps55M4wB4zEoiJ7zhIzTT3YSoyau7aEhMJCzipd 59TDAyJrTvgZ9Oewgo6Pg4MTomCoiJULVDaieGqUAmH56+X3Ylznom42CSzKgYorqK4j kXUCbwbAT0ZV8KMvJfpN/vjD2NipIqw+58jsDnepOo1BzPakL0VKz9U2RRnu3ONLE/yG 7tvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705642586; x=1706247386; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2ojAQrKurCVDTpDyr9Ud8UUA59iisRxNip7GO8MCjIo=; b=cBnzBAa+qArSj9dw9Y9yTgPWvPUKLzX0N5/KZPXwD1FzI8wBC+6aIpblnK5zjy8TRJ RDM92EQbdsLxKXCY2nRF83SAO5dMALjqrY4cfNwFan2TLxSB7FYIqbN7OfveOreVfTai 3FJgoP5NzrmcZpH8Hxn3BfkZGHXSQl8BBN/5ulMkhRlJp4BKgTLhN0tsFNH8Npk7m2kS KyhOWL2slLJEXB9m0+Ui/Yo237RZ8uK2BvkofPO5R4Ivcmq/esFjp+7bLOtBcIq+uCLC 2mgf466e80O/Gon+D/PpIUvw8d0bxrHxKGgGytNqH+65KyY5tB/+0jwmfUpYYYU+FUl4 oWig== X-Gm-Message-State: AOJu0YwxSYFIoxmnX9kacmpQxD7w51sYs7xVEfAgHAcrP9nZif/+kFxD kvHjhuc1f6IBBOqImQoKx0n0Y5ug/MOkmfX40KR2GZQ4WcfSUoN4N1HO2IYTTB8= X-Received: by 2002:a05:600c:1990:b0:40e:50ac:d24e with SMTP id t16-20020a05600c199000b0040e50acd24emr1438421wmq.13.1705642586217; Thu, 18 Jan 2024 21:36:26 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id l6-20020a7bc346000000b0040d81ca11casm27067641wmj.28.2024.01.18.21.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jan 2024 21:36:25 -0800 (PST) Date: Fri, 19 Jan 2024 08:36:21 +0300 From: Dan Carpenter To: dregan@broadcom.com Cc: dregan@mail.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, computersforpeace@gmail.com, kdasu.kdev@gmail.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, joel.peshkin@broadcom.com, tomer.yacoby@broadcom.com, dan.beygelman@broadcom.com, william.zhang@broadcom.com, anand.gore@broadcom.com, kursad.oney@broadcom.com, florian.fainelli@broadcom.com, rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com, andre.przywara@arm.com, baruch@tkos.co.il, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 05/10] mtd: rawnand: brcmnand: Add BCMBCA read data bus interface Message-ID: <4b3f4316-0da4-4fde-a806-7b579948db50@moroto.mountain> References: <20240118195356.133391-1-dregan@broadcom.com> <20240118195356.133391-6-dregan@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118195356.133391-6-dregan@broadcom.com> On Thu, Jan 18, 2024 at 11:53:51AM -0800, dregan@broadcom.com wrote: > diff --git a/drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c b/drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c > index 3e2f3b79788d..e97e13ae246c 100644 > --- a/drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c > +++ b/drivers/mtd/nand/raw/brcmnand/bcmbca_nand.c > @@ -26,6 +26,18 @@ enum { > BCMBCA_CTLRDY = BIT(4), > }; > > +#if defined(CONFIG_ARM64) > +#define ALIGN_REQ 8 > +#else > +#define ALIGN_REQ 4 > +#endif > + > +static inline bool bcmbca_nand_is_buf_aligned(void *flash_cache, void *buffer) > +{ > + return IS_ALIGNED((uintptr_t)buffer, ALIGN_REQ) && > + IS_ALIGNED((uintptr_t)flash_cache, ALIGN_REQ); > +} > + > static bool bcmbca_nand_intc_ack(struct brcmnand_soc *soc) > { > struct bcmbca_nand_soc *priv = > @@ -56,6 +68,20 @@ static void bcmbca_nand_intc_set(struct brcmnand_soc *soc, bool en) > brcmnand_writel(val, mmio); > } > > +static void bcmbca_read_data_bus(struct brcmnand_soc *soc, > + void __iomem *flash_cache, u32 *buffer, int fc_words) > +{ > + /* > + * memcpy can do unaligned aligned access depending on source > + * and dest address, which is incompatible with nand cache. Fallback > + * to the memcpy for io version > + */ > + if (bcmbca_nand_is_buf_aligned((void *)flash_cache, buffer)) > + memcpy((void *)buffer, (void *)flash_cache, fc_words * 4); > + else > + memcpy_fromio((void *)buffer, flash_cache, fc_words * 4); > +} This comment is confusing or maybe the if statement is reversed... We're falling back to memcpy_fromio() for the unaligned accesses but the comment says we're falling back to memcpy(). regards, dan carpenter