Received-SPF: pass (google.com: domain of linux-kernel+bounces-30783-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Dylan Hung <dylan_hung@aspeedtech.com>
To: <alexandre.belloni@bootlin.com>, <jk@codeconstruct.com.au>,
	<joel@jms.id.au>, <u.kleine-koenig@pengutronix.de>, <gustavoars@kernel.org>,
	<krzysztof.kozlowski@linaro.org>, <zenghuchen@google.com>,
	<matt@codeconstruct.com.au>, <linux-i3c@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
CC: <BMC-SW@aspeedtech.com>
Subject: [PATCH] i3c: dw: Disable IBI IRQ depends on hot-join and SIR enabling
Date: Fri, 19 Jan 2024 13:45:47 +0800
Message-ID: <20240119054547.983693-1-dylan_hung@aspeedtech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Received-SPF: Fail (TWMBX02.aspeed.com: domain of dylan_hung@aspeedtech.com
 does not designate 192.168.10.10 as permitted sender)
 receiver=TWMBX02.aspeed.com; client-ip=192.168.10.10;
 helo=localhost.localdomain;

Disable IBI IRQ signal and status only when hot-join and SIR enabling of
all target devices attached to the bus are disabled.

Fixes: e389b1d72a62 ("i3c: dw: Add support for in-band interrupts")

Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
---
 drivers/i3c/master/dw-i3c-master.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
index ef5751e91cc9..276153e10f5a 100644
--- a/drivers/i3c/master/dw-i3c-master.c
+++ b/drivers/i3c/master/dw-i3c-master.c
@@ -1163,8 +1163,10 @@ static void dw_i3c_master_set_sir_enabled(struct dw_i3c_master *master,
 		global = reg == 0xffffffff;
 		reg &= ~BIT(idx);
 	} else {
-		global = reg == 0;
+		bool hj_rejected = !!(readl(master->regs + DEVICE_CTRL) & DEV_CTRL_HOT_JOIN_NACK);
+
 		reg |= BIT(idx);
+		global = (reg == 0xffffffff) && hj_rejected;
 	}
 	writel(reg, master->regs + IBI_SIR_REQ_REJECT);
 
-- 
2.25.1