Received-SPF: pass (google.com: domain of linux-kernel+bounces-30790-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Klymenko, Anatoliy" <Anatoliy.Klymenko@amd.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Tomi Valkeinen
	<tomi.valkeinen@ideasonboard.com>, "maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>, "mripard@kernel.org"
	<mripard@kernel.org>, "tzimmermann@suse.de" <tzimmermann@suse.de>,
	"airlied@gmail.com" <airlied@gmail.com>, "daniel@ffwll.ch" <daniel@ffwll.ch>,
	"Simek, Michal" <michal.simek@amd.com>, "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] drm: xlnx: zynqmp_dpsub: Make drm bridge discoverable
Thread-Topic: [PATCH 1/4] drm: xlnx: zynqmp_dpsub: Make drm bridge
 discoverable
Thread-Index: AQHaSptvwR6+wKrLckmDc7xgQ1kfYw==
Date: Fri, 19 Jan 2024 05:50:41 +0000
Message-ID:
 <MW4PR12MB7165428B4A7A973D29E953C5E6702@MW4PR12MB7165.namprd12.prod.outlook.com>
References: <mailman.1627.1705504032.2418.dri-devel@lists.freedesktop.org>
In-Reply-To: <mailman.1627.1705504032.2418.dri-devel@lists.freedesktop.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?DirRGYh9yjoPmF8/4/nF5Gp5o0KbuT8loftV/yYXnDj2rE7GkSlWRRhFaooM?=
 =?us-ascii?Q?CLZNH8cqicf7WG4q3x1TC0wrxonqLNHlshpo0UcDYQgxnaQXpyqBaY2fW2Bb?=
 =?us-ascii?Q?niT+Og8oFdJCbMClUIGCcfdDte74QvwzlEap7Jc+/MyDjG9OyOF6+KbpTvs4?=
 =?us-ascii?Q?/ibJLGYRY6K2A6at6sn5BHmRlD0eUPu899phjmby1pawn5x6aFYQbxbkKl8p?=
 =?us-ascii?Q?ZMCs0XmifPS3z/ZzulV4ciFQ6PEbvy3CKskuSzFZ50GVz2RsQqna/W4Oz0pL?=
 =?us-ascii?Q?VGj3MrJdqvZ8vDDjdVX8IDBoHuda3HcjbN7qUCgvg98oZ9wRihIKxLEfHzJP?=
 =?us-ascii?Q?/f+y0ev5Fn0fyn4Z4cDNBrVpG8Uf0IrivUXVOrvdjxO87j3j5Vr539rSnso/?=
 =?us-ascii?Q?v+M8ehTEqEarlV2L/tfFKPT0YpF4/HGkDy7zQZJwghRZ1j0MPhWF71TfwgOr?=
 =?us-ascii?Q?HeAn1tRDfVnROFjDfxFtSwFb3TasDSmo+Bz3wOEQiZDE6hYumYSDSR5zhOKS?=
 =?us-ascii?Q?jsXNDhhmy7ILU9Ahu3fGj1OSr/oHByI+TFiNDtxZ55wedmYUGKMkS8JqiMNm?=
 =?us-ascii?Q?M1wrFgSPqvpanZ8/yvaWAmh/nmefeZ0ZPN7IaJr7NpK3F9p7H2IJtYKrnz2H?=
 =?us-ascii?Q?T4dOs5A2mqBFT+zCnV9a1qcxXI3NMdA1Prhn4EtEFLq7Ch9OmvQ84JKEnWrd?=
 =?us-ascii?Q?8n6RX0zv/IdVJijWnBEXgU3OWlxiwpSlSgK5x4HH/w0KdyvtgREYa+5ZP3bh?=
 =?us-ascii?Q?OwfrScMHETnv95o3X5Gkwo11AlvTW6PYTx66BEyiOwl+t69TOVua+MIvr2GO?=
 =?us-ascii?Q?rl/mq1HqGncj153y6ly0UZobSnFGEvv5EM9p3azswkuLBSoPDlToCiitm5R0?=
 =?us-ascii?Q?rXzJ7ZLtBIMs9f3lF5gTzYs99AWAE60gPunOdOEVQQF5GSr0Xp3txS9ra7pc?=
 =?us-ascii?Q?rNcDrs20VnGTZlYlZeeZrwxdyG2lyioyBRMOykh8UaEd6NsU/c2jUVrwDL7R?=
 =?us-ascii?Q?Aj8e1zW/2QgtSAc2l6VYriIXqFzZT1LkVFr26XidAN4znUbE7L4psKzjb/cm?=
 =?us-ascii?Q?/dccNCZ8RCj25cna24mLoPOHpy6EYWzTe5s2BT6HSY6MRFnHoV9jkUkWWXba?=
 =?us-ascii?Q?rkxOFDRlFlb19Tm0lOTsRVjhKJIEqxDQMsqs2xd/vcMOCW8QYZKb1h2p9lQE?=
 =?us-ascii?Q?BPZ8/76j29LEgDQEp2jCbzx2/fZV+GA+jST417DvXCjadvziT5Fy3btL7J0i?=
 =?us-ascii?Q?sUxawYG++xPAYLynnfd+abyQo3zaOZn1mZO0eFRX5Yz6pyC56ki0rBgrSryq?=
 =?us-ascii?Q?IsFVZoKjJTvV0rVNFf02sn40CsUKCbAFOLZBNJVmTvFkAZNeLlBAZsTyOETP?=
 =?us-ascii?Q?kvteDowa/rBsSB7P0nQD4W5mikxnfdrdVPk0dM5w29NXtU1QWyvWhQzLJfkb?=
 =?us-ascii?Q?OacZ0dziUGhhiTLXqDw8HYMjavG6HEsPJdj1jd92XqpEFOcSC2ulBu9zr3Sp?=
 =?us-ascii?Q?FtJF0+5GGHyukTBGRABLXBLFP2mF7Q4C21o80u+4uIdDwQa8LfBryyQbVBnb?=
 =?us-ascii?Q?ZfwpxwC8Dyku0DXfH1w=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7165.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2bfa826-c2eb-496f-99a8-08dc18b291f3
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2024 05:50:41.1288
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: V+NJ84kJvDeZ2y71S/RqPBu8Bsmon7T6RBeLazlUzGFdQrwtZMXsp5twvMBPiqSh4dcaYKPtakNgVLxwD92oRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7255

Hi Laurent,

Thank you for the reply.

> Date: Wed, 17 Jan 2024 16:24:20 +0200
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Cc: Anatoliy Klymenko <anatoliy.klymenko@amd.com>,
>         maarten.lankhorst@linux.intel.com, mripard@kernel.org,
>         tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
>         michal.simek@amd.com, dri-devel@lists.freedesktop.org,
>         linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.or=
g
> Subject: Re: [PATCH 1/4] drm: xlnx: zynqmp_dpsub: Make drm bridge
>         discoverable
> Message-ID: <20240117142420.GE17920@pendragon.ideasonboard.com>
> Content-Type: text/plain; charset=3Dutf-8
>=20
> On Wed, Jan 17, 2024 at 04:06:31PM +0200, Tomi Valkeinen wrote:
> > On 13/01/2024 01:42, Anatoliy Klymenko wrote:
> > > Assign device of node to bridge prior registering it. This will make
> > > said bridge discoverable by separate crtc driver.
> >
> > I think a few words on why this is needed (and why it wasn't needed
> > before) would be nice.
> >
> > Other than that:
> >
> > Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
>=20
> Agreed. With a better commit message,
>=20

Sure, I will update commit message in the next version.

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>=20
> > > Signed-off-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com>
> > > ---
> > >   drivers/gpu/drm/xlnx/zynqmp_dp.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > > b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > > index a0606fab0e22..d60b7431603f 100644
> > > --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > > +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
> > > @@ -1721,6 +1721,7 @@ int zynqmp_dp_probe(struct zynqmp_dpsub
> *dpsub)
> > >     bridge->ops =3D DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
> > >                 | DRM_BRIDGE_OP_HPD;
> > >     bridge->type =3D DRM_MODE_CONNECTOR_DisplayPort;
> > > +   bridge->of_node =3D dp->dev->of_node;
> > >     dpsub->bridge =3D bridge;
> > >
> > >     /*
>=20
> --
> Regards,
>=20
> Laurent Pinchart
>=20
>=20

Thank you,
Anatoliy