Received-SPF: pass (google.com: domain of linux-kernel+bounces-30809-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
References: <20240119060714.258635-1-chentao@kylinos.cn>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com,
 linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: nvidia-shield: Add some null pointer checks to the
 hid-nvidia-shield.c
Date: Thu, 18 Jan 2024 22:19:20 -0800
In-reply-to: <20240119060714.258635-1-chentao@kylinos.cn>
Message-ID: <87o7dhx2ny.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?ZM/Wnz2ZRhd963LSfl1huW22rRjzZXQo64011vyceGQnFNk8fxfH99NOD2od?=
 =?us-ascii?Q?AVfqnx7pH0BhkhvukF1AQs5DXBZ6yqyZgKBKuqVJzqhYwyUHHbOHYq9joC4Y?=
 =?us-ascii?Q?N+uL8ZDRAWlpXC8DeR7BGlD0w37cJ8IrG7lG/dC8S0nPpkav8dZnQtHnC3op?=
 =?us-ascii?Q?z3KRDrECSwbLUfT540HXS81MIS5F+kUdwWupyb1EiNzplwe7FqHMTnoI3EbQ?=
 =?us-ascii?Q?DEFOiEtXPgSB/b4a2Jxbk8weVoCjCHPGbqUpoj6WFHuhZeu+G5xCf6UmPhdc?=
 =?us-ascii?Q?Jxod25BOzdQetVqdNqr1MTY4tvjvzwPJLsGf74ODa2aXpcxKdkRz9xAdXLcc?=
 =?us-ascii?Q?5u1zB2qmbt+R1J0Iu82RokNV2WrCBSz9R9KZlF0fVSP7f7cS+FexU7ctlrtq?=
 =?us-ascii?Q?W98BFNioKDAKZsLIrNDwB3oHmugBu7clwyJmEB5ClcPQDXVJXZ+k1JKKL/BA?=
 =?us-ascii?Q?1F0ay7d/bxKEFy8R6LGMWC8DkEbh+syeENxBtJZsrt1TCKHtsjh1lOuqAze7?=
 =?us-ascii?Q?nKt9O3B4yNjFOeMwGvZBDvBLQv+19zsBCueJdCpq4wWlY7OW4NJazjNk2eEL?=
 =?us-ascii?Q?73uD9omBzHQM0htniUtHWsGmN/6Z73j+Qbdqw+GkRy83PGtYj55nvyqlGmI5?=
 =?us-ascii?Q?vifQZAeCWxA/QG23rASC7OaLx95it2FeYajgftxhIciKD5RxQc1l+BboY3W6?=
 =?us-ascii?Q?EkGHsPY2j6cnHymjoeFo6LtczOkkt2ec6Hwd0DUyzkusm9sH1Duq6ZR9gbm8?=
 =?us-ascii?Q?n/9SS5y7MOocvmFmVzBVM3R6ylZCfIhKWnwl/tLkPZXMdpyt8CeppbfnoRbc?=
 =?us-ascii?Q?qbvtwocyCdVe738P9ZkMLgkt2HrvUflupKrG9Flzrm7MiUArx+GX7dpqIrxY?=
 =?us-ascii?Q?oX7fr43zegW/8O534/hmSK1jhp3vOq80ktwdDOMhY4ye27elJaBiTw/+0r/I?=
 =?us-ascii?Q?RwmiK6FK9NX50Zk3MZ4XvQ9Hs71PuUpbQwwXXtpnZPGylh8gtOaTv49CLu1X?=
 =?us-ascii?Q?Zhe+EAAKoS72e5oSrH0dMt8ITFv/HVa7rkspEfcIKzkeu8XrZWZ6rZq26/pR?=
 =?us-ascii?Q?8YdN7bgIXwKfsgoURgLiFcY+8pP4kzJ+iYwmMcwQjxY1uGptPVNSIODwnpPe?=
 =?us-ascii?Q?sdRy06fBjT2nq+/dvEqEwFsWHciAHqj5nX9jZ7LWsNQlcrsC8FIw1HBmJMH7?=
 =?us-ascii?Q?V6JE4Dbk7G45tQ61hQn+etJQIvmyaTKvFfBxtJV50DFn0qyPoxR5OoxEC2k3?=
 =?us-ascii?Q?AMNxIc78aOIqyScQwC4PFJK+k6/ja9WN81KZ2R6gB0WioW7eiS5MOBtbi0rM?=
 =?us-ascii?Q?D3gN0D6fLOQWawj2dqfwGxS8395LfBdhUKMLmiHUiuHXVcnpxUZnZdh3AjSU?=
 =?us-ascii?Q?usOWPUdKzCQ9csnZy24Pojszj3sZqZ/B0wjfsbEgFPtpL5kmO0/j7TAL+JL4?=
 =?us-ascii?Q?PTCDhe5VWIRvSxRe5MyULAhYAwo24uMTKYcVR7+24uaYJvKnen3tUNitoANo?=
 =?us-ascii?Q?rRosf5tSlGy6J5ckLS1/zCjicpPt7p5jbg7YOU8nueNpHbuKv36vgsL47INP?=
 =?us-ascii?Q?DIEauwvTlyNSoX7Ev87+bjP6kt/ISv0Lyki8VlINqX0TqK7qsIqD6k9FUTdy?=
 =?us-ascii?Q?Xw=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 851aa52d-cb8c-440a-5ed7-08dc18b71422
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 06:22:57.7721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6/BaoMYQ9EaBbOylQqCOfY5ckjZ4nKVJEZYrO9tYTErYuhhgwBDgB3dzYJVvAcsF3UZQuo48Cvp3iaipNMnKog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6020

On Fri, 19 Jan, 2024 14:07:14 +0800 Kunwu Chan <chentao@kylinos.cn> wrote:
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.
>
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> ---

Just one comment about the subject for future submissions (this one is
fine). I would just leave the subject as "HID: nvidia-shield: Add some
null pointer checks". We know what file is being edited from the commit
content, so the additional filename detail isn't necessary.

Thanks for the patch. Really appreciate it.

Reviewed-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>