Received-SPF: pass (google.com: domain of linux-kernel+bounces-30816-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <3d5266d5-e5e1-49f9-8fb3-b736dc79e5e6@intel.com>
Date: Fri, 19 Jan 2024 08:29:08 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 3/5] perf: script: add field 'insn_disam' to display
 mnemonic instructions
To: Changbin Du <changbin.du@huawei.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
 Arnaldo Carvalho de Melo <acme@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
 Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
 Ian Rogers <irogers@google.com>, linux-kernel@vger.kernel.org,
 linux-perf-users@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
 Thomas Richter <tmricht@linux.ibm.com>, changbin.du@gmail.com
References: <20240118041224.2799393-1-changbin.du@huawei.com>
 <20240118041224.2799393-4-changbin.du@huawei.com>
 <5766b575-e2db-4a56-9808-31a64bc72402@intel.com>
 <20240119035735.y427wcmsm7dow6h4@M910t>
Content-Language: en-US
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <20240119035735.y427wcmsm7dow6h4@M910t>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 19/01/24 05:57, Changbin Du wrote:
> On Thu, Jan 18, 2024 at 09:49:41PM +0200, Adrian Hunter wrote:
>> On 18/01/24 06:12, Changbin Du wrote:
>>> In addition to the 'insn' field, this adds a new field 'insn_disam' to
>>> display mnemonic instructions instead of the raw code.
>>
>> 'disam' seems an unusual abbreviation, and the 'insn' part seems a bit
>> redundant.  Could this be just 'disasm' instead of 'insn_disam'?
> 
> Personally, I'd preserve the insn_ prefix. So we have two related fields 'insn'
> and 'insn_disasm'.
> 

'ip', 'sym' 'dso' are all related but do not have a common prefix.  Also
most of the field names lean towards abbreviation.