Received-SPF: pass (google.com: domain of linux-kernel+bounces-30852-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <169d5a71-8204-4773-a13c-940b4190ed37@amperemail.onmicrosoft.com>
Date: Fri, 19 Jan 2024 15:42:08 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] NUMA: Early use of cpu_to_node() returns 0 instead of the
 correct node id
To: Yury Norov <yury.norov@gmail.com>,
 Huang Shijie <shijie@os.amperecomputing.com>
Cc: gregkh@linuxfoundation.org, patches@amperecomputing.com,
 rafael@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com,
 aou@eecs.berkeley.edu, kuba@kernel.org, vschneid@redhat.com,
 mingo@kernel.org, akpm@linux-foundation.org, vbabka@suse.cz,
 rppt@kernel.org, tglx@linutronix.de, jpoimboe@kernel.org,
 ndesaulniers@google.com, mikelley@microsoft.com, mhiramat@kernel.org,
 arnd@arndb.de, linux-kernel@vger.kernel.org,
 linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
 catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com,
 mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, chenhuacai@kernel.org,
 jiaxun.yang@flygoat.com, linux-mips@vger.kernel.org,
 cl@os.amperecomputing.com
References: <20240119033227.14113-1-shijie@os.amperecomputing.com>
 <Zan9sb0vtSvVvQeA@yury-ThinkPad>
From: Shijie Huang <shijie@amperemail.onmicrosoft.com>
In-Reply-To: <Zan9sb0vtSvVvQeA@yury-ThinkPad>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ajNZVTdxNm0vem5jSGxsSXNqRmlzd05zc1EyWXI4TkJ5UklSMDJFem9MN1FR?=
 =?utf-8?B?dysrK29PbCtCdkpwVWpIN3N6TzROSWFKRHQ3NC9OY3pwaTVKaXdNemJ6N2Va?=
 =?utf-8?B?QmdyUTlVU0tlZ1FjV2JNUk40ajY4NnVZRDYwdVhZdWJPRnRjZDduempPQTQ0?=
 =?utf-8?B?cUh6amlTN1pIL1pmQUlUM0ZhbU4xVWR0QkpiK010dGxxWCtHQU05VFEzSXBN?=
 =?utf-8?B?ZXg0QmZoYTcvNDJJZGprUldHVVRObmwvcWFvSEdGbDE2R256VjkrVTlIa3Ji?=
 =?utf-8?B?dlZzenVScVRCZmREd1BnM1lGMW5oNGdMeVN2aFJJZUpjT0tMWjZGSHh0UDRM?=
 =?utf-8?B?a09nREhXZG8xSEp2VGg1REdUaU9hbmlnU3FteWxTdmM1bjRVc0x3QkNGSlFC?=
 =?utf-8?B?Q1g0aUpVTEFmR0NlbFYrNCtuaS92M2R2cVRXRmhTUml1WFUzQWUyOHVaTnBq?=
 =?utf-8?B?STdzb2grZkp6eFB2dmZsRG5EeS8rcEo1QkxKYU9OU2xRRzN5aVJVTFg4RlR5?=
 =?utf-8?B?STNPRUFMN1FoTnovQWdUMXR1YktYSUtnWk9IaTVtSG5PTlozVlorL3A1VUFQ?=
 =?utf-8?B?UWxwNUYreDBWSHFZOU84MUNVZXZlVjZSdENsbUcxWmRMbWZuN2YrYTlmdlRJ?=
 =?utf-8?B?Q1VzSGliMGF4RUFCdTR5N2pRdFJaaVNXUGRjQWdKM2cxNVEwSEZRenFjTmZZ?=
 =?utf-8?B?VlhwcE1xMUhkOUhYYUFyNTgrR2wyVUdtYW1rREdyUU9nUmFOQVhDQWR2bXEx?=
 =?utf-8?B?N1hyWmg2eGhxVDJFWjJlL3UrdW1DRFp0Ny9JdnRyTHlRSk8ybkN6dHRnODlu?=
 =?utf-8?B?VWtnMnVoaUdnZm1VVjRwVUs5N1g0Wlp4VGxLSzJjenJCODlCazYyaU1NaDJ5?=
 =?utf-8?B?citUVGtHVTVDTnlwbm52cG1xbWp1TW1qTHFVQ1VtdzI1Nnp2OEhvbEhFYkhp?=
 =?utf-8?B?am0wdVB3czcvenUvVUhzY0ZlSXVHd3BOSmxzVVgvZU9YSzV1NGdVR1JIbnMw?=
 =?utf-8?B?U1Bpbll3NXVUV21RaHFZQVFXZXZmZmhqckpvNE5ML0JNd1dMdFlHdG90N1I5?=
 =?utf-8?B?ZEZuTCt0NXpwQmVSVHFEU3RzRjFzVHJJUDlSWjJtRk1NOG5KcGhUbVRBSGZ0?=
 =?utf-8?B?eGNlemtRenpQZ05KZWlLSHhxaHRndkFmVk5qeUVlNnQybUlBc1M1YzZDYzZp?=
 =?utf-8?B?Qll4YXlqVERralIwTlptY01LQ0czc1RnYlgzZU5ENjFrbDhkcWpWQUM3OXFp?=
 =?utf-8?B?aC9aTFRiVzIyMnRiakRHVDBkeXdMZDJ0STY3cnVhRWpkNXpxb2lnVVBjZy85?=
 =?utf-8?B?c092Y00wZjBMOGRvQVBEZDJiVlJDcEVXU3UvM0RobUYvZURlTysyV2tjR1gz?=
 =?utf-8?B?Y0U1cVBEYmR5MjZwR2ZMR2dqWG9QZTgxQWttdTU1NW5kWDM3SUdaRHk5YjFm?=
 =?utf-8?B?a0toSndZWDN4WDJnbGJIZDY5NHgvTGhRTU5WNkU2MEFNUjJpeUlaN3RjRllB?=
 =?utf-8?B?ZndtazlxZFlKdnBSRm9wdE1zUXpXQzM1T01LNVAvYlpGYWRvN0xiN0g2V3Rq?=
 =?utf-8?B?RldGWFltaUUrRWVXWnZNbHYvNFZ4MGhjdHdsNXBPblozQm1lcFUyQlFETUs5?=
 =?utf-8?B?a3pnYkdWdDNmeHJ5M0dUcWhwOEdNZFgxUHJlK052Z1lFNERyS2I1dDI5MENp?=
 =?utf-8?B?c0hldEZRMDkwUmMwVFErQjFsT0U1emplQW1Od1FMcEloSkdyRkJDN01vUTlp?=
 =?utf-8?B?dlhpaGx3R0o2RTI1U3YzMWg2VTJIeTVOTnpnNjFPRTBOTHBrWGpPUjV3WUl3?=
 =?utf-8?B?Y3IxYXM2MU04WG5vR2dhRW9rMitOV2tDK2crcmxueVR4ckpqTmtXQkdHN0Z6?=
 =?utf-8?B?L0ZmaDUyMUtBK0Z0a1Q1NlBpVzVBOGVaR09uQ3pMeUxOcENHRFNSYUd5VTBR?=
 =?utf-8?B?dnljamRDQlZ4dGtlUXBwUzF3YU96bGdOTG4xeTJMcXVWOXUrMVdVUDhiaGts?=
 =?utf-8?B?UkNsVUI4dHhMTVVSZnR4UDNxblpNNmx5b0tvWW9SYXFkN3ExeDNyRkNHZFFl?=
 =?utf-8?B?M29IVEY1TFNERGg1WU84enNSaGExalNIaDQ5UDNoQzFjeGpYMGVkcHVGeGhv?=
 =?utf-8?B?cVcvUU41NDNOdUdNemVYZU5wWWhsZng3akhtT3pXNG5mRnNHalBKU2l3NzJB?=
 =?utf-8?Q?dTuuqPmPyomlscToe6LyG+Y=3D?=
X-OriginatorOrg: amperemail.onmicrosoft.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 27a735ca-7a17-4bc7-d81b-08dc18c22cab
X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7975.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 07:42:23.4271
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SW+9HThxuhcbDjPCS72fZqCeK1VyHkUczY8SL8uzVy0i5XDWvxW4Mv5tj3oBr+FrF2yuEN1vA70MCM5E8ggR8lYs8gvUHGb2dxUDqZlkgq30ZeR1zvMoItMIcJlp+mhu
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR01MB7072


在 2024/1/19 12:42, Yury Norov 写道:
> Regardless, I don't think that the approach is correct. As per your
> description, some initialization functions erroneously call
> cpu_to_node() instead of early_cpu_to_node() which exists specifically
> for that case.

I checked the code again.

The sparc, mips and s390 (which support the NUMA) do not support 
early_cpu_to_node().

So we cannot use early_cpu_to_node() for these functions.


Thanks

Huang Shijie