Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp855921rdb; Fri, 19 Jan 2024 00:26:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IGsw7Bk+VKHwIqnmbMMb9VSRbE05hIru1m2yDQuQYo8Dy7UCrkXpCshFj8dbm/zg+x3Gddz X-Received: by 2002:a17:902:6a88:b0:1d4:4fc6:8d9 with SMTP id n8-20020a1709026a8800b001d44fc608d9mr1865363plk.60.1705652767899; Fri, 19 Jan 2024 00:26:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705652767; cv=pass; d=google.com; s=arc-20160816; b=SG/rOPdMpfWAhSeWsXoTn7Ha4W/Ac8AdChmjxK+BU/iKqHaFgMCGtN0MavmbloiDry KZngZOYVdGjoP835OoiMWHfaDLtaeUCvb6/JeKIuosXyhz6+ZH4CJYmc2EFfsdzpva0n 5ig1TVPfL4un3hfpNuYfRyMucZ2Loa/4KEHwcRe0qURNHP75xf7IkLWXyJ4WJTdDLHyd kEPcvXldrWdx8ozLAOAvpVZ0JgpZXPD/6/Qpbar5/B2KjO4mz7a1kXskDdkI4svBp1rm nS4IhYDShZOLUQPh79g2hufvSCot23qVlgi7XWw4hdcWBKwnIcJlsj0K3fHJOuydNhX2 n3wA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=t7dcjTRyl1/vUofqEvBgKl6cVF0fqOtVtv29zRSnRI4=; fh=fCcIGXTXyMbauu6QJOfxxPlsAt/ywYNYloTgBYVkoz4=; b=E9DSGQ8ohvwhzcjJUPGDPTaqnGohfwfvz5Qs37TN1NSjNA0umDg6ufFTZ1KdqsnoFo PDAbK7lSjlP51ezqP82m+ifl/BR4g9Yxoj6sGtHcD4YIlbr3tigI9HCcddPdK+mkuMVB 9jxMMUp/Psp/ulDIHX33TSQUjvii/ijzBZjVWvcsqqFQF/1grvue+luqh0n7jE2glkb6 BwItBlOD9XnNL5OfALDpNOZrOMoO51YAzjOuySNpojMETVGOh9HbQy7hGfVp+1PHyfmI VD5X0EG/mgFIOOlJRbrTBwbziKUpntedEo3Q/eLgCq1LERA1n2qcL0d9x/HA5bdnpMyD K2hA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hInY594r; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-30901-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30901-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id w2-20020a170902e88200b001d6f3a8accfsi3064315plg.112.2024.01.19.00.26.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 00:26:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30901-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hInY594r; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-30901-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30901-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4E4F928A429 for ; Fri, 19 Jan 2024 08:26:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9F8F88F6E; Fri, 19 Jan 2024 08:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hInY594r" Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6991DDF6C for ; Fri, 19 Jan 2024 08:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705652757; cv=none; b=MJfkiVphM+iPnQRTpZnImu/X9Jq436QWPfpvmrLOz5XZBpD31DhpI6dH2vKdMd7Yfcig8KjT7nhqYoCSpD+3wJIfSKgpymdpc9c6outZ9ABAJL3VewcRMDKXDvOajJnkNc0uzydWOux9yrSeP4Jd3X3ljP1Gn0KmbVz62XLdhck= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705652757; c=relaxed/simple; bh=CUucUSh0q5PVDhwQRi6YBW3ImttHp3BqkC0YGaXZl2o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CpQmcXOobawtF/Ylu0PPMVVi+LbPgaeTOf1gme/SNNqa8wyYjy4cikD0222p6C/KatBA+kPbon2cGD7+SzEwOOl7s+CWAJ4E9H04NShrPJWEugCI/4OfnHVhyMM+C1gS3PZZ6P+bx+AN2u7gr+1rW3ZTtErj2DtPukwlhURI7Ag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hInY594r; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-337bcaef29eso370378f8f.0 for ; Fri, 19 Jan 2024 00:25:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1705652755; x=1706257555; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=t7dcjTRyl1/vUofqEvBgKl6cVF0fqOtVtv29zRSnRI4=; b=hInY594rTwpMOrimclUL2REqjZPnq75WS2MSrCd3Ad7i+de0Ltxul4bjv66f6NFjku vkD5S4Xm6SiZhnOW8P040SpkqpmKhqRwKnJR17e8ur+HYTIDDiPQyd5MvtxVRyvFF4VY fwC6/xt4CwBZMWAHW2Snbz5wtIzMpuwx6VYj3kIJBftJi1NaNIWDvBrbkLbU8J+JqZZb ZtjtbcDd5ipIgaYZajPCfRlZJgFMXgfoKtazk5lTJBaAqz23FEmNnIX44Hs+jAJ4tDwg 6hh+QQ89fP28ZWLa3X3qcQkLqyvjU0+YTP6nTNCyYrf3g6QSSZEdJsHHkK8FdrRZKnrW dktA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705652755; x=1706257555; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=t7dcjTRyl1/vUofqEvBgKl6cVF0fqOtVtv29zRSnRI4=; b=SmwTEFOi4u+1YrNthn4yVbWlqISxClgkHwWrH5RbaCxoXF6UEKHrr3qk1TxuX1LvbK Y/1z3m3gjLyXQmwMFlrM+YZZ3pn3uh+N3Vs3JIzEN344ZxSRtjQW/cXoPuA3yMJxvVGv iR0B+HDDnx5fi7nkxTnjJP3IeLFcqP0VpJXxmAjxen2kX6dGgxLkZ1oLZFMjNPANh/wN 0Hf2KcncCwLbl/gCQ/lCWp8+AmRL/xoaDsaax2XpJ4nDg2vr3PUufDxD3oz4tOkzR9Wg s/eMh0jujdIABrdDpiCIYttrJUXLNgS34qAo2A3aGVHJe+Z4sGndhRF4vjp5kzU5/HGL xACA== X-Gm-Message-State: AOJu0YzY2w6DimnUBK6gtElQDoG98KsLoq7gN7s213FWSKjMlx9Serht iLqWTAWruv6xqwEVUU5CbdjIvP1IQx66vHVpC0yLOnFisT/EVsk7iVVT1b/7i+4= X-Received: by 2002:a5d:5512:0:b0:336:b8d:6531 with SMTP id b18-20020a5d5512000000b003360b8d6531mr1317167wrv.100.1705652754752; Fri, 19 Jan 2024 00:25:54 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id t26-20020adfa2da000000b00337c0cacf54sm5942518wra.101.2024.01.19.00.25.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 00:25:54 -0800 (PST) Date: Fri, 19 Jan 2024 11:25:51 +0300 From: Dan Carpenter To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Manivannan Sadhasivam , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] PCI: dwc: Fix a 64bit bug in dw_pcie_ep_raise_msix_irq() Message-ID: <501533ad-7671-46aa-a034-91e0a6322e6c@moroto.mountain> References: <3f9f779c-a32f-4925-9ff9-a706861d3357@moroto.mountain> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 17, 2024 at 09:21:41PM +0000, Niklas Cassel wrote: > Hello Dan, > > On Wed, Jan 17, 2024 at 09:32:08PM +0300, Dan Carpenter wrote: > > The "msg_addr" variable is u64. However, the "tbl_offset" is an unsigned > > Here you write tbl_offset. > > > int. This means that when the code does > > > > msg_addr &= ~aligned_offset; > > > > it will unintentionally zero out the high 32 bits. Declare "tbl_offset" > > Here you also write tbl_offset. > That's so weird... I can't imagine how that happened. Do you think it could be a Welsh mice situation where forest creatures are changing my work when I'm away from my desk? https://www.youtube.com/shorts/h8gkIbtaaek Fixed in v2. Thanks! regards, dan carpenter