Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp859419rdb; Fri, 19 Jan 2024 00:35:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHERxrzD6PT4AdosU7pQ74wHc0Kduk9qVhfEtefNH7Ibrj1QLJFG1h7oe+jiw+b2VyiIZDr X-Received: by 2002:a17:907:802:b0:a24:8deb:3524 with SMTP id wv2-20020a170907080200b00a248deb3524mr1353662ejb.54.1705653312201; Fri, 19 Jan 2024 00:35:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705653312; cv=pass; d=google.com; s=arc-20160816; b=RmEPfR2QXX5cpJMdF9LbLdDLHspLlwmwINtByhuSAONjehARXf0K+PWV0g9yYbafW1 nMPGl8ECNS+p8pUqRkwoPpb9+mypxZuT25BfOOGHdk2mg25RfvHA3JQ0AmomTEZj6jvr a3yO5PcDTATVyV3Nj/Kx/j0uEsBRDcFu0ckfGfjck9+GWoyiTonfef3VZKp2pdFdYk+R v5Q49Ev34ON79yilK4VYS5t4/FTlzFnCsL7uCzFkCjd44JAsViP7awMWskOevmDQfOSu IAH8Fw7As+n7gmdjMAnK56YurQKHz37u45DdPWRjMDaUmiNtN33sqrZI0lYPHqeNDOWy En9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=SazaNZvt6lGiurJ58Mpk9uqodPXR3M0NpSG4gQw9/io=; fh=/3Ys4eMDkw7nWzgIDSMrnGT0dRpNwEkcsV36joxLKqw=; b=f6BwTnjAEd+VWlLjaBoxT0l2XT+keCUPXV94b1c/JF/HHqL6gKR2+YXcYtTfXWCVSV 9IV/H9fSIWGI+QT6mOsJYWrDIuLxKS77kTOqwVptth1raqruyUZpAjMzWfMIVRznfuwa tSDNOlvcpmEL3IjKrZ0pHU26KbYFcMjSLtz6GzuutItpyosIrcMgO/NWMJPboqNDAXHA n0hc0zqR/B8oEzAFrSQkuJuknILtwkYG66x8ROpW21Tb4KV1itDwLt+s8VlJePf1Nqfi K/LQMUYIwElUAK+IuiIoxTOVgC+Q7QstI1ISE+WAHpHtppzGbj13wymY9ZsCJ7f0aKTn B3xw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WOjv2CZ4; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-30908-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30908-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id w27-20020a17090633db00b00a2c20f61601si7482136eja.1047.2024.01.19.00.35.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 00:35:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-30908-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=WOjv2CZ4; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-30908-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-30908-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E27271F230D5 for ; Fri, 19 Jan 2024 08:35:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C04511DDC3; Fri, 19 Jan 2024 08:35:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WOjv2CZ4" Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 971CFDDD9 for ; Fri, 19 Jan 2024 08:35:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705653303; cv=none; b=HS5uwuuS/n1CmLxVg6cxSwTQUIsAe4wC57rkIlCQCCoy+w4XsWIOnskfY5KRFpi3ZY5fsIaQwntRXZXFjeKbgvu2/vZp+nAKbfhP07CuaTjjQULZ5N8dZ2zqtGXVW5CbUFrnasxYWCnAtev8fePswaz9e9bkOIz/8947+sCYaFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705653303; c=relaxed/simple; bh=h5PiG7Y3C3wtVijqXyMQ5ULW5o06mfqMjUtDXYxPOz0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=fB5tFYNQPzQlUyJYjPHXWqt1JigPIfFBqAJpYgO16gXHAKloXNCsAAqGx2gkWBtE5rTh1kB2Ma6Bi4+KehyPP+mG3MyTZI7DPnu/1jrddUlp2H21aeEY/kQ3acX45M0JMSrxNH43xneBkLyP/Y43hbefkudHhwVQfT/TQ+IYHlc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=WOjv2CZ4; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2cdb50d8982so5894041fa.2 for ; Fri, 19 Jan 2024 00:35:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1705653299; x=1706258099; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SazaNZvt6lGiurJ58Mpk9uqodPXR3M0NpSG4gQw9/io=; b=WOjv2CZ4Opea+xlx64Ag1YPS2Z7KQnPTE97QDYPtAdYFJgHPBCSL3xdT4AEctaw3Ic DUiw70stlPxQ5dpZj5tSCRkSdQoyt9N9zWYE57F1kLasjosPa+QuS6kquEbV829cAcMH PRlhslx8H8ug3mGZCrNFs0ug19v3dYzBzaJ+M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705653299; x=1706258099; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SazaNZvt6lGiurJ58Mpk9uqodPXR3M0NpSG4gQw9/io=; b=UE1xRUYKX54kUMeIkLy0KWw11NcqMpm5fvH3szyO0fhP1Cmox+jwOv67OHGpWihB1t uv1YPFEvJCIoXFEiNONq0MLF8VYzDCft44Sltsyc7HDc6IF3sHffwJSmTa6Pxx0gZiY+ FHTcCdFRIxhn8iedXJKVNdZ6Irjd4xvujh2MD3xdR9+HdEAAWtLNP/tCS87ydCK0SYqF /+zvPdIZhHr/LdH/jIONg40T9P+sjhuc+hDK03RAD0iknouIXpRQigEI3BBDM2mr7gZH Re/Vvggl6kM4+hy+n/0BKJWsSP6ivzWDil6WQkNF8O3H6TSS20SC1XjbReAsy7/x4Vtt Ledw== X-Gm-Message-State: AOJu0Yz2UUw8yGwNA1l6YFfKtMpc4KUvTJSnEbU/1t7CcfuVn9uMV6eS N4JCay5eqiziIdmDmDQjPpj4C4WaTcHjo+FCXxEj0B1kiyOMJgrEQ8xE394p/WDhTC4CIgwtkcA 8ZQu9xmLaJXJA9dwjgx7LoSrsYQed5bx8ukCH X-Received: by 2002:a05:651c:1a11:b0:2cc:fd12:40ea with SMTP id by17-20020a05651c1a1100b002ccfd1240eamr1651789ljb.42.1705653299491; Fri, 19 Jan 2024 00:34:59 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240118195325.2964918-1-lma@chromium.org> <20240118195325.2964918-2-lma@chromium.org> In-Reply-To: From: =?UTF-8?Q?=C5=81ukasz_Majczak?= Date: Fri, 19 Jan 2024 09:34:48 +0100 Message-ID: Subject: Re: [PATCH v2 1/3] platform/chrome: Update binary interface for EC-based watchdog To: Tzung-Bi Shih Cc: Gwendal Grignou , Radoslaw Biernacki , Wim Van Sebroeck , Lee Jones , Benson Leung , Guenter Roeck , Krzysztof Kozlowski , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 19, 2024 at 4:41=E2=80=AFAM Tzung-Bi Shih = wrote: > > On Thu, Jan 18, 2024 at 07:53:22PM +0000, Lukasz Majczak wrote: > > +#define EC_HANG_DETECT_MIN_TIMEOUT 5 > > +#define EC_HANG_DETECT_MAX_TIMEOUT 65535 > > EC_HANG_DETECT_MAX_TIMEOUT isn't in the latest ec_commands.h [1]. Could = you > either add EC_HANG_DETECT_MAX_TIMEOUT to ec_commands.h or drop the macro = here? > > [1] https://crrev.com/5a76e67210b15fcf67d8a6f90439993598949ae4/include/ec= _commands.h#4749 Yes, I will update ec_commands.h on the EC-side to match above definitions although it doesn't influence any logic on the EC side. Best regards Lukasz