Received-SPF: pass (google.com: domain of linux-kernel+bounces-30941-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <7e3e3c7a-26ae-48ff-8884-d4f703995546@collabora.com>
Date: Fri, 19 Jan 2024 10:13:32 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/2] dt-bindings: usb: mt6360-tcpc: Rename IRQ to PD-IRQB
Content-Language: en-US
To: Rob Herring <robh@kernel.org>
Cc: chunfeng.yun@mediatek.com, gregkh@linuxfoundation.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 matthias.bgg@gmail.com, linux@roeck-us.net, heikki.krogerus@linux.intel.com,
 cy_huang@richtek.com, linux-usb@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 kernel@collabora.com
References: <20240112094538.65639-1-angelogioacchino.delregno@collabora.com>
 <20240112142018.GA3127117-robh@kernel.org>
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20240112142018.GA3127117-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Il 12/01/24 15:20, Rob Herring ha scritto:
> On Fri, Jan 12, 2024 at 10:45:37AM +0100, AngeloGioacchino Del Regno wrote:
>> Since there is no user yet, rename the only interrupt of this device
>> to "PD-IRQB", avoiding underscores.
> 
> It is primarily node and property names that have this recommendation,
> not so much -names values.
> 
> If there is only 1 interrupt, I'd just drop the name.
> 

Yeah, you're totally right. I'll just drop it.

Thanks!
Angelo

>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> ---
>>   .../devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml         | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
>> index 053264e60583..0bea23ce2f09 100644
>> --- a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
>> +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
>> @@ -24,7 +24,7 @@ properties:
>>   
>>     interrupt-names:
>>       items:
>> -      - const: PD_IRQB
>> +      - const: PD-IRQB
>>   
>>     connector:
>>       type: object
>> @@ -58,7 +58,7 @@ examples:
>>           tcpc {
>>             compatible = "mediatek,mt6360-tcpc";
>>             interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
>> -          interrupt-names = "PD_IRQB";
>> +          interrupt-names = "PD-IRQB";
>>   
>>             connector {
>>               compatible = "usb-c-connector";
>> -- 
>> 2.43.0
>>