Received-SPF: pass (google.com: domain of linux-kernel+bounces-30943-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Paller, Kim Seer" <KimSeer.Paller@analog.com>
To: Conor Dooley <conor.dooley@microchip.com>,
        =?iso-8859-1?Q?Nuno_S=E1?=
	<noname.nuno@gmail.com>
CC: Conor Dooley <conor@kernel.org>,
        "linux-iio@vger.kernel.org"
	<linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        "Hennerich, Michael"
	<Michael.Hennerich@analog.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>, Crt Mori <cmo@melexis.com>,
        Linus Walleij
	<linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>
Subject: RE: [PATCH v6 1/2] dt-bindings: iio: frequency: add admfm2000
Thread-Topic: [PATCH v6 1/2] dt-bindings: iio: frequency: add admfm2000
Thread-Index: AQHaSeyhcow0swT57keZetZEWhgOabDfvaqAgACHJ3CAAIftgIAAAzMAgAALT+A=
Date: Fri, 19 Jan 2024 09:16:44 +0000
Message-ID: 
 <PH0PR03MB7141990D32CE5544397384F9F9702@PH0PR03MB7141.namprd03.prod.outlook.com>
References: <20240118085856.70758-1-kimseer.paller@analog.com>
 <20240118085856.70758-2-kimseer.paller@analog.com>
 <20240118-steadily-coauthor-de8275118901@spud>
 <PH0PR03MB71410860593D3C7253B200FCF9702@PH0PR03MB7141.namprd03.prod.outlook.com>
 <0f32caa9a11305333f1f18b97c97d775f4a5bb9a.camel@gmail.com>
 <20240119-squad-unflawed-934627f0e394@wendy>
In-Reply-To: <20240119-squad-unflawed-934627f0e394@wendy>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?lVoAwVNNgKFB0QN94z9gziO3YmZdD6qIP7fvv0jZoLP5qAye8X+Prnfmhn?=
 =?iso-8859-1?Q?PHS9LkvCPm0cWzeOG5nHSigNaAu3+CjYRELCrWFPJgRG+fxb94FECePd7p?=
 =?iso-8859-1?Q?EPXRrKTr3AiZ9vawxDb40+kK3W9jP/NJdqFxJClFrNR5vE3XTE0Ap+q9OQ?=
 =?iso-8859-1?Q?LbHMy8be1sYV47OTTlaoc0BLS9RYAJGTGKu1mZyetHjAgCAg2bH6CMcad4?=
 =?iso-8859-1?Q?lUxI1Nbrqckd9l4rKH3LCRSqBJ58ndXEHpwrPEIfMNZnZnDv0ppFhyH6Gs?=
 =?iso-8859-1?Q?uZkrlAQ7xJt8h7JHR5i4YoyD43TPR4KeOhUXc0NjSvSIvqdKB5sEym3jzH?=
 =?iso-8859-1?Q?tYnvSRve8d6TS5jHaeiGy/TvoatBYXVuBEavxaYzqT3AEbgUFKqZ+cEfI0?=
 =?iso-8859-1?Q?0fSbh7TgyQHTgx4iIn5Do714BhOD3OZkwZV/ZOlNragKG41XMmPIFWFi7S?=
 =?iso-8859-1?Q?ccrfYB1RAv5vCI4DBXNwbUCfeaUTCh6ycW0/FVk9F/oNxrG5yHZ+w1Prbc?=
 =?iso-8859-1?Q?9SGmUkBVtJoHGaXXycvhrEdSSaA2yKqSZfG6xlipuy341VUFWLKZAxnVda?=
 =?iso-8859-1?Q?TLrgAeVSMfTH66Y/K7P7iG68hJqB+1m885ekhJzqYZvsaJGT7wgZJgleg7?=
 =?iso-8859-1?Q?qgwsS9JAdu7965q3T3flWArl7xtrls8Fu0HNM3qFsP1yYc7zHWqAEWiO1j?=
 =?iso-8859-1?Q?2SB/MK+cpvxswp4I8XBodE87l0Q71/K+EMYvSx+q4zw7M12drWW0Ou+7V7?=
 =?iso-8859-1?Q?+7wz40H4fgtn90E9y5kQQ7P7M4Ozx/X/vW7ZNzEkIZWbdZJYg7CJtpNXnX?=
 =?iso-8859-1?Q?LcJeAIZpUfF2DTacYXxJsZNR3TB/N/r2BLD1RviS/gXLVBF1v3kH9n2JB6?=
 =?iso-8859-1?Q?npyYPRtG8fj8i8CLN2j3IpoYUFBHTRMht5a13Dy7uwfOCNDCyPVwo1eXmn?=
 =?iso-8859-1?Q?qU+SPMEZm16YFcOyzg36PVHKxORHA5OUfhiku1d3WAEnRiN7hhV4A5iZSK?=
 =?iso-8859-1?Q?P0Y5wX6i7arSlra7//KCb/+Agvr1ah+3vCyR6KnwrPW9PtCOs+LnKu1AkE?=
 =?iso-8859-1?Q?u+j2MXCxx1wgQwAnjSlaCnrhs7+UGtRDdZLwKMMUfoFxb9euTxnwbzLmPh?=
 =?iso-8859-1?Q?aQebK/ZwnYuOv+Xfhl0kXEXmVA4bmQVky95VAQNS+/c7xXAWV1V/+/DFzs?=
 =?iso-8859-1?Q?5smEEqguJYWgb+n+4SGF2agS+GHTE/qg0UiG+XU/jvgs0j5r1JId0x467j?=
 =?iso-8859-1?Q?AGdPEg/UdseBhkCTO558hEyXKfQnnCw3k7eqXkvUGo4XbAKDM8/klNqCEp?=
 =?iso-8859-1?Q?+7OlxbAGk0zWaCkhUisUfxZC1kzx+OGmXGNfU4Fhw9sZtRZG92JZFWq0KH?=
 =?iso-8859-1?Q?/Ux5KLGOmdgQF2VtAdmZnryb/dCYPagAYXgSAfECStI5bgn94GYxORjG+j?=
 =?iso-8859-1?Q?1I2aG3uHMc1fxjid/VgFppHBvy+7IiKfV3EQpI0N0zWH8ZrkB7qKwyrbyD?=
 =?iso-8859-1?Q?Ux5hMGvPWKeZl5bQhGJFkN0UymUy7bRQG/t6k1BK3vs7fBzCT0HPkp0jBr?=
 =?iso-8859-1?Q?F57/+psv6ld/rx5N892siISzGnoOv934ejaa3HC7rFE0GSUqpfY/ciNKRq?=
 =?iso-8859-1?Q?RIZvr9HE2Xr+hvv6NPFDRMf+X+6trdF92mqKxleomjeUdrKHefD7fD+A?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB7141.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e3710f0-bb02-48c0-8481-08dc18cf5b57
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2024 09:16:44.9315
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Uc4R2yqv1ilrVjFPVGgpPzI15ODnx1hbb9CKUDD+N1+ghPs4j/c/Y5OT858E7iZP2FRqSZFcpVnNXw8iesrjyVqDPut75rFeo9WSsdYGmDU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6635
X-Proofpoint-GUID: T7jP5F8A-v0L9jM4Avjq_iklX5ZUz5Es
X-Proofpoint-ORIG-GUID: T7jP5F8A-v0L9jM4Avjq_iklX5ZUz5Es
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-19_04,2024-01-19_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0
 clxscore=1011 priorityscore=1501 mlxlogscore=999 spamscore=0 adultscore=0
 lowpriorityscore=0 suspectscore=0 impostorscore=0 malwarescore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2311290000 definitions=main-2401190038

> > > > > +patternProperties:
> > > > > +=A0 "^channel@[0-1]$":
> > > > > +=A0=A0=A0 type: object
> > > > > +=A0=A0=A0 description: Represents a channel of the device.
> > > > > +
> > > > > +=A0=A0=A0 additionalProperties: false
> > > > > +
> > > > > +=A0=A0=A0 properties:
> > > > > +=A0=A0=A0=A0=A0 reg:
> > > > > +=A0=A0=A0=A0=A0=A0=A0 description:
> > > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0 The channel number.
> > > > > +=A0=A0=A0=A0=A0=A0=A0 minimum: 0
> > > > > +=A0=A0=A0=A0=A0=A0=A0 maximum: 1
> > > > > +
> > > > > +=A0=A0=A0=A0=A0 adi,mode:
> > > > > +=A0=A0=A0=A0=A0=A0=A0 description:
> > > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0 RF path selected for the channel.
> > > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 0 - Direct IF mode
> > > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 1 - Mixer mode
> > > > > +=A0=A0=A0=A0=A0=A0=A0 $ref: /schemas/types.yaml#/definitions/uin=
t32
> > > > > +=A0=A0=A0=A0=A0=A0=A0 enum: [0, 1]
> > > >
> > > > How come this is an enum, rather than a boolean property such as
> > > > "adi,mixer-mode"?
> > >
> > > I used an enum, perhaps because it was easier to implement. However,
> > > this could be changed if a boolean property might be more suitable in=
 this
> case.
> > > Is that the preferred option?
> > >
> >
> > Hmmm, How is the enum easier than a boolean property :)? I guess the
> > device has a default mode. So, if it is Direct IF mode you have
> > 'adi,mixer-mode' to enable that mode and that's it. So the code is pret=
ty
> much just:
> >
> > if (device_property_read_bool()) {
>=20
> device_property_present() is preferred I think.
>=20
> > 	/* enable mixer mode */
> > }
> >
> > Also remember that from a bindings point of view being easier to
> > implement or not in the driver does not matter much. Take for an
> > example, properties with well know units like 'microamp'. It would be
> > much easier to just have an enum with the device register values but
> > that's not how we should do it since it wouldn't be intuitive at all fo=
r people
> reading devicetrees.

Hi Conor, Nuno,

Thanks for the input, I'll take note of that.

Best,
Kim