Received-SPF: pass (google.com: domain of linux-kernel+bounces-31010-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 19 Jan 2024 10:16:46 +0000
From: Conor Dooley <conor.dooley@microchip.com>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
CC: Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring
	<robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Emil
 Renner Berthing <kernel@esmil.dk>, Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Jack
 Zhu <jack.zhu@starfivetech.com>, <linux-media@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] dt-bindings: media: starfive: Match driver and
 yaml property names
Message-ID: <20240119-despair-festival-59ab2d4d896b@wendy>
References: <20240119100639.84029-1-changhuang.liang@starfivetech.com>
 <20240119100639.84029-2-changhuang.liang@starfivetech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="BFH1MedVdG7X979+"
Content-Disposition: inline
In-Reply-To: <20240119100639.84029-2-changhuang.liang@starfivetech.com>

--BFH1MedVdG7X979+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 19, 2024 at 02:06:38AM -0800, Changhuang Liang wrote:
> Drop some unused properties for clocks, resets and interrupts for
> StarFive JH7110 camera subsystem.

What do you mean "unused"?

Do these clocks etc exist but are not used by the driver?

Or do they not exist at all?

The two are very different!

Thanks,
Conor.

>=20
> Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
> Reviewed-by: Jack Zhu <jack.zhu@starfivetech.com>
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
>  .../bindings/media/starfive,jh7110-camss.yaml | 31 +++++--------------
>  1 file changed, 8 insertions(+), 23 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/media/starfive,jh7110-cams=
s.yaml b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> index c66586d90fa2..2504381058b3 100644
> --- a/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/starfive,jh7110-camss.yaml
> @@ -4,14 +4,14 @@
>  $id: http://devicetree.org/schemas/media/starfive,jh7110-camss.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
> =20
> -title: Starfive SoC CAMSS ISP
> +title: StarFive SoC CAMSS ISP
> =20
>  maintainers:
>    - Jack Zhu <jack.zhu@starfivetech.com>
>    - Changhuang Liang <changhuang.liang@starfivetech.com>
> =20
>  description:
> -  The Starfive CAMSS ISP is a Camera interface for Starfive JH7110 SoC. =
It
> +  The StarFive CAMSS ISP is a Camera interface for StarFive JH7110 SoC. =
It
>    consists of a VIN controller (Video In Controller, a top-level control=
 unit)
>    and an ISP.
> =20
> @@ -28,26 +28,21 @@ properties:
>        - const: isp
> =20
>    clocks:
> -    maxItems: 7
> +    maxItems: 3
> =20
>    clock-names:
>      items:
> -      - const: apb_func
>        - const: wrapper_clk_c
> -      - const: dvp_inv
> -      - const: axiwr
> -      - const: mipi_rx0_pxl
>        - const: ispcore_2x
>        - const: isp_axi
> =20
>    resets:
> -    maxItems: 6
> +    maxItems: 5
> =20
>    reset-names:
>      items:
>        - const: wrapper_p
>        - const: wrapper_c
> -      - const: axird
>        - const: axiwr
>        - const: isp_top_n
>        - const: isp_top_axi
> @@ -57,7 +52,7 @@ properties:
>        - description: JH7110 ISP Power Domain Switch Controller.
> =20
>    interrupts:
> -    maxItems: 4
> +    maxItems: 3
> =20
>    ports:
>      $ref: /schemas/graph.yaml#/properties/ports
> @@ -125,34 +120,24 @@ examples:
>          reg =3D <0x19840000 0x10000>,
>                <0x19870000 0x30000>;
>          reg-names =3D "syscon", "isp";
> -        clocks =3D <&ispcrg 0>,
> -                 <&ispcrg 13>,
> -                 <&ispcrg 2>,
> -                 <&ispcrg 12>,
> -                 <&ispcrg 1>,
> +        clocks =3D <&ispcrg 13>,
>                   <&syscrg 51>,
>                   <&syscrg 52>;
> -        clock-names =3D "apb_func",
> -                      "wrapper_clk_c",
> -                      "dvp_inv",
> -                      "axiwr",
> -                      "mipi_rx0_pxl",
> +        clock-names =3D "wrapper_clk_c",
>                        "ispcore_2x",
>                        "isp_axi";
>          resets =3D <&ispcrg 0>,
>                   <&ispcrg 1>,
> -                 <&ispcrg 10>,
>                   <&ispcrg 11>,
>                   <&syscrg 41>,
>                   <&syscrg 42>;
>          reset-names =3D "wrapper_p",
>                        "wrapper_c",
> -                      "axird",
>                        "axiwr",
>                        "isp_top_n",
>                        "isp_top_axi";
>          power-domains =3D <&pwrc 5>;
> -        interrupts =3D <92>, <87>, <88>, <90>;
> +        interrupts =3D <92>, <87>, <90>;
> =20
>          ports {
>              #address-cells =3D <1>;
> --=20
> 2.25.1
>=20
>=20
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

--BFH1MedVdG7X979+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZapMDgAKCRB4tDGHoIJi
0lzdAP0XhGNQY1wQcLpLFfEc/Sj9meIVrA/jD1GxiMXgdQqWnQD/QUG80+qLfwIm
6Glfk4ikQIoSAIG9e230u0TETuQEkQg=
=ngD+
-----END PGP SIGNATURE-----

--BFH1MedVdG7X979+--