Received-SPF: pass (google.com: domain of linux-kernel+bounces-31009-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <d2cf0179-03d4-4766-b93e-f29e284e1048@quicinc.com>
Date: Fri, 19 Jan 2024 15:42:12 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 4/5] iommu/arm-smmu: add ACTLR data and support for
 SM8550
Content-Language: en-US
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <will@kernel.org>,
        <robin.murphy@arm.com>, <joro@8bytes.org>,
        <dmitry.baryshkov@linaro.org>, <jsnitsel@redhat.com>,
        <quic_bjorande@quicinc.com>, <mani@kernel.org>,
        <quic_eberman@quicinc.com>, <robdclark@chromium.org>,
        <u.kleine-koenig@pengutronix.de>, <robh@kernel.org>,
        <vladimir.oltean@nxp.com>, <quic_pkondeti@quicinc.com>,
        <quic_molvera@quicinc.com>
CC: <linux-arm-msm@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>
References: <20240116150411.23876-1-quic_bibekkum@quicinc.com>
 <20240116150411.23876-5-quic_bibekkum@quicinc.com>
 <7d012b9f-b1ca-4633-8dc2-03d90c418e7d@linaro.org>
From: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
In-Reply-To: <7d012b9f-b1ca-4633-8dc2-03d90c418e7d@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 1/18/2024 11:28 PM, Konrad Dybcio wrote:
> 
> 
> On 1/16/24 16:04, Bibek Kumar Patro wrote:
>> Add ACTLR data table for SM8550 along with support for
>> same including SM8550 specific implementation operations.
>>
>> Signed-off-by: Bibek Kumar Patro <quic_bibekkum@quicinc.com>
>> ---
> 
> [...]
> 
>> +static const struct actlr_variant sm8550_actlr[] = {
>> +    { .io_start = 0x15000000, .actlrcfg = sm8550_apps_actlr_cfg,
>> +            .num_actlrcfg = ARRAY_SIZE(sm8550_apps_actlr_cfg) },
>> +    { .io_start = 0x03da0000, .actlrcfg = sm8550_gfx_actlr_cfg,
>> +            .num_actlrcfg = ARRAY_SIZE(sm8550_gfx_actlr_cfg) },
>> +};
> Just a nit again, but if struct definitions need to be wrapped, this looks
> better:
> 
> {
>      .io_start = 0...,
>      .aclrcfg = ...,
>      .num_actlrcfg = ARR..,
> }, {
>      .io_start = 0..,
>      .aclrcfg = ...,
>      .num_actlrcfg = ARR..,
> };
> 

Noted, will wrap this to keep each member in a new line as shown.
This looks much cleaner. Thanks for this suggestion.

Regards,
Bibek

> Konrad