Date: Fri, 14 Dec 2007 21:49:03 +0100 (CET)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: linux-fbdev-devel@lists.sourceforge.net
cc: Andrew Morton <akpm@linux-foundation.org>, Sam Ravnborg <sam@ravnborg.org>,
       linux-kernel@vger.kernel.org, Antonino Daplas <adaplas@gmail.com>
Subject: Re: [Linux-fbdev-devel] [PATCH] logo: move declarations of logos to
 linux_logo.h
In-Reply-To: <20071213213130.GA1822@joi>
Message-ID: <Pine.LNX.4.64.0712142148390.4881@anakin>
References: <20071209214027.GG9440@joi> <20071213023111.30ddc487.akpm@linux-foundation.org>
 <20071213213130.GA1822@joi>
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="-1463808512-1321829784-1197665343=:4881"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2006
Lines: 50

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

---1463808512-1321829784-1197665343=:4881
Content-Type: TEXT/PLAIN; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Thu, 13 Dec 2007, Marcin Slusarz wrote:
> On Thu, Dec 13, 2007 at 02:31:11AM -0800, Andrew Morton wrote:
> > On Sun, 9 Dec 2007 22:40:31 +0100 Marcin Ślusarz <marcin.slusarz@gmail.com> wrote:
> >
> > > logo: move declarations of logos to linux_logo.h
> > >
> > > there was a mismatch between externs in logo.c and code generated by pnmtologo
> > > (on old tree, you need to rm drivers/video/logo/logo_*.c before compilation)
> >
> > This patch (after I fixed it) keeps on causing trouble: mismatches between
> > the header file declarations and the actual definitions of the lookup
> > tables.  This happens as I apply and unapply the patch.
> >
> > It _shouldn't_ happen, but there would appear to be some missing makefile
> > rules.  I guess the C files aren't being regenerated when
> > scripts/pnmtologo.c has been altered, so the C files aren't matching the
> > header which this patch alters.
> 
> Ok, updated patch below:
> 
> logo: move declarations of logos to linux_logo.h
> 
> there was a mismatch between externs in logo.c and code generated by pnmtologo

This may cause section conflicts, cfr.
http://lkml.org/lkml/2007/10/24/65

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
---1463808512-1321829784-1197665343=:4881--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/