Received-SPF: pass (google.com: domain of linux-kernel+bounces-31233-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
Date: Fri, 19 Jan 2024 06:04:04 -0800
In-Reply-To: <20240119132214.3095-1-n.zhandarovich@fintech.ru>
Message-ID: <000000000000e92c8f060f4cf392@google.com>
Subject: Re: [syzbot] [staging?] [usb?] memory leak in _r8712_init_xmit_priv (2)
From: syzbot <syzbot+83763e624cfec6b462cb@syzkaller.appspotmail.com>
To: linux-kernel@vger.kernel.org, n.zhandarovich@fintech.ru, 
	syzkaller-bugs@googlegroups.com
Content-Type: text/plain; charset="UTF-8"

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
memory leak in corrupted

BUG: memory leak
unreferenced object 0xffff888109b12000 (size 4096):
  comm "kworker/1:1", pid 28, jiffies 4294944675
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace (crc 0):
    [<ffffffff815fa6f3>] kmemleak_alloc_recursive include/linux/kmemleak.h:42 [inline]
    [<ffffffff815fa6f3>] slab_post_alloc_hook mm/slub.c:3817 [inline]
    [<ffffffff815fa6f3>] slab_alloc_node mm/slub.c:3860 [inline]
    [<ffffffff815fa6f3>] kmalloc_trace+0x283/0x330 mm/slub.c:4007
    [<ffffffff83d23552>] kmalloc include/linux/slab.h:590 [inline]
    [<ffffffff83d23552>] _r8712_init_xmit_priv+0x2b2/0x6e0 drivers/staging/rtl8712/rtl871x_xmit.c:130
    [<ffffffff83d1e143>] r8712_init_drv_sw+0xc3/0x290 drivers/staging/rtl8712/os_intfs.c:310
    [<ffffffff83d1ce06>] r871xu_drv_init+0x1c6/0x920 drivers/staging/rtl8712/usb_intf.c:386
    [<ffffffff8330155b>] usb_probe_interface+0x16b/0x3a0 drivers/usb/core/driver.c:399
    [<ffffffff82c6ef96>] call_driver_probe drivers/base/dd.c:579 [inline]
    [<ffffffff82c6ef96>] really_probe+0x126/0x440 drivers/base/dd.c:658
    [<ffffffff82c6f373>] __driver_probe_device+0xc3/0x190 drivers/base/dd.c:800
    [<ffffffff82c6f46a>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:830
    [<ffffffff82c6f664>] __device_attach_driver+0x104/0x160 drivers/base/dd.c:958
    [<ffffffff82c6c3bd>] bus_for_each_drv+0xcd/0x120 drivers/base/bus.c:457
    [<ffffffff82c6fb8a>] __device_attach+0xfa/0x290 drivers/base/dd.c:1030
    [<ffffffff82c6db2a>] bus_probe_device+0xca/0xd0 drivers/base/bus.c:532
    [<ffffffff82c69fde>] device_add+0x9be/0xc90 drivers/base/core.c:3625
    [<ffffffff832fe627>] usb_set_configuration+0x967/0xc70 drivers/usb/core/message.c:2207
    [<ffffffff833110bf>] usb_generic_driver_probe+0x7f/0xd0 drivers/usb/core/generic.c:254
    [<ffffffff83300c49>] usb_probe_device+0x79/0x180 drivers/usb/core/driver.c:294

BUG: memory leak
unreferenced object 0xffff888109b17000 (size 4096):
  comm "kworker/1:1", pid 28, jiffies 4294944675
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace (crc 0):
    [<ffffffff815fa6f3>] kmemleak_alloc_recursive include/linux/kmemleak.h:42 [inline]
    [<ffffffff815fa6f3>] slab_post_alloc_hook mm/slub.c:3817 [inline]
    [<ffffffff815fa6f3>] slab_alloc_node mm/slub.c:3860 [inline]
    [<ffffffff815fa6f3>] kmalloc_trace+0x283/0x330 mm/slub.c:4007
    [<ffffffff83d23552>] kmalloc include/linux/slab.h:590 [inline]
    [<ffffffff83d23552>] _r8712_init_xmit_priv+0x2b2/0x6e0 drivers/staging/rtl8712/rtl871x_xmit.c:130
    [<ffffffff83d1e143>] r8712_init_drv_sw+0xc3/0x290 drivers/staging/rtl8712/os_intfs.c:310
    [<ffffffff83d1ce06>] r871xu_drv_init+0x1c6/0x920 drivers/staging/rtl8712/usb_intf.c:386
    [<ffffffff8330155b>] usb_probe_interface+0x16b/0x3a0 drivers/usb/core/driver.c:399
    [<ffffffff82c6ef96>] call_driver_probe drivers/base/dd.c:579 [inline]
    [<ffffffff82c6ef96>] really_probe+0x126/0x440 drivers/base/dd.c:658
    [<ffffffff82c6f373>] __driver_probe_device+0xc3/0x190 drivers/base/dd.c:800
    [<ffffffff82c6f46a>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:830
    [<ffffffff82c6f664>] __device_attach_driver+0x104/0x160 drivers/base/dd.c:958
    [<ffffffff82c6c3bd>] bus_for_each_drv+0xcd/0x120 drivers/base/bus.c:457
    [<ffffffff82c6fb8a>] __device_attach+0xfa/0x290 drivers/base/dd.c:1030
    [<ffffffff82c6db2a>] bus_probe_device+0xca/0xd0 drivers/base/bus.c:532
    [<ffffffff82c69fde>] device_add+0x9be/0xc90 drivers/base/core.c:3625
    [<ffffffff832fe627>] usb_set_configuration+0x967/0xc70 drivers/usb/core/message.c:2207
    [<ffffffff833110bf>] usb_generic_driver_probe+0x7f/0xd0 drivers/usb/core/generic.c:254
    [<ffffffff83300c49>] usb_probe_device+0x79/0x180 drivers/usb/core/driver.c:294

BUG: memory leak
unreferenced object 0xffff888109b15000 (size 4096):
  comm "kworker/1:1", pid 28, jiffies 4294944675
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace (crc 0):
    [<ffffffff815fa6f3>] kmemleak_alloc_recursive include/linux/kmemleak.h:42 [inline]
    [<ffffffff815fa6f3>] slab_post_alloc_hook mm/slub.c:3817 [inline]
    [<ffffffff815fa6f3>] slab_alloc_node mm/slub.c:3860 [inline]
    [<ffffffff815fa6f3>] kmalloc_trace+0x283/0x330 mm/slub.c:4007
    [<ffffffff83d23552>] kmalloc include/linux/slab.h:590 [inline]
    [<ffffffff83d23552>] _r8712_init_xmit_priv+0x2b2/0x6e0 drivers/staging/rtl8712/rtl871x_xmit.c:130
    [<ffffffff83d1e143>] r8712_init_drv_sw+0xc3/0x290 drivers/staging/rtl8712/os_intfs.c:310
    [<ffffffff83d1ce06>] r871xu_drv_init+0x1c6/0x920 drivers/staging/rtl8712/usb_intf.c:386
    [<ffffffff8330155b>] usb_probe_interface+0x16b/0x3a0 drivers/usb/core/driver.c:399
    [<ffffffff82c6ef96>] call_driver_probe drivers/base/dd.c:579 [inline]
    [<ffffffff82c6ef96>] really_probe+0x126/0x440 drivers/base/dd.c:658
    [<ffffffff82c6f373>] __driver_probe_device+0xc3/0x190 drivers/base/dd.c:800
    [<ffffffff82c6f46a>] driver_probe_device+0x2a/0x120 drivers/base/dd.c:830
    [<ffffffff82c6f664>] __device_attach_driver+0x104/0x160 drivers/base/dd.c:958
    [<ffffffff82c6c3bd>] bus_for_each_drv+0xcd/0x120 drivers/base/bus.c:457
    [<ffffffff82c6fb8a>] __device_attach+0xfa/0x290 drivers/base/dd.c:1030
    [<ffffffff82c6db2a>] bus_probe_device+0xca/0xd0 drivers/base/bus.c:532
    [<ffffffff82c69fde>] device_add+0x9be/0xc90 drivers/base/core.c:3625
    [<ffffffff832fe627>] usb_set_configuration+0x967/0xc70 drivers/usb/core/message.c:2207
    [<ffffffff833110bf>] usb_generic_driver_probe+0x7f/0xd0 drivers/usb/core/generic.c:254
    [<ffffffff83300c49>] usb_probe_device+0x79/0x180 drivers/usb/core/driver.c:294


Tested on:

commit:         9d1694dc Merge tag 'for-6.8/block-2024-01-18' of git:/..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=17b61b63e80000
kernel config:  https://syzkaller.appspot.com/x/.config?x=447c03a4f5a8d571
dashboard link: https://syzkaller.appspot.com/bug?extid=83763e624cfec6b462cb
compiler:       gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40

Note: no patches were applied.