Received-SPF: pass (google.com: domain of linux-kernel+bounces-31240-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240119084328.3135503-1-lma@chromium.org> <d2329494-2c57-41bb-a9ea-2c9903500d1e@roeck-us.net>
In-Reply-To: <d2329494-2c57-41bb-a9ea-2c9903500d1e@roeck-us.net>
From: =?UTF-8?Q?=C5=81ukasz_Majczak?= <lma@chromium.org>
Date: Fri, 19 Jan 2024 15:10:23 +0100
Message-ID: <CAE5UKNrU9YHoCQr8HLFf9-T4-NobQ4jWtryVqq9okFz8nVezgQ@mail.gmail.com>
Subject: Re: [PATCH v3 0/3] Introduce EC-based watchdog
To: Guenter Roeck <linux@roeck-us.net>
Cc: Gwendal Grignou <gwendal@chromium.org>, Tzung-Bi Shih <tzungbi@kernel.org>, 
	Radoslaw Biernacki <biernacki@google.com>, Wim Van Sebroeck <wim@linux-watchdog.org>, 
	Lee Jones <lee@kernel.org>, Benson Leung <bleung@chromium.org>, 
	Guenter Roeck <groeck@chromium.org>, Krzysztof Kozlowski <krzk@kernel.org>, linux-watchdog@vger.kernel.org, 
	linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 19, 2024 at 1:50=E2=80=AFPM Guenter Roeck <linux@roeck-us.net> =
wrote:
>
> On 1/19/24 00:43, Lukasz Majczak wrote:
> > Chromeos devices are equipped with the embedded controller (EC)
> > that can be used as a watchdog. The following patches
> > updates the structures and definitions required to
> > communicate with EC-based watchdog and implements the
> > driver itself.
> >
> > The previous version of this patch was sent here:
> > https://patchwork.kernel.org/project/linux-watchdog/list/?series=3D8179=
25
> >
> > Changelog
> > V2->V3:
> > * drop "-drv" from driver name
> > * use format #define<space>NAME<tab>value
> >
>
> I am a bit lost here. You dropped my Reviewed-by: tags, even though
> I specifically said that they applied with those changes made.
> Also, according to the above patch 1/3 was not changed at all.
>
> What else did you change that warrants dropping the tags ?
>
> Guenter
>
The "-drv" change was related to patch 2 and 3, and I have used
"format #define<space>NAME<tab>value" only in patch 3 (as
ec_commands.h is mixing those)
Sorry for dropping your "Reviewed-by" tag :( I've assumed (wrong) that
I cannot take it for granted sending V3.
Alos in such a case if there are changes in patch 2 and 3 and 1
remains untouched shall I send only 2 and 3 in the next version ?

Best regards,
Lukasz