Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp1072030rdb; Fri, 19 Jan 2024 07:23:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IFBvFI+RBSLvYohOwFOkMEj1peTHN1Q/HFRPsWhu7FNvIghHFRKmANB8CCQB31n6erjqcC9 X-Received: by 2002:ac8:5803:0:b0:42a:2080:7bf6 with SMTP id g3-20020ac85803000000b0042a20807bf6mr2047124qtg.16.1705677792703; Fri, 19 Jan 2024 07:23:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705677792; cv=pass; d=google.com; s=arc-20160816; b=hjRTp6Wk/ws2pcBKNe2Sgy6BNbJxC9cK3L6rHlDGNtSuKfAuP9EMA2ADpfwopJGsd0 /zEDYNAc7d9AKC5MMYE/ZCRJW0s6zsWmdx1GcRBI9/xNSBkXKX+fCjGWenFvgYyG618X uX3qxxCL4TAo0V0x5wMJXeMtKOhWAuNUIe2C58vejNcXhYW87KaRzqifLqlPU+qq8JiF s/1S02mdZd53SrYktRgwb1h8C2YfqVWWbelJtDDKMjeVKjPoD7x1Xcc5FjD4jnGPFt9s d8+qVAjHhSCUfEuWLTMRA3tVT47ig9KQW43/LVqrmF93U3JwH/E5fAQyERHGGrmQZ02D 2lXw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:references:in-reply-to :message-id:cc:to:from:date:dkim-signature; bh=7Myt403LL6AjEMnozelIwrs8mpGxi4XVDTkh5yb/uRI=; fh=tm7IpDqJa7J6ll7TpNqCBHnpeXMlR+9RujLri6fxpkc=; b=CYacP9aHeN0VgYv2NazdLSXB8qGYYuUBeX3Piyr6tAKuh4Kdo+pXewNQ4GgFfpTxSb HX3lT9qZu7syy23Pn3obxGeAnuX9AGEaxbTV66EgObT4SvjCa0cVX25khcTKNgkLgCud HlAxTRUY+BxOKZ44F7s7eQhTq8l5XG36ca4B4uzDUuEOUPd1blI+SS6wRpbBuEMDXWMy XcQbTZzVwJTaFXWiJUVd7KWMO3yJXuIHbvneMLCtGijtSU4zZG/U0iMP2UM80zXTC3O4 1iNsnkH0drcyFiHn6c01GfJuvWZL7OUcdLnjWLDhXGjlwPBZLWvy8lDHCk75ISXlMHCv iKNQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=MDNTrAwZ; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-31307-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31307-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s13-20020a05620a29cd00b00783745cb706si5915380qkp.433.2024.01.19.07.23.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 07:23:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-31307-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=MDNTrAwZ; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-31307-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31307-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 741711C23474 for ; Fri, 19 Jan 2024 15:23:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A691354BC7; Fri, 19 Jan 2024 15:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MDNTrAwZ" Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 847E54F1E3; Fri, 19 Jan 2024 15:23:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705677781; cv=none; b=hon3pGdj+aH9A4RnYYqTmZ50PtBZimjG+/tZA59rnNAM6V2UQArPsPh+plAHW5ZQe7vWFpA9Kr5ppHwn10Qa2vBv3rAhOSL++tlhsLTLsDTJt1q2t2GojU9QpsonFQ3sHeeAu4Yr/SmDVWte+jKk4OU8K/kobGftsfGfn1mHSOE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705677781; c=relaxed/simple; bh=EjLDBsomiU8ZngEwrnZy6rdj0TTiUVpTHRanJEZFcR8=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=gKq7uu/mFNjLKR52XN7+ytNLEuKzyCyeUMh1wDj7dMZ6pxp2aHr8oN7KcbL2pa2AdF9g8j6rR7LzGNAcx8qH86eYDVRmmBWLspqLefy0XAjixA2v4m7acLzbxf7zWUYIEiFNgoPl8xHDjED63X02EtFHYxX62ZUr159bPTr48rk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MDNTrAwZ; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-21080bacc6fso497509fac.0; Fri, 19 Jan 2024 07:23:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705677779; x=1706282579; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7Myt403LL6AjEMnozelIwrs8mpGxi4XVDTkh5yb/uRI=; b=MDNTrAwZjjVaYO1CJtNNtM78A/Hob3d1dMFnKxN4Qdb3TzOhK9EGzecjAFz9FV/mEY IssfrlduYmm5+a3F68HXPGS2nkvnhEt5ffiojphVdDsgUoEa8OYQ4UoiKyAygtRfu9Fo ugLfFV/X5G2tOmRm3hPcw2TwsR1NgnPF4jK18nv0DNinQvmMchrPDIpsGsVe5uJn0om6 DMVnehCp4FJGHYs15beew5VEtS5suF/1fpdyBYDSv4gNp7cunTgjsqHjxhhmtDrkCFhU pfH23ojsZZbV4+bWkSEyWOFM2wM9vX1zwYIytpHsZeKIBj2BCBVHnzbiNXJParDs9kgn u7UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705677779; x=1706282579; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7Myt403LL6AjEMnozelIwrs8mpGxi4XVDTkh5yb/uRI=; b=T98BPFX6m5nPAf9/WHASTYczTr0je6XpZVZRGkAx5SQ3Ao3SwgqTm+TU2qC05dZQP9 LRy7RdmoDWZKwT4b9baqN+qXSNwxS6T9jiO9LoQVH6tad7AVhAb0KGEfW1ED1RMXlJ4e K+tuHBbH6CoSAw+6uMKgVW0+4lxBJKO2XAlC27AQ4mpWgVDwQBHSlagsUav8HnrMUiLP gxzy/lOWXoP/Fs5G/fRFjPcZY8InJmziWXJGUm1tj+0EG2fc3yK6wmB0hOJow7qrzCBV Z2JJVa6C+YmpRQZ0U0AS2ESzr9qO+TW+Ons/Ej3NvFPfXSD+5NlyRTT8mJUm3qroZc4f DdlQ== X-Gm-Message-State: AOJu0YxaxXE80mqaBv87bJFQRQxf24rTGjoyoJNVy4LSRndvU0kkrgI7 P46eKZ8uKkYguj3ZoQhk0TExB+0frX8zqEXTWtJesHB8247cvvpc X-Received: by 2002:a05:6870:a114:b0:210:b34c:6ed4 with SMTP id m20-20020a056870a11400b00210b34c6ed4mr2828009oae.101.1705677779470; Fri, 19 Jan 2024 07:22:59 -0800 (PST) Received: from localhost (131.65.194.35.bc.googleusercontent.com. [35.194.65.131]) by smtp.gmail.com with ESMTPSA id oo6-20020a056214450600b00683adba3316sm520457qvb.21.2024.01.19.07.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 07:22:59 -0800 (PST) Date: Fri, 19 Jan 2024 10:22:58 -0500 From: Willem de Bruijn To: Yunjian Wang , willemdebruijn.kernel@gmail.com, jasowang@redhat.com, kuba@kernel.org, davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xudingke@huawei.com, Yunjian Wang Message-ID: <65aa93d2e13af_29ebd42945f@willemb.c.googlers.com.notmuch> In-Reply-To: <1705659755-39828-1-git-send-email-wangyunjian@huawei.com> References: <1705659755-39828-1-git-send-email-wangyunjian@huawei.com> Subject: Re: [PATCH net 1/2] tun: fix missing dropped counter in tun_xdp_act Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Yunjian Wang wrote: > The commit 8ae1aff0b331 ("tuntap: split out XDP logic") includes > dropped counter for XDP_DROP, XDP_ABORTED, and invalid XDP actions. > Unfortunately, that commit missed the dropped counter when error > occurs during XDP_TX and XDP_REDIRECT actions. This patch fixes > this issue. > > Fixes: 8ae1aff0b331 ("tuntap: split out XDP logic") > Signed-off-by: Yunjian Wang Reviewed-by: Willem de Bruijn