Received-SPF: pass (google.com: domain of linux-kernel+bounces-31339-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240118223301.work.079-kees@kernel.org>
In-Reply-To: <20240118223301.work.079-kees@kernel.org>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Fri, 19 Jan 2024 18:05:19 +0200
Message-ID: <CAHp75VerSqay6cxRQOihC321BbpAWd_TB6aPigN8XZZ=KPXtHA@mail.gmail.com>
Subject: Re: [PATCH] string: Remove strlcpy()
To: Kees Cook <keescook@chromium.org>
Cc: Andy Shevchenko <andy@kernel.org>, Azeem Shaikh <azeemshaikh38@gmail.com>, 
	Andrew Morton <akpm@linux-foundation.org>, Andy Whitcroft <apw@canonical.com>, 
	Joe Perches <joe@perches.com>, Dwaipayan Ray <dwaipayanray1@gmail.com>, 
	Lukas Bulwahn <lukas.bulwahn@gmail.com>, linux-hardening@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jan 19, 2024 at 12:33=E2=80=AFAM Kees Cook <keescook@chromium.org> =
wrote:
>
> With all the users of strlcpy() removed[1] from the kernel, remove the
> API, self-tests, and other references. Leave mentions in Documentation
> (about its deprecation), and in checkpatch.pl (to help migrate host-only
> tools/ usage). Long live strscpy().

..

>   * Copies at most dstsize - 1 bytes into the destination buffer.
> - * Unlike strlcpy the destination buffer is always padded out.
> + * Unlike strscpy the destination buffer is always padded out.

While at it, please use the strscpy() form to refer to the function.

With that,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

--=20
With Best Regards,
Andy Shevchenko