Received-SPF: pass (google.com: domain of linux-kernel+bounces-31369-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <92bccaea-b73f-42e0-a386-1a73eb6f88de@intel.com>
Date: Fri, 19 Jan 2024 08:39:31 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 4/4] selftests/resctrl: Add non-contiguous CBMs CAT
 test
Content-Language: en-US
To: =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?= <maciej.wieczor-retman@intel.com>
CC: Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
	<ilpo.jarvinen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-kselftest@vger.kernel.org>
References: <cover.1702392177.git.maciej.wieczor-retman@intel.com>
 <10c3afd7f62c63db31a3d4af86529144a5d7bbf9.1702392177.git.maciej.wieczor-retman@intel.com>
 <fd6acf6a-2610-406b-b363-220121a45aee@intel.com>
 <6v4hgra7bd5nwubcgtbsidmoohrgxdw7no4faa4a54g4vrxo63@c6qnujvwn5ej>
 <73cea732-3757-4aec-a39c-4f0e50f6fb70@intel.com>
 <su2d6i22icynusoykmowfnzery6hlqugovaw4xcrhb7r3ymbx2@aeimvrxsc5xw>
 <05db3bdc-9d54-44d2-8aae-07d66053892e@intel.com>
 <wvehk3j2dcf3lkuantb7shefymxj2mnzv4pgbiqbk4jkmmzeid@lurk3dam5tb6>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <wvehk3j2dcf3lkuantb7shefymxj2mnzv4pgbiqbk4jkmmzeid@lurk3dam5tb6>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzhodFZQREV6bCtpNndVWmF0MEN3Vm93SHc1b09VL0pjcmxkYkJjVnNtR1hG?=
 =?utf-8?B?UVdXdWEyV0FqNmZzZE4xYnRNTldpUGNBV3dUck91dTFhVVN3S2dwblQ1YkJI?=
 =?utf-8?B?VndybXhsbTVweVNGYS9IbjNlRWlyQmY1Yml3TUFnOVEvam9zRklNTlFJQklj?=
 =?utf-8?B?UGNmU1hwbGdrV2JHb2lwSGFMMjFvV1F4UjM0OGNWUnh2UUhNY0N5UWhlcWhI?=
 =?utf-8?B?TlBOUE9QcWMzZjBvcWpaTmxEOFB3UmRuaXZwbkJndzJRZlJMWTZIaTlCNUtW?=
 =?utf-8?B?bktjS25UUC9leEUxRzhNNTFsR3dRcGJkbG1jWEVvQy9MdlRWT3o1TDZNc0I0?=
 =?utf-8?B?bVNaczhyZDlvWjk0V0Nvc0ZLejBjcEx6SVhCS1NQMDI1ZVk3L21pYndTVDJq?=
 =?utf-8?B?OXlMSTVhdWU3Sk9mS0ZacVdrNjFhOUJ6VzVKZDhNSy9OVWdCb2luSmEvR29k?=
 =?utf-8?B?YTFTaktyR1hFZXdvUTlQN2FidVFoSVVRcVF6blBMcXp5Z1RmblNBZGZXNEFm?=
 =?utf-8?B?bDVKQnFUclYveHlxSFZ3U3poWkE5QXVVL2ltRlp2ZDJwSWdleEIxL1lFZERN?=
 =?utf-8?B?ZC8zY0RDQnVJV25ZbExxOHdUbnRmUzI0MU5meHprWWc5c09kblhrWTZubzNs?=
 =?utf-8?B?MUxLTWtyNGN3ODJYQ3dlTjQvc2VPcnZnMVoyY2pxbHc2bWFJV2NmVG5zVUlx?=
 =?utf-8?B?Nm9Ra1ZMQ29EUUw1NGcxQmx3VllsdTlybFN5alB5eEVlUHIvU2tacTlTZUZ1?=
 =?utf-8?B?RDU3d0FxRkJRaGVBQVRMUnlUckhCcis2UXFRWWkrRXRBZHdFcHZMNmdrL3Iw?=
 =?utf-8?B?Z081clhoUkxVL3A4SDlUT2xsZ1F1b1NaRUk2RUFxa2xDVFJVRWJVUjFnRXhj?=
 =?utf-8?B?ekc1R2h2V1FkSWxCcHFoRmpaaHpyVVFLV2hBV0V4NDlMYjhtVE5HUnh4L0hk?=
 =?utf-8?B?Rm9vWlRjR2ZuR3Z0dUp4cTl5NXViMkt2eXBJa05WaGNYbVNUTVZlYkFYL2tN?=
 =?utf-8?B?eENucVVOUjZWck4wa3dLV3B4Y1p2UjE5QWpzOTNTNTZiNWVyQlp5UnJiV09l?=
 =?utf-8?B?NUJmelV0QmZ6bXgwMkxLckVkL3BnVTlabDYxL20zelRGYnBNbXE1dE5IZ05i?=
 =?utf-8?B?b2tjbDlqeW1xTDIyZVdlWWc0MXVRSFo5QmtxTlROdXQyWXNyTnhLNVUyRTgx?=
 =?utf-8?B?SFVodTNRaU9EZFNSa3hxWXRRM2dPN0JvekVIUTMwTllQU3hJTDZoYVZHVkVD?=
 =?utf-8?B?dFN4SkVTR3kzdjdPbktSRVcwdGVJeEtYck5XM3BleWhHekNPdXB5YXhqZ2JW?=
 =?utf-8?B?NU45d2gyVzdURlJGY1hLenYyUHYyQUJkQi9ZckRQbHdjdUpXOXZTdSsvUnhz?=
 =?utf-8?B?bFZDbmxrbFMwaGZ5akNiZ0ZRZG9vZ0hIalZKZ0NTK1BtTU1ISW9CUlBzT2pF?=
 =?utf-8?B?eWJRODMvNWNQSzVXTFlweTVnQi94dzI2Q0JiMFBXa2RvZUVzL2JVVEZERDdj?=
 =?utf-8?B?VElXaVpuMXY1a052S2l0MlF0WFV4U2ZQSDRaZnlUVGFLcUpkUjJyajlrQ2xN?=
 =?utf-8?B?K3VxRW16NVVEVHNKc3hNNjZnT2M4c1d4WDdsVXhvOTY4Q09SK3k4cjlpbXNn?=
 =?utf-8?B?ZE9EMTZBTjJEaDB0a2xjdXhwd1YwUDZMSFRneWIweEdlNy9NcUFpU3k0NndJ?=
 =?utf-8?B?M3ZFdm5mUDBnMHphbVY5QmJNSWR2dE8yN3ZITVBUKzI3NzdHTkQ2UVJuTUlI?=
 =?utf-8?B?THJTTW9rbUY2SjZPZ2t0aEVCYk9qT2JEQmJ0WmlheTBRYy83WUtaempadDBT?=
 =?utf-8?B?NE1SdWxTWm9lRldySXE0WGtnRVVodHB1aVZOeHlDZlJybFdqVnh6MEhQYUVn?=
 =?utf-8?B?ZFNhNENwUVRycjF2bmVQZFFzbHpaeHh1bTN1UndHbzVEcjFxZEROdWNrb0JN?=
 =?utf-8?B?eXhsSG53RzBCM0F6MWdKZmg0TW5rVE12QlFWWWxPdTJ6R0hNUEpJVnhOQjJB?=
 =?utf-8?B?U1BFaVB5aFdJaCtvZldoNDVsTHhKSHh5SmdIL2hhNEhRL0FselZ6b1dMSzRG?=
 =?utf-8?B?U2VHZWdteDhLT2dkSzZpN3FvdTBvOUpyc1dMMzV5K2FMbEczOXhlRkgwajBO?=
 =?utf-8?B?VDdOY0dUZHZJalIvMkVkQ1dHajlXejZiTDh0cnhyS0NGcXRIS3RWdVlyN0I1?=
 =?utf-8?B?V0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 179fa2ef-7914-49c2-ec87-08dc190d378d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 16:39:33.8920
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ra+jzIy0BkI+RGH84g8B2eGSPpP5cGptFWlcVniPs1e9FtR2tzyAlDtXnUfpnfYKt9+j05efq8fmjH6TyGgt87/Y4iLJ4OG3da9/akEJS8Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6429
X-OriginatorOrg: intel.com

Hi Maciej,

On 1/18/2024 11:37 PM, Maciej Wieczór-Retman wrote:
> On 2024-01-18 at 09:15:46 -0800, Reinette Chatre wrote:
>> On 1/18/2024 4:02 AM, Maciej Wieczór-Retman wrote:
>>> On 2024-01-17 at 10:49:06 -0800, Reinette Chatre wrote:
>>>> On 1/17/2024 12:26 AM, Maciej Wieczór-Retman wrote:
>>>>> On 2024-01-08 at 14:42:11 -0800, Reinette Chatre wrote:
>>>>>> On 12/12/2023 6:52 AM, Maciej Wieczor-Retman wrote:
>>
>>>>>>> +	bit_center = count_bits(full_cache_mask) / 2;
>>>>>>> +	cont_mask = full_cache_mask >> bit_center;
>>>>>>> +
>>>>>>> +	/* Contiguous mask write check. */
>>>>>>> +	snprintf(schemata, sizeof(schemata), "%lx", cont_mask);
>>>>>>> +	ret = write_schemata("", schemata, uparams->cpu, test->resource);
>>>>>>> +	if (ret)
>>>>>>> +		return ret;
>>>>>>
>>>>>> How will user know what failed? I am seeing this single test exercise a few scenarios
>>>>>> and it is not obvious to me if the issue will be clear if this test,
>>>>>> noncont_cat_run_test(), fails.
>>>>>
>>>>> write_schemata() either succeeds with '0' or errors out with a negative value. If
>>>>> the contiguous mask write fails, write_schemata should print out what was wrong
>>>>> and I believe that the test will report an error rather than failure.
>>>>
>>>> Right. I am trying to understand whether the user will be able to decipher what failed
>>>> in case there is an error. Seems like in this case the user is expected to look at the
>>>> source code of the test to understand what the test was trying to do at the time it
>>>> encountered the failure. In this case user may be "lucky" that this test only has
>>>> one write_schemata() call _not_ followed by a ksft_print_msg() so user can use that
>>>> reasoning to figure out which write_schemata() failed to further dig what test was
>>>> trying to do. 
>>>
>>> When a write_schemata() is executed the string that is being written gets
>>> printed. If there are multiple calls in a single tests and one fails I'd imagine
>>> it would be easy for the user to figure out which one failed.
>>
>> It would be easy for the user the figure out if (a) it is obvious to the user
>> what schema a particular write_schema() call attempted to write and (b) all the
>> write_schema() calls attempt to write different schema.
> 
> Okay, your comment made me wonder if on error the schemata still is printed. I
> double checked in the code and whether write_schemata() fails or not it has a
> goto path where before returning it will print out the schema. So I believe that
> satisfies your (a) condition.

Let me try with an example.
Scenario 1:
The test has the following code:
	...
	write_schemata(..., "0xfff", ...);
	...
	write_schemata(..., "0xf0f", ...);
	...

Scenario 2:
The test has the following code:
	...
	write_schemata(..., schemata, ...);
	...
	write_schemata(..., schemata, ...);
	...

Any failure of write_schemata() in scenario 1 will be easy to trace. As you
state, write_schemata() prints the schemata attempted and it will thus be
easy to look at the code to see which write_schemata() call failed since it
is obvious from the code which schemata was attempted.
A failure of one of the write_schemata() in scenario 2 will not be as easy
to trace since the user first needs to determine what the value of "schemata"
is at each call and that may depend on the platform, bit shifting done in test,
and state of system state at time of test.

> As for (b) depends on what you meant. Other tests that run more than one
> write_schemata() use different ones every time (CAT, MBM, MBA). Do you suggest
> that the non-contiguous test should attempt more schematas? For example shift
> the bit hole from one side to the other? I assumed one CBM with a centered bit
> hole would be enough to check if non-contiguous CBM feature works properly and
> more CBMs would be redundant.

Let me try with an example.
Scenario 1:
The test has the following code:
	...
	write_schemata(..., "0xfff", ...);
	...
	write_schemata(..., "0xf0f", ...);
	...

Scenario 2:
The test has the following code:
	...
	write_schemata(..., "0xfff", ...);
	...
	write_schemata(..., "0xfff", ...);
	...

A failure of either write_schemata() in scenario 1 will be easy to trace since 
the schemata attempted is different in each case. The schemata printed by the
write_schemata() error message can thus easily be connected to the specific
write_schemata() call.
A failure of either write_schemata() in scenario 2 is not so obvious since they
both attempted the same schemata so the error message printed by write_schemata()
could belong to either. 

Reinette