Received-SPF: pass (google.com: domain of linux-kernel+bounces-31382-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 19 Jan 2024 16:54:36 +0000
From: Conor Dooley <conor@kernel.org>
To: Nuno =?iso-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
	"Paller, Kim Seer" <KimSeer.Paller@analog.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Crt Mori <cmo@melexis.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH v6 1/2] dt-bindings: iio: frequency: add admfm2000
Message-ID: <20240119-mammary-another-f060e43bcdf7@spud>
References: <20240118085856.70758-1-kimseer.paller@analog.com>
 <20240118085856.70758-2-kimseer.paller@analog.com>
 <20240118-steadily-coauthor-de8275118901@spud>
 <PH0PR03MB71410860593D3C7253B200FCF9702@PH0PR03MB7141.namprd03.prod.outlook.com>
 <0f32caa9a11305333f1f18b97c97d775f4a5bb9a.camel@gmail.com>
 <20240119-squad-unflawed-934627f0e394@wendy>
 <dd3051170bc9724ca7e2884344dee3bc7b8f0a85.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="9HBH4EAVsLhP8n6J"
Content-Disposition: inline
In-Reply-To: <dd3051170bc9724ca7e2884344dee3bc7b8f0a85.camel@gmail.com>


--9HBH4EAVsLhP8n6J
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> > > Hmmm, How is the enum easier than a boolean property :)? I guess the =
device has a
> > > default mode. So, if it is Direct IF mode you have 'adi,mixer-mode' t=
o enable
> > > that
> > > mode and that's it. So the code is pretty much just:
> > >=20
> > > if (device_property_read_bool()) {
> >=20
> > device_property_present() is preferred I think.
> >=20
>=20
> Hmm, don't want to start an argument but I'm not sure either :). I would =
argue that
> device_property_read_bool() has more users (according to git grep - and i=
f I did not
> mess the grep) and it pretty much wraps device_property_present(). So, if=
 there was
> no value in it's "meaning" we would/should stop using it and eventually d=
rop it...
> Anyways, not really a big deal.

If there's an actually boolean property that can have a true/false
value, but testing for presence alone device_property_present() is
the more accurate function to use.

--9HBH4EAVsLhP8n6J
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZaqpTAAKCRB4tDGHoIJi
0rEOAP9G83tYMDwHe1/1SOd5SpfVPcFG+kAljyMoNIrOdxisAgD7BEnEbR6UIAWO
ci9GeMpBvOEMHO1eTPxQz6drAG7c1wk=
=+I9X
-----END PGP SIGNATURE-----

--9HBH4EAVsLhP8n6J--