Received-SPF: pass (google.com: domain of linux-kernel+bounces-31409-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Frank Li <Frank.Li@nxp.com>
To: manivannan.sadhasivam@linaro.org
Cc: Frank.Li@nxp.com,
	bhelgaas@google.com,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	festevam@gmail.com,
	helgaas@kernel.org,
	hongxing.zhu@nxp.com,
	imx@lists.linux.dev,
	kernel@pengutronix.de,
	krzysztof.kozlowski+dt@linaro.org,
	krzysztof.kozlowski@linaro.org,
	kw@linux.com,
	l.stach@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	linux-imx@nxp.com,
	linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org,
	lpieralisi@kernel.org,
	robh@kernel.org,
	s.hauer@pengutronix.de,
	shawnguo@kernel.org
Subject: [PATCH v9 13/16] PCI: imx6: Clean up get addr_space code
Date: Fri, 19 Jan 2024 12:11:19 -0500
Message-Id: <20240119171122.3057511-14-Frank.Li@nxp.com>
In-Reply-To: <20240119171122.3057511-1-Frank.Li@nxp.com>
References: <20240119171122.3057511-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?eHenKUmT2pgslIH4BlWv2dVS+fsKbeEzAfcyWTOxA1eA2eNxAghKH9HW8PVi?=
 =?us-ascii?Q?FJuNZvTrPvg1+/J119ZQZTJqHoz1/nQ8cfv7W3Oi1suf2+iMWC7GswmoSnAS?=
 =?us-ascii?Q?kZ68U8YpSKkf0iONyw5YPgKL8CYeIFsbIftvbtJsz9pVJxNqfPfcTTDODI5b?=
 =?us-ascii?Q?6nUNU1u62BCP6/mM0C78M3PSMo0/k0jh1+TQ3zwR4hqhog/U/m4kqA183ksJ?=
 =?us-ascii?Q?EXyr42RewMt4oIkD9pLiHIoZSzqVuAZtiCCot7rvfNTNCz6nXcNWEVUpa9Om?=
 =?us-ascii?Q?gmL2RThMj8+EvRFz+omAWsmj4h2vWKfV4Qfe6g/RUNdZ+pmcSqn5vXbohMDM?=
 =?us-ascii?Q?p8WDNKXYtBu5iUv/xGTqTzMOGKmlMi2HNsdxKsMwJzv/GQsvfXOHbgItKIvp?=
 =?us-ascii?Q?aONjE0XNU9zaCMX7YnhOI6lT8z9Gc+SVj/yBTnXA5kYJWIoSmJ1kr9quTB9L?=
 =?us-ascii?Q?6dozXVye/V8ud4ZgIKKQM5DoF35/mi2e5Pt5ZAK6KtLgOH/GJWXGYA99u+pn?=
 =?us-ascii?Q?gwjVKsnQHaNQ3qqNK/sRAj/1hSo7esyE6z9Li78QP98eOOq0bt4peeGBdNCS?=
 =?us-ascii?Q?3dXdpXd0rZVxbALYJTIFAA8/xeQ8FjGX7MkNKh9qJSHetk6NVSuAEkb1Oylh?=
 =?us-ascii?Q?DbvS1YOjsOAwE2yPoatMR8PIpqnsOd60BqAvTlM7pXxKBl/MILWcV3HdYOdG?=
 =?us-ascii?Q?luFofR17DROqSRFI0m3fKtEyM3frYauh+RAMuYMrTaIA1grqgBkVu/ccvgzy?=
 =?us-ascii?Q?OXz+Tj2PunJd9bWa8xf9KTL7cSn9PniV9kDnkVc6tvF1u6CxS5a+YVsy7AkW?=
 =?us-ascii?Q?sbB/gkOwpgKfDeZjMSQ0mVs4dTXrBvxTVgIKZlQcRyXZ68DdqHOx7ltnyXPb?=
 =?us-ascii?Q?UU2pslRoKMLqmbWhWTvscRiSSOvVa5GhvXl1SeNfF9NQkZXMY9tkl3VzSRW0?=
 =?us-ascii?Q?1/Z5Uz5miVZh4AYIJ7tvNOC2BoftdCp7kNTSdZUNOJsG3tDyFu7xFLtxh1z/?=
 =?us-ascii?Q?AGur4bJbMueBeLKUe/eDUoiKlS1YEtmtHn09Fx3slvdeHR3Pg5OxPDRnn+kH?=
 =?us-ascii?Q?RP5+ijOc5pji6Qht1KTV/SiLTEIO/jNCcZO4RM3KTZaKOz3j0ajuOd6SEtEN?=
 =?us-ascii?Q?9ERUDGIw+zJXuv2hQkugs4lt9jIUx+5QRvQ85rQAjrw4ulGiM59fRxE2wVmk?=
 =?us-ascii?Q?G9X9eyqVLlcftsZSVZSUNMN9q4kS8DWIxkWOAEQ4tuMHUpOLH1VGcjoZluK3?=
 =?us-ascii?Q?MKaMRyLz6Tsd2nMgpewzLY6Rce24BnDuSVA86QnIgY06jTrToe/QR+VUziGG?=
 =?us-ascii?Q?sBdJbDWs/AKWwAN6Xq7Ym7jlXSGeQnIiMQyiL9xah9sZ16uV8YU3T9TKcsH+?=
 =?us-ascii?Q?er+/Wj0BtRmjoBUztBijrsQvXj1DgZm84IJu7y+8sfAOFV740H520U4otOMD?=
 =?us-ascii?Q?o1S6jo0ZKx28iA0qxfko8rR9FLIAdb49la/i+2Y7SEF3pOn2csY38pOCMQ3j?=
 =?us-ascii?Q?Zyus/Yg+/vamqkpfUU+TfvVp3gm2ZYPnnq5nqL62sZfNpJh3cbJSdVmicWgY?=
 =?us-ascii?Q?go2KpoDJ0jTjLquenCo=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f29ea169-680b-4a2a-3fcd-08dc1911dd06
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 17:12:49.4238
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YHj+Sv53KtWDIgEzoKSN7ylHVlMDLSKnCyuumjelN9m02UhaMmPjrDeL1o+tEzywz6flSpb5ukKL2qxJcSJ2zA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9688

Since the dw_pcie_ep_init() function is already fetching the 'addr_space'
region, no need to do the same in this driver.

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v7 to v8
    - update commit message
    - Add Manivannan Sadhasivam's review tag
    Change from v4 to v7
    - none
    Change from v1 to v3
    - new patches

 drivers/pci/controller/dwc/pci-imx6.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 1cfa5f14f18f3..139ed618bfccc 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1067,7 +1067,6 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
 	int ret;
 	unsigned int pcie_dbi2_offset;
 	struct dw_pcie_ep *ep;
-	struct resource *res;
 	struct dw_pcie *pci = imx6_pcie->pci;
 	struct dw_pcie_rp *pp = &pci->pp;
 	struct device *dev = pci->dev;
@@ -1086,14 +1085,8 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
 		pcie_dbi2_offset = SZ_4K;
 		break;
 	}
-	pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
-	if (!res)
-		return -EINVAL;
 
-	ep->phys_base = res->start;
-	ep->addr_size = resource_size(res);
-	ep->page_size = SZ_64K;
+	pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
 
 	ret = dw_pcie_ep_init(ep);
 	if (ret) {
-- 
2.34.1