Received-SPF: pass (google.com: domain of linux-kernel+bounces-31432-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Erick Archer <erick.archer@gmx.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Franziska Naepelt <franziska.naepelt@googlemail.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Johannes Berg <johannes.berg@intel.com>,
	Jeff Johnson <quic_jjohnson@quicinc.com>,
	Aloka Dixit <quic_alokad@quicinc.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Erick Archer <erick.archer@gmx.com>,
	linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH] staging: rtl8723bs: Use kcalloc() instead of kzalloc()
Date: Fri, 19 Jan 2024 18:39:00 +0100
Message-Id: <20240119173900.11035-1-erick.archer@gmx.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:zdYhetBxIF8=;RhAHn+3ji1UPG7DZxHdTUJDXCzh
 YyXaHAnALTH8GU2RufWgaYtiiRGRZC4Ijkw667x/1IHWa79O5GiqDUigl49atNvzw1boyMl9H
 X/rWzZ49LASvMMW+58A3b25b+BSrGDziuxYLKzcASXGs3dWdLimmXfJqYzlsbCamVMpgzGpjh
 aI3/MDOm9WDHfHJxsdkb3MqxISYQUifeg3Xn6Hyvav9Tw/Z+52rCUFgFtP1VQLHwfFdV3Q8Oh
 44iNsz/wYgnmWZK3gB1mNwd9e2Thicey00wQZydBc21SS12cDDQBlYRDJpH8cToNQEO2hbAcD
 dwJCHjG5/hGLDnXALn1MDDQGFzlw9jnJ1v5n/VyT4qFmhFUfXufx5DNWFzi0yuqtCJ9MoSTDz
 XX0R2owi+zZgLBpmArohGiRx2ia+GbDFk42kwpQ1mu6tb04NXV2yPKupzEyjEDKjT9qhDfsTL
 tOgV9yxL9yLD1TVFg49BD6RR4AM40/BkK78vgR7DdC/egqMnpFMjXTwGV9YWTUSIuP3QRmIpr
 sJGwKsZXDAZeLYbVYNa/djUF8BzRZp42MTEN4MIrAd34WdVkff/nhsFplQafK+gtuunTOoEM3
 cpG64sBcuY9MzqePR0J9OMqjAV99tUW7LBIl7y7gpXnBO5XrEVpqnv046Al3V+ATikBMjLsqc
 /MM3rYG39vkeZk07cfD7iFltZHNuuicixXTXCge4yw0znd5IMk4/JXTgZ1gtalu70TyBIGYsj
 TW1LDhYaGfEGs1m7tgtAODnIASX1rDAqVwTdUPaZpdzLiOFofZxfRqee21dK8jEcX0NViJ4Dw
 Ep37Go6hB+cZt2xeQSZib07jMGI2TMIaM20//VW3dhhbH+7qc897zMyUoXLQtZnSAL3+7GBcK
 WHFxaNBroRuabyEBKVhHQduD76OhvnodlwrHNGYiZMGM352rDLRowoPwryhc7Ns49JcMO7L6w
 AJRa0J00dsBla/3OhpAJNyxnKc0=

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
count * size in the kzalloc() function.

Also, it is preferred to use sizeof(*pointer) instead of sizeof(type)
due to the type of the variable can change and one needs not change the
former (unlike the latter).

Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-co=
ded-arithmetic-in-allocator-arguments [1]
Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Erick Archer <erick.archer@gmx.com>
=2D--
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/s=
taging/rtl8723bs/os_dep/ioctl_cfg80211.c
index 1ff763c10064..65a450fcdce7 100644
=2D-- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -1259,8 +1259,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy
 		goto check_need_indicate_scan_done;
 	}

-	ssid =3D kzalloc(RTW_SSID_SCAN_AMOUNT * sizeof(struct ndis_802_11_ssid),
-		       GFP_KERNEL);
+	ssid =3D kcalloc(RTW_SSID_SCAN_AMOUNT, sizeof(*ssid), GFP_KERNEL);
 	if (!ssid) {
 		ret =3D -ENOMEM;
 		goto check_need_indicate_scan_done;
=2D-
2.25.1