Received-SPF: pass (google.com: domain of linux-kernel+bounces-31436-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 19 Jan 2024 17:47:55 +0000
From: Mark Brown <broonie@kernel.org>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] arm64/signal: Don't assume that TIF_SVE means we saved
 SVE state
Message-ID: <Zaq1y9XpmzTsXDp8@finisterre.sirena.org.uk>
References: <20240119-arm64-sve-signal-regs-v1-1-b9fd61b0289a@kernel.org>
 <Zaqj0V82LD8wu6g+@e133380.arm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="PdO/yksGZmL1ku6b"
Content-Disposition: inline
In-Reply-To: <Zaqj0V82LD8wu6g+@e133380.arm.com>


--PdO/yksGZmL1ku6b
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jan 19, 2024 at 04:31:13PM +0000, Dave Martin wrote:
> On Fri, Jan 19, 2024 at 12:29:13PM +0000, Mark Brown wrote:

> > When we are in a syscall we will only save the FPSIMD subset even though
> > the task still has access to the full register set, and on context switch

> (Pedantic nit: "A even if B" (= "A applies even in that subset of cases
> where B"), instead of "A even though B" (= "A applies notwithstanding
> that it is always the case that B") (?)  If the SVE trapping were
> ripped out altogether, it would be a different and rather simpler
> story...)

I really can't follow what you're trying to say here.  I'm not sure I
where the bit about "always" comes from here?

> If the historical meanings of TIF_SVE have been split up (which seems a
> good idea), does that resolve all of the "bare"
> test_thread_flag(TIF_SVE) that were still there?

There's a couple more, but this is all of them in the signal handling
code - I should have one or two more patches.  Most of the usage is
actually checking the trapping and therefore fine.

--PdO/yksGZmL1ku6b
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWqtcgACgkQJNaLcl1U
h9AnUwf/cnpsqEC3KvSy0DsFTKN0rbF0fDrKRjOyNBrxsRlSeBJVuMRm82vExP1y
55AVWYomuk5PgouebJsPlcOP8+llMA3ADhGOG4Jq1vD2HYZ7mryl9Jm8S1NJ2omK
QeGhhBBbFefKqAhPZNtNCH0YCAWIIYENLPO9AxL8Wc318R5mpoAVq4G6yYgy/IaC
8qxER+wemvizj6fBGClDtCe3QVza+q85fAMkP/5ut7E1MFN77QBYcbKpqL7kBfyO
n6InpHuFhsgF1VlzlyKUC0qEhDEgoQhASDKo2RWIy5aKrBBF5ZpOaDjyHBC6I8tS
cRIuKdmODvJk17W3Z1ODokGNBJopsg==
=vwkD
-----END PGP SIGNATURE-----

--PdO/yksGZmL1ku6b--