Received-SPF: pass (google.com: domain of linux-kernel+bounces-31461-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <da4f6145-9279-4501-98d3-b8ab1bc53f19@intel.com>
Date: Fri, 19 Jan 2024 11:05:37 -0700
User-Agent: Betterbird (Linux)
Subject: Re: [PATCH v2 1/3] cxl/pci: Rename DOE mailbox handle to doe_mb
To: Robert Richter <rrichter@amd.com>, Alison Schofield
	<alison.schofield@intel.com>, Vishal Verma <vishal.l.verma@intel.com>, "Ira
 Weiny" <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>,
	Jonathan Cameron <jonathan.cameron@huawei.com>, Davidlohr Bueso
	<dave@stgolabs.net>
CC: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>, "Rafael J.
 Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>
References: <20240108114833.241710-1-rrichter@amd.com>
 <20240108114833.241710-2-rrichter@amd.com>
Content-Language: en-US
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20240108114833.241710-2-rrichter@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTlLOFBRblhBdUd4MHhENTBsOHl4eGVwRTRXZTgrN2JsTStVYzJURnNNSUdu?=
 =?utf-8?B?ek1lelpoUkxiRHU5aGZoUDJ5SzZkWlpjdWF1K2pmci9scm9hU0pUMXo1anZu?=
 =?utf-8?B?QUFxZndBNlRuckQvOTJLNzZFcFVocFFzdVdGSy9jNmFxbEJVZzBCRGtLUlZK?=
 =?utf-8?B?a2JGNy82cUZ4TGdmNFZVZ29HVmpCSEVQbFpiQTBLT3pWWnQzdDFacmw1N3pl?=
 =?utf-8?B?cVE4dnRsWXBZSTdscnA1M2hnOEZaYSsrdzF5T2ExNW11UUloTFpteXlrdCtT?=
 =?utf-8?B?NWszVUZoeHNjQ1pKNFNJZFh5ZWNXNVMzakVWQjZSazRWeTZwM3VrMzF2K2Zj?=
 =?utf-8?B?K3lCNGZicUREMGg1cHNaRG5mSHFUakcvSjJ2OW5BY0NtZVF2dkNPNjZUb2c2?=
 =?utf-8?B?M0w5N3BHVUNHL3kxMWtMdTBZZHhyK2V0SGtza2NwVVR3R2pQemFqeDRvd2N4?=
 =?utf-8?B?MURuYW52eE5DQUxwSlo5ZUc3TlB5d3E1VHlnRGF5dko4UmtsNlR6UmlQd2Ri?=
 =?utf-8?B?YiswL2dMOTVlanM4Tm9rMjc5ZXhld2g5Qnp5M3BhRmplV2lFRk5PalZOL3NH?=
 =?utf-8?B?WUdXaE1LdTBNdVhYK2VlVDR3WTBBMHdYeWJINlJ6QW9CNXV2Q3lJTUpyaDQ3?=
 =?utf-8?B?YTM2OXJpRTZSb3VWUXc0Z0U1ejgySGNPSmF4bEFLN0ErQUVlS0lRMlV4Vkxs?=
 =?utf-8?B?dUFoV0llWWF6dzdsREU4RVAxSHNyVkF1Y2ZqNnlZUzhqNFdvbm5yMVFmSnor?=
 =?utf-8?B?R1BLeTZqNDZVeUt1SThndVl6VHh0WlltaG4yTWNyR0QxdlZTRkhrN3NqU2lp?=
 =?utf-8?B?UTRDQWgzUFBJNkdLNFhuK0dVcGxMWVN0ZVF2bFdHSUM4TGZxVE9UV29qR2Ix?=
 =?utf-8?B?alJlZFNsRDcxc3JMdzlUYzVyODRIL2xYQzZSOTg2c1dkYXliY2s5eXVTaWRE?=
 =?utf-8?B?aXU3NlBpOG56RkRkWXV6Zm5UYSs2WlRxRHZwbldoTDk3MlhZWC9nU0t1TTBF?=
 =?utf-8?B?ZkdnR0M3Q1NzT1B1L290YkRBOUp5NVNCRzVleFJ2ajhVTHhQYmowYW9qU2VZ?=
 =?utf-8?B?ZWhLL2N4WE0rV09BWGhra3doUHNJZU1qeCtpRTBrV00wNUY4Q3FML01FeWxP?=
 =?utf-8?B?c2xiSnpaR1RUaUJtNmdMNU1rdHJ0cS91Y1V4QllFamFwWXNKaXVSb2M3WE1h?=
 =?utf-8?B?elNmazRhVGFEbWk2YWNhN3k3c05UYkdZbWtlbVJRUld6ajA1Q1llVnVhTmJV?=
 =?utf-8?B?Y2xjYU54Tm1sMTNqSE9WUVNrc2VIcGxubDZFY0hFR1RTWGFCMzI0U013cVdT?=
 =?utf-8?B?N1dlY3V5WkxXREw1cXpxRTZGVlBrTHlVcFcxT1NMZ3BMRDNxVlYyb0s4TTFw?=
 =?utf-8?B?QU9tSGdsMHhPczdJRFhKWkI2dHNDczA1MXhmR09NVGRJWXBHYU9LN3JDUGJV?=
 =?utf-8?B?VmhhL2Q5eUdPOWtrRUtnUUJaZ3lUQXhub3lsUkY3enNQVDNlUEtVN05YdEM1?=
 =?utf-8?B?cFVELzNvdFl4M3lNZlBBaU9seHIvV25nbkNqUUdmU1VZejh1TDdZZlVuZFZP?=
 =?utf-8?B?b3I3dTE3RHVQSldvdUxrNjRJZThKaisxMlFBdkhNeUVSdkxGRUlpckMwQ1Vj?=
 =?utf-8?B?ZW9lN3hqKzhmTjJHTTFKWEhEU2F6UHdTeW5lTU91K1lUVHZDZUg1THF4U3Yz?=
 =?utf-8?B?NldBSy9yNE1mOTRZd0xISkNGNDRGK2dBaUNPd3h2ZS8zbG5TTUFsb0MrL0Qz?=
 =?utf-8?B?SHY4eXJ6RHFvNHN2YWVMZnpIdk0wRnFsRkVra3hSRG5LOCtnUmlyZVRQeTNl?=
 =?utf-8?B?MFMwdFpFOVZIRWozWmxHYlplZE1tT25nU1AzYlNxSzMrd2kwOWppOStvc2tW?=
 =?utf-8?B?ZVNGbVBsSEZNNytnanhDVC9MSnNMRCtqekticW1kWEU2V3pZNkJHeXlTOHp1?=
 =?utf-8?B?aUVXY204SjR2eE5ZNzZSUlJXa0JGTWZiNWkzSUVsTituU0NiYU5SNEhPUFBt?=
 =?utf-8?B?a2tFQWh2TzQwY0tsWTVYa1hESVpUUnpVZVJRcHd0eFpYSC91SS9iLzJlWnlo?=
 =?utf-8?B?R3lzSEF2bWRLZHhoTzlOZlhnSFllQmRVSURFRWhmSktmNmlpcUlUVTZURXJ6?=
 =?utf-8?Q?YEdFuWYWEnZnH6TITLH54UxaT?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 471e2ad9-6d88-4dc4-6a4a-08dc19193f85
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 18:05:41.2682
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kh8+yLk6ekKKM6v7IDH5MW/4uWNfFvYuvSQ4mHnKqS6AMMp5Gx0VdUZr1XPcaNptmZGCsVvea5SaIO9FXvws4w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4854
X-OriginatorOrg: intel.com


On 1/8/24 04:48, Robert Richter wrote:
> Trivial variable rename for the DOE mailbox handle from cdat_doe to
> doe_mb. The variable name cdat_doe is too ambiguous, use doe_mb that
> is commonly used for the mailbox.
> 
> Signed-off-by: Robert Richter <rrichter@amd.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/cxl/core/pci.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c
> index 6c9c8d92f8f7..89bab00bb291 100644
> --- a/drivers/cxl/core/pci.c
> +++ b/drivers/cxl/core/pci.c
> @@ -518,14 +518,14 @@ EXPORT_SYMBOL_NS_GPL(cxl_hdm_decode_init, CXL);
>  	 FIELD_PREP(CXL_DOE_TABLE_ACCESS_ENTRY_HANDLE, (entry_handle)))
>  
>  static int cxl_cdat_get_length(struct device *dev,
> -			       struct pci_doe_mb *cdat_doe,
> +			       struct pci_doe_mb *doe_mb,
>  			       size_t *length)
>  {
>  	__le32 request = CDAT_DOE_REQ(0);
>  	__le32 response[2];
>  	int rc;
>  
> -	rc = pci_doe(cdat_doe, PCI_DVSEC_VENDOR_ID_CXL,
> +	rc = pci_doe(doe_mb, PCI_DVSEC_VENDOR_ID_CXL,
>  		     CXL_DOE_PROTOCOL_TABLE_ACCESS,
>  		     &request, sizeof(request),
>  		     &response, sizeof(response));
> @@ -543,7 +543,7 @@ static int cxl_cdat_get_length(struct device *dev,
>  }
>  
>  static int cxl_cdat_read_table(struct device *dev,
> -			       struct pci_doe_mb *cdat_doe,
> +			       struct pci_doe_mb *doe_mb,
>  			       void *cdat_table, size_t *cdat_length)
>  {
>  	size_t length = *cdat_length + sizeof(__le32);
> @@ -557,7 +557,7 @@ static int cxl_cdat_read_table(struct device *dev,
>  		size_t entry_dw;
>  		int rc;
>  
> -		rc = pci_doe(cdat_doe, PCI_DVSEC_VENDOR_ID_CXL,
> +		rc = pci_doe(doe_mb, PCI_DVSEC_VENDOR_ID_CXL,
>  			     CXL_DOE_PROTOCOL_TABLE_ACCESS,
>  			     &request, sizeof(request),
>  			     data, length);
> @@ -617,7 +617,7 @@ void read_cdat_data(struct cxl_port *port)
>  {
>  	struct device *uport = port->uport_dev;
>  	struct device *dev = &port->dev;
> -	struct pci_doe_mb *cdat_doe;
> +	struct pci_doe_mb *doe_mb;
>  	struct pci_dev *pdev = NULL;
>  	struct cxl_memdev *cxlmd;
>  	size_t cdat_length;
> @@ -638,16 +638,16 @@ void read_cdat_data(struct cxl_port *port)
>  	if (!pdev)
>  		return;
>  
> -	cdat_doe = pci_find_doe_mailbox(pdev, PCI_DVSEC_VENDOR_ID_CXL,
> -					CXL_DOE_PROTOCOL_TABLE_ACCESS);
> -	if (!cdat_doe) {
> +	doe_mb = pci_find_doe_mailbox(pdev, PCI_DVSEC_VENDOR_ID_CXL,
> +				      CXL_DOE_PROTOCOL_TABLE_ACCESS);
> +	if (!doe_mb) {
>  		dev_dbg(dev, "No CDAT mailbox\n");
>  		return;
>  	}
>  
>  	port->cdat_available = true;
>  
> -	if (cxl_cdat_get_length(dev, cdat_doe, &cdat_length)) {
> +	if (cxl_cdat_get_length(dev, doe_mb, &cdat_length)) {
>  		dev_dbg(dev, "No CDAT length\n");
>  		return;
>  	}
> @@ -656,7 +656,7 @@ void read_cdat_data(struct cxl_port *port)
>  	if (!cdat_buf)
>  		return;
>  
> -	rc = cxl_cdat_read_table(dev, cdat_doe, cdat_buf, &cdat_length);
> +	rc = cxl_cdat_read_table(dev, doe_mb, cdat_buf, &cdat_length);
>  	if (rc)
>  		goto err;
>