Received-SPF: pass (google.com: domain of linux-kernel+bounces-31536-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 19 Jan 2024 21:12:18 +0100
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: djogorchock@gmail.com, jikos@kernel.org, benjamin.tissoires@redhat.com,
 linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot
 <abaci@linux.alibaba.com>
Subject: Re: [PATCH] HID: nintendo: Remove some unused functions
From: "Silvan Jegen" <s.jegen@gmail.com>
References: <20240119072729.54499-1-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <20240119072729.54499-1-jiapeng.chong@linux.alibaba.com>
Message-Id: <3SMXOLWNXNNST.2TH7SLE53PSD3@homearch.localdomain>
User-Agent: mblaze/1.2-26-ga287cf9 (2023-10-22)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> These functions are defined in the hid-nintendo.c file, but not called
> elsewhere, so delete these unused functions.
>=20
> drivers/hid/hid-nintendo.c:670:20: warning: unused function 'joycon_devic=
e_is_left_joycon'.
> drivers/hid/hid-nintendo.c:674:20: warning: unused function 'joycon_devic=
e_is_right_joycon'
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D7992
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/hid/hid-nintendo.c | 10 ----------
>  1 file changed, 10 deletions(-)

Reviewed-by: Silvan Jegen <s.jegen@gmail.com>


>=20
> diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
> index ccc4032fb2b0..7ce6be0a8dee 100644
> --- a/drivers/hid/hid-nintendo.c
> +++ b/drivers/hid/hid-nintendo.c
> @@ -667,16 +667,6 @@ struct joycon_ctlr {
>   * These helpers are most useful early during the HID probe or in conjun=
ction
>   * with the capability helpers below.
>   */
> -static inline bool joycon_device_is_left_joycon(struct joycon_ctlr *ctlr=
)
> -{
> -	return ctlr->hdev->product =3D=3D USB_DEVICE_ID_NINTENDO_JOYCONL;
> -}
> -
> -static inline bool joycon_device_is_right_joycon(struct joycon_ctlr *ctl=
r)
> -{
> -	return ctlr->hdev->product =3D=3D USB_DEVICE_ID_NINTENDO_JOYCONR;
> -}
> -
>  static inline bool joycon_device_is_procon(struct joycon_ctlr *ctlr)
>  {
>  	return ctlr->hdev->product =3D=3D USB_DEVICE_ID_NINTENDO_PROCON;