Received-SPF: pass (google.com: domain of linux-kernel+bounces-31551-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 19 Jan 2024 20:40:43 +0000
From: Simon Horman <horms@kernel.org>
To: MD Danish Anwar <danishanwar@ti.com>
Cc: Rob Herring <robh@kernel.org>, Dan Carpenter <dan.carpenter@linaro.org>,
	Jan Kiszka <jan.kiszka@siemens.com>, Andrew Lunn <andrew@lunn.ch>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Roger Quadros <rogerq@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, srk@ti.com, r-gunasekaran@ti.com
Subject: Re: [RFC PATCH v2 2/3] net: ti: icssg-switch: Add switchdev based
 driver for ethernet switch support
Message-ID: <20240119204043.GC105385@kernel.org>
References: <20240118071005.1514498-1-danishanwar@ti.com>
 <20240118071005.1514498-3-danishanwar@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240118071005.1514498-3-danishanwar@ti.com>

On Thu, Jan 18, 2024 at 12:40:04PM +0530, MD Danish Anwar wrote:

..

> @@ -211,6 +216,15 @@ struct prueth_pdata {
>   * @iep0: pointer to IEP0 device
>   * @iep1: pointer to IEP1 device
>   * @vlan_tbl: VLAN-FID table pointer
> + * @hw_bridge_dev: pointer to HW bridge net device
> + * @br_members: bitmask of bridge member ports
> + * @prueth_netdevice_nb: netdevice notifier block
> + * @prueth_switchdevice_nb: switchdev notifier block

nit: s/prueth_switchdevice_nb/prueth_switchdev_nb/

     Flagged by ./scripts/kernel-doc -none

> + * @prueth_switchdev_bl_nb: switchdev blocking notifier block
> + * @is_switch_mode: flag to indicate if device is in Switch mode
> + * @is_switchmode_supported: indicates platform support for switch mode
> + * @switch_id: ID for mapping switch ports to bridge
> + * @default_vlan: Default VLAN for host
>   */
>  struct prueth {
>  	struct device *dev;
> @@ -236,6 +250,16 @@ struct prueth {
>  	struct icss_iep *iep0;
>  	struct icss_iep *iep1;
>  	struct prueth_vlan_tbl *vlan_tbl;
> +
> +	struct net_device *hw_bridge_dev;
> +	u8 br_members;
> +	struct notifier_block prueth_netdevice_nb;
> +	struct notifier_block prueth_switchdev_nb;
> +	struct notifier_block prueth_switchdev_bl_nb;
> +	bool is_switch_mode;
> +	bool is_switchmode_supported;
> +	unsigned char switch_id[MAX_PHYS_ITEM_ID_LEN];
> +	int default_vlan;
>  };
>  
>  struct emac_tx_ts_response {

..