Received-SPF: pass (google.com: domain of linux-kernel+bounces-31561-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 19 Jan 2024 21:10:15 +0000
Message-Id: <CYIZP2D9FS0N.1XY2F5VX9STEY@seitikki>
Cc: <keyrings@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v2] keys: update key quotas in key_put()
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Luis Henriques" <lhenriques@suse.de>, "David Howells"
 <dhowells@redhat.com>, "Eric Biggers" <ebiggers@kernel.org>
References: <2744563.1702303367@warthog.procyon.org.uk>
 <20240115120300.27606-1-lhenriques@suse.de>
In-Reply-To: <20240115120300.27606-1-lhenriques@suse.de>

On Mon Jan 15, 2024 at 12:03 PM UTC, Luis Henriques wrote:
> Delaying key quotas update when key's refcount reaches 0 in key_put() has
> been causing some issues in fscrypt testing.  This patches fixes this tes=
t
                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~=
~
						This commit fixes the test

> flakiness by dealing with the quotas immediately, but leaving all the oth=
er
> clean-ups to the key garbage collector.  Unfortunately, this means that w=
e
> also need to switch to the irq-version of the spinlock that protects quot=
a.

The commit message fails to describe the implementation changes.

You have a motivation paragraph but you also need to add implementation
paragraph, which describes how the code changes reflect the motivation.

BR, Jarkko