Received-SPF: pass (google.com: domain of linux-kernel+bounces-31577-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240111081914.3123-1-adrian.hunter@intel.com>
 <20240111081914.3123-11-adrian.hunter@intel.com> <87ply1lebh.fsf@linux.intel.com>
 <60cc9fa8-e714-41d0-a82d-9c8a54dfde4e@intel.com>
In-Reply-To: <60cc9fa8-e714-41d0-a82d-9c8a54dfde4e@intel.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Fri, 19 Jan 2024 13:28:41 -0800
Message-ID: <CAM9d7cg3T6DKoyDj4G7+9rQosqVKhCPpS0DZEXuLgbVwe+QM4w@mail.gmail.com>
Subject: Re: [PATCH V4 10/11] perf intel-pt: Add documentation for pause / resume
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andi Kleen <ak@linux.intel.com>, Peter Zijlstra <peterz@infradead.org>, 
	Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Heiko Carstens <hca@linux.ibm.com>, 
	Thomas Richter <tmricht@linux.ibm.com>, Hendrik Brueckner <brueckner@linux.ibm.com>, 
	Suzuki K Poulose <suzuki.poulose@arm.com>, Mike Leach <mike.leach@linaro.org>, 
	James Clark <james.clark@arm.com>, coresight@lists.linaro.org, 
	linux-arm-kernel@lists.infradead.org, Yicong Yang <yangyicong@hisilicon.com>, 
	Jonathan Cameron <jonathan.cameron@huawei.com>, Will Deacon <will@kernel.org>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>, 
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

On Tue, Jan 16, 2024 at 4:22=E2=80=AFAM Adrian Hunter <adrian.hunter@intel.=
com> wrote:
>
> On 16/01/24 13:15, Andi Kleen wrote:
> > Adrian Hunter <adrian.hunter@intel.com> writes:
> >> +
> >> +For example, to trace only the uname system call (sys_newuname) when =
running the
> >> +command line utility uname:
> >> +
> >> + $ perf record --kcore -e
> >> intel_pt/aux-action=3Dstart-paused/k,syscalls:sys_enter_newuname/aux-a=
ction=3Dresume/,syscalls:sys_exit_newuname/aux-action=3Dpause/
> >> uname
> >
> > It's unclear if the syntax works for hardware break points, kprobes, up=
robes too?
>
> Yes, the perf tool syntax requires only that the group leader is
> an AUX area event like intel_pt.  Note that an attempt is made to
> automatically group AUX area events with events with aux-action,
> so grouping syntax like '{...}' is not always necessary.

Depends on the position, right?  Maybe there can be other events
without aux-action mixed with aux events.

Thanks,
Namhyung

>
> Note the current kernel implementation is called from
> __perf_event_output() which is used in nearly all cases for the
> output of samples, the exceptions being Intel BTS (which we do not
> support at the same time as Intel PT, but wouldn't make much sense
> anyway) and S390 cpumsf_output_event_pid().
>
> > That would be most useful. If it works would be good to add examples fo=
r it.
>
> OK
>