Received-SPF: pass (google.com: domain of linux-kernel+bounces-31592-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 19 Jan 2024 16:49:07 -0500
From: Frank Li <Frank.li@nxp.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Nuno =?iso-8859-1?Q?S=E1?= <noname.nuno@gmail.com>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	linux-usb@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH v4 1/4] usb: gadget: Support already-mapped DMA SGs
Message-ID: <ZaruU5BpQF8SeZZS@lizhi-Precision-Tower-5810>
References: <20240117122646.41616-1-paul@crapouillou.net>
 <20240117122646.41616-2-paul@crapouillou.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240117122646.41616-2-paul@crapouillou.net>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4w5dt3pffptiHSgwPXBphiAPpuB4nLzEUDZUrvJz6bGAFNVqnUXMQBAlm+6p?=
 =?us-ascii?Q?QPkME559I6anJLKWRhox32nXgDKtUfSM9kh18s+X5pRgAKOMcUBVnMoREnnR?=
 =?us-ascii?Q?LXkwGx5fby/qUq6nmoFbwVt9Qs4z7pc5YiksCjsp8seDb/m1rkSk1uRKPxcs?=
 =?us-ascii?Q?hom5317Mqv7Wng67LZId+EUNltK+4M3ibM6a6vArQjbOU/RDK42jooOZvDh6?=
 =?us-ascii?Q?4Ak/n2IpsQvDxYaH86/qaUaTIGZ4cEv62tK0FQrrLjzDw8VLfIIhDdC6OgFv?=
 =?us-ascii?Q?WCAHc64bWFW1D8NRrpohV+MhPRBNalD5YiA1+9+eakec5Im2MJANsJp5vfIP?=
 =?us-ascii?Q?rMz6cd23Wnv/l86L2dqcihJwEFJ+UCuSYB0uM7ESbp0ZFYgefGKZUum2g2K5?=
 =?us-ascii?Q?LzUg4xtodzYf3R/1nuRk1fc8WgB2WxeJDPFwD0RSp3hfO0sD4nXch5r4jwex?=
 =?us-ascii?Q?dfXIyBuFApU1//5CEFLlH4ffqrdPEKWknRnjzlWCv6nuAUDZUn+hvCLOfrNA?=
 =?us-ascii?Q?nY+/EwL+VtSp25l8frNd292oSM7TVYSxB9vov9s3QGJhRf4zMc4IvKKIbEzD?=
 =?us-ascii?Q?SNTSTVITXBO1Uq/vIbEerV9RiKVaktE3IlcMBGRpYeA2y4sMfMju547VxBfr?=
 =?us-ascii?Q?t1iGo175q2O2m4j8wKvvOLIIvIjO/UHesyJTUuAICHSMnnZDH2jX0KSclvGO?=
 =?us-ascii?Q?TEXFBffo/dyRfdCJvQmbxyTusV+0g0A52V8POQHHHS0TDGhvhOM1MV1HEpz3?=
 =?us-ascii?Q?CE3DyGNuo0LrQQdpCYGckSMCDM5ylUL6XJVKn5eR9UDotfjqXBwlIbAhi1HG?=
 =?us-ascii?Q?5cb/Nz1bIdcJiRQv7x78PM1I4kFnD8rm14noc8l9MWTHr5c4MZwRkR41xLYk?=
 =?us-ascii?Q?T4UWv5l4tyXqtwSqNSlHjBm9wgnzxzycoShACUdXNfsFR9w0tyXf5JEiVREe?=
 =?us-ascii?Q?lRzDWAaMDu173f6/YRiFXtMFpZjhRT2RPTQ8BeIwL0w6W4WQonFNxxPdbLtO?=
 =?us-ascii?Q?MDApeR2LtqYXiviMBvgz2Os1pqSwLyiSxDRo3uOD8BEapZEAcFQCBN7rE2Kn?=
 =?us-ascii?Q?/NplfoyjutTZy+Eatg7SaeRMR+PGOgOpb0RqKilGKCxzP47yjndflyN4dCNS?=
 =?us-ascii?Q?JbQsE1wbzGJBwfCepYHnCYB9+3OJzkWSgaa2HSiaXPtma5yMn3yc899Wukir?=
 =?us-ascii?Q?xLc7X7viU1JMqv3eE3mcSbzQJp8dPAGETArfMJX4S8lYoWnHMxrG0IkrRih+?=
 =?us-ascii?Q?QLD/jsRZi3fMUyBtHtRee6Ns/GnXHb5V2xq2VfBqvBXq1OFzvMh6XqNWw49R?=
 =?us-ascii?Q?MFSYuofbunkitvsnfKtWrEk8kBOc093viHAC3p1hjoMrqo3NbrK776vxQS8Z?=
 =?us-ascii?Q?feSBvT9HEzH2+Oo5cYkpHcZ3hP5Xm/zNo0DsLaI7aAmJTixyl/1bVyUnPSq/?=
 =?us-ascii?Q?b5DhNPrtcfWHUm33eq8JAo/e3YLbIlt4NBUn6lZis4EPkpvtlGvjCgFSYA6n?=
 =?us-ascii?Q?DlsBkEFt0k1axHuSIrvUzkzUzhC2satKQOhRJIIT0mheXIEMYsevIkb5E+RE?=
 =?us-ascii?Q?D/aXJmN2t70kiKMloeF8BRmERiju+6aRloHM01V7?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97e874b5-8ed2-4ef4-a54c-08dc19387af9
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 21:49:15.4820
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XjJ89Ryj19M8JnyA3/tBfj3l5tpcfNnrL3RmD/uk2dR3H/Sl7+19Ad6OkRUE8PoSSsCNznmN/yQg+dq4rveRqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9553

On Wed, Jan 17, 2024 at 01:26:43PM +0100, Paul Cercueil wrote:
> Add a new 'sg_was_mapped' field to the struct usb_request. This field
> can be used to indicate that the scatterlist associated to the USB
> transfer has already been mapped into the DMA space, and it does not
> have to be done internally.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  drivers/usb/gadget/udc/core.c | 7 ++++++-
>  include/linux/usb/gadget.h    | 2 ++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
> index d59f94464b87..9d4150124fdb 100644
> --- a/drivers/usb/gadget/udc/core.c
> +++ b/drivers/usb/gadget/udc/core.c
> @@ -903,6 +903,11 @@ int usb_gadget_map_request_by_dev(struct device *dev,
>  	if (req->length == 0)
>  		return 0;
>  
> +	if (req->sg_was_mapped) {
> +		req->num_mapped_sgs = req->num_sgs;
> +		return 0;
> +	}
> +
>  	if (req->num_sgs) {
>  		int     mapped;
>  
> @@ -948,7 +953,7 @@ EXPORT_SYMBOL_GPL(usb_gadget_map_request);
>  void usb_gadget_unmap_request_by_dev(struct device *dev,
>  		struct usb_request *req, int is_in)
>  {
> -	if (req->length == 0)
> +	if (req->length == 0 || req->sg_was_mapped)
>  		return;
>  
>  	if (req->num_mapped_sgs) {
> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index a771ccc038ac..c529e4e06997 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -52,6 +52,7 @@ struct usb_ep;
>   * @short_not_ok: When reading data, makes short packets be
>   *     treated as errors (queue stops advancing till cleanup).
>   * @dma_mapped: Indicates if request has been mapped to DMA (internal)
> + * @sg_was_mapped: Set if the scatterlist has been mapped before the request
>   * @complete: Function called when request completes, so this request and
>   *	its buffer may be re-used.  The function will always be called with
>   *	interrupts disabled, and it must not sleep.
> @@ -111,6 +112,7 @@ struct usb_request {
>  	unsigned		zero:1;
>  	unsigned		short_not_ok:1;
>  	unsigned		dma_mapped:1;
> +	unsigned		sg_was_mapped:1;

why not use dma_mapped direclty?

Frank

>  
>  	void			(*complete)(struct usb_ep *ep,
>  					struct usb_request *req);
> -- 
> 2.43.0
>