Received-SPF: pass (google.com: domain of linux-kernel+bounces-31593-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240115144727.499349-1-tmricht@linux.ibm.com>
In-Reply-To: <20240115144727.499349-1-tmricht@linux.ibm.com>
From: Namhyung Kim <namhyung@gmail.com>
Date: Fri, 19 Jan 2024 13:49:44 -0800
Message-ID: <CAM9d7cjCK-p1VL4Evt6ZwpYz_=wTS=8oAOvgSL3ejO9L5m24hQ@mail.gmail.com>
Subject: Re: [PATCH] perf test: Fix test case perf script tests on s390
To: Thomas Richter <tmricht@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, 
	acme@kernel.org, irogers@google.com, acme@redhat.com, svens@linux.ibm.com, 
	gor@linux.ibm.com, sumanthk@linux.ibm.com, hca@linux.ibm.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

On Mon, Jan 15, 2024 at 6:50=E2=80=AFAM Thomas Richter <tmricht@linux.ibm.c=
om> wrote:
>
> In linux next repo, test case 'perf script tests' fails on s390.
> The root case is a command line invocation of perf record with
> call-graph information. On s390 only dwarf formatted call-graphs
> are supported and only on software events.
>
> Change the command line parameters fors s390.
>
> Output before:
>  # perf test 89
>  89: perf script tests              : FAILED!
>  #
>
> Output after:
>  # perf test 89
>  89: perf script tests              : Ok
>  #
>
> Fixes: 0dd5041c9a0e ("perf addr_location: Add init/exit/copy functions")
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> Cc: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/tests/shell/script.sh | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/script.sh b/tools/perf/tests/shell/sc=
ript.sh
> index 5ae7bd0031a8..a6a09ef16e06 100755
> --- a/tools/perf/tests/shell/script.sh
> +++ b/tools/perf/tests/shell/script.sh
> @@ -54,7 +54,14 @@ def sample_table(*args):
>  def call_path_table(*args):
>      print(f'call_path_table({args}')
>  _end_of_file_
> -       perf record -g -o "${perfdatafile}" true
> +       case $(uname -m)
> +       in s390x)
> +               cmd_flags=3D"--call-graph dwarf -e cpu-clock"
> +       ;; *)
> +               cmd_flags=3D"-g"
> +       esac

I think this is unusual.  Maybe something like this?

    case $(uname -m) in
    s390x)
        cmd_flags=3D"...";;
    *)
        cmd_flags=3D"...";;
    esac

Thanks,
Namhyung


> +
> +       perf record $cmd_flags -o "${perfdatafile}" true
>         perf script -i "${perfdatafile}" -s "${db_test}"
>         echo "DB test [Success]"
>  }
> --
> 2.43.0
>
>