Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp1321394rdb; Fri, 19 Jan 2024 15:57:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IFIZnG4t4i7tqm4fW+tAE+YTSNZwMiQlJj0lBtPS2RWsGzDoypa6zYCf54THymcTlevfbhk X-Received: by 2002:a05:6870:b486:b0:210:dc38:d100 with SMTP id y6-20020a056870b48600b00210dc38d100mr573783oap.16.1705708679648; Fri, 19 Jan 2024 15:57:59 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705708679; cv=pass; d=google.com; s=arc-20160816; b=kYU5ObYBBHCgBy91lQ7YJQB69aZXGpvXx0vpkeaokCDfAHH90d47EHb8sX7w+BAZVX 6Ku9Mq1Rxzg0fzEBQXcii2PKJR0OhBCvMx1bk004Owqxb3gRd85lq1WNt5DqN9Yglugt tU7Dr0/Od6P8FuYlDmocZjOB1lcMz/OoIkH8j5wRRkRsNURHBF6K/q8fNl2phrG+rqwn aC2tU0uAKMAvDyRf1IStT0j4dAoopV4In4o4C/R6aH6r3Nk7alyRAg79PBGMtWEs61uI 7ewzMkGJScTSmJFdEG9ESCtOUutOP2lsEYVHxF16wmKW4Olj7eb48KmiElKYzQbCdkeo qA/Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:sender:dkim-signature; bh=GWMdx0fINotNtujTj4fTXjkXpaMQwO69VYzEDHZPfTs=; fh=BCP/I0sYcoR+IyzjY8iv/w6k0pmkPMgslWwWSKZ91B4=; b=JQgOqmkzWJ0e9+hAmTB0r35KMsYUcA+N4DYkpprutCJ0UMU7FDLnuNB3HYLeGtHN5j Ny78qRs4Zw4CHwSbO0LjVTqLBx+2XkgsN5izUUSzFzX4qIYb9k+lfGGrVmt8/+/bLCCa 0RIr42G9bTdCL9rblylCjiahK+I9ZPsjIkSDkGOhpBFwvTmELpb3re2MB1g39je2z7yW hJVCAB/z4/MA0eyTp5F8D92KkyqPh9q8XwkFE/xinJuY9hCI/Xi9BjufqTZ2D/zqA32A Cl6JQ7jdl773Jr5aI6vM7SVCkktG9klpgARngPbo0PqJ94J0rtrF3kdHqmmcbAZ0tYaK UOLA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="h9BT//+n"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-31636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31636-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p15-20020a63c14f000000b005bdbeb537bcsi4053187pgi.37.2024.01.19.15.57.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 15:57:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-31636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="h9BT//+n"; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-31636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31636-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1A67F284862 for ; Fri, 19 Jan 2024 23:57:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9E29F5917C; Fri, 19 Jan 2024 23:57:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h9BT//+n" Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63CD855E63 for ; Fri, 19 Jan 2024 23:57:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705708671; cv=none; b=hlW8l7RQU+Sxf7EbMlQwnmIBXx4C0uW9Gj1gjJttuLLFNs25xx3tAZ01930j0yzRJCkpt4zRGqNtFYZupu5ajE/rphUis5SAsJ6tdrpr5f6J+3R7Xyaax3qZvWhK++FU4eorGGqH7/0edPep0lXzQidR/R1FpyXhSpCuEw+fQ08= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705708671; c=relaxed/simple; bh=d+kyZBnSMGAMeH2tRQB9dVuey0EYIkA2ubcgG5TybpU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gt6DU3ECQ7KIMAIuA2xrs7XlMld83nyZ1E95OmCORuGIUjkKhzvgeyPq/GpBt/pQEVgVPIlgNRJf0OAhbvHqQwqSxdhT3iEsGOXxwcJHUgpnVpdLiIYDj7YhFY8s2ZfXAOEIe4EOPeGv8zD4D420FqEP1H62mV50m9WgJRcZ5pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h9BT//+n; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-28bec6ae0ffso980867a91.3 for ; Fri, 19 Jan 2024 15:57:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705708670; x=1706313470; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=GWMdx0fINotNtujTj4fTXjkXpaMQwO69VYzEDHZPfTs=; b=h9BT//+nRY3u5RGxf5+7/yfuEinS0oy/eFr/znv1xE8PD2vb3IpN1hBYCwve6CZoYD YecHpyPl5kwEuOSBa3X/XZDoG6/taiROIdffub3K1LZTAwPKcp1Sf6zKTVPlqOmaku1z nTNv/xc+RZEP/cFYqcJyZ1tbtSnuOwaeRBXRZvL0ccLLd/+1wtK/3aPLIgUwt2qod92z ymUmmERb6CZwtmpIj4GQgGFKUKw6B+u9fRObhQ1BurRGKzaM7fs6bkl20kTjsTlQ0EIL OMWv+LqybXxI84bs0JPDsr/xic8DOxfGCw22aGNQjKpr1M25BkfXyWCBwYjf6NTmBLu+ TWXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705708670; x=1706313470; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GWMdx0fINotNtujTj4fTXjkXpaMQwO69VYzEDHZPfTs=; b=NY8GwFCcdg557PaSUAQFZjBxkeMwsKtVZegs7oUc8aoTgpkn4a2kg+93U+hag+icEh zaLFFrfV0VX/PVqF9WNrqAsuYoLXF6mj0xfhu9qTExH8R/TRyaCRtQIesiSthaRn1PwO +M0tcv2yoDTgJwyiGg6j9FiOjasftXQVDFQUWE5HLfsKj+sRqQj14P7se+FhTI3imAyb 501CUUq7HH50STKzNlWjr1sNnQoEF1IfhCtinKBxu577VsuU54jOu7CZBACiUWl1/L3m dYvw8xX0hCcmI9XJpzXW9AuO+HvHa9wESIhJJSN4wKGIIjZgC2Da670LYkVmbgStVVmD 9BSA== X-Gm-Message-State: AOJu0YxUbT+9NkUy0XsjWLByv00wCHneR4qv8g41nF0hkPR6tK8Rk/kr TJb+OUSx1NifwYF1w+TmwMz6maCLLS+qiCAvp9V0fcH8Ub7eAxrd X-Received: by 2002:a17:90a:9910:b0:290:2494:3d31 with SMTP id b16-20020a17090a991000b0029024943d31mr495721pjp.23.1705708669570; Fri, 19 Jan 2024 15:57:49 -0800 (PST) Received: from localhost (dhcp-72-235-13-140.hawaiiantel.net. [72.235.13.140]) by smtp.gmail.com with ESMTPSA id dj7-20020a17090ad2c700b0029065f70565sm304672pjb.41.2024.01.19.15.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 15:57:49 -0800 (PST) Sender: Tejun Heo Date: Fri, 19 Jan 2024 13:57:48 -1000 From: Tejun Heo To: Marcelo Tosatti Cc: Frederic Weisbecker , Joe Mario , Juri Lelli , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mark power efficient workqueue as unbounded if nohz_full enabled Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 19, 2024 at 12:54:39PM -0300, Marcelo Tosatti wrote: > > A customer using nohz_full has experienced the following interruption: > > oslat-1004510 [018] timer_cancel: timer=0xffff90a7ca663cf8 > oslat-1004510 [018] timer_expire_entry: timer=0xffff90a7ca663cf8 function=delayed_work_timer_fn now=4709188240 baseclk=4709188240 > oslat-1004510 [018] workqueue_queue_work: work struct=0xffff90a7ca663cd8 function=fb_flashcursor workqueue=events_power_efficient req_cpu=8192 cpu=18 > oslat-1004510 [018] workqueue_activate_work: work struct 0xffff90a7ca663cd8 > oslat-1004510 [018] sched_wakeup: kworker/18:1:326 [120] CPU:018 > oslat-1004510 [018] timer_expire_exit: timer=0xffff90a7ca663cf8 > oslat-1004510 [018] irq_work_entry: vector=246 > oslat-1004510 [018] irq_work_exit: vector=246 > oslat-1004510 [018] tick_stop: success=0 dependency=SCHED > oslat-1004510 [018] hrtimer_start: hrtimer=0xffff90a70009cb00 function=tick_sched_timer/0x0 ... > oslat-1004510 [018] softirq_exit: vec=1 [action=TIMER] > oslat-1004510 [018] softirq_entry: vec=7 [action=SCHED] > oslat-1004510 [018] softirq_exit: vec=7 [action=SCHED] > oslat-1004510 [018] tick_stop: success=0 dependency=SCHED > oslat-1004510 [018] sched_switch: oslat:1004510 [120] R ==> kworker/18:1:326 [120] > kworker/18:1-326 [018] workqueue_execute_start: work struct 0xffff90a7ca663cd8: function fb_flashcursor > kworker/18:1-326 [018] workqueue_queue_work: work struct=0xffff9078f119eed0 function=drm_fb_helper_damage_work workqueue=events req_cpu=8192 cpu=18 > kworker/18:1-326 [018] workqueue_activate_work: work struct 0xffff9078f119eed0 > kworker/18:1-326 [018] timer_start: timer=0xffff90a7ca663cf8 function=delayed_work_timer_fn ... > > Set wq_power_efficient to true, in case nohz_full is enabled. > This makes the power efficient workqueue be unbounded, which allows > workqueue items there to be moved to HK CPUs. > > Signed-off-by: Marcelo Tosatti Applied to wq/for-6.9. A side note: with the recent affinity improvements to unbound workqueues, I wonder whether we'd be able to drop wq_power_efficient and just use system_unbound_wq instead without noticeable perf difference. Thanks. -- tejun