Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp1322164rdb; Fri, 19 Jan 2024 16:00:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGMM6lswcniN1Bdfx1y+P3Yrqt6fa117T+EnAAjcjqre5tp/2ZyeO9ikG1bHpWdUw9cv4R X-Received: by 2002:a17:907:8749:b0:a2f:d4e3:6978 with SMTP id qo9-20020a170907874900b00a2fd4e36978mr13660ejc.118.1705708814511; Fri, 19 Jan 2024 16:00:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705708814; cv=pass; d=google.com; s=arc-20160816; b=YuU9vUkYbE9L6/QnZUaTJ4Ue3WsOnCh7VLgrY/zirvoTgVPGywgvFxKvqfcjIsTBRs GU6qu8jPyB+Ce9ysn2z4s8rFPyQLfWOoQOoIiT9O1w6pFrZ+t7C0VQJoQfMcNOWuBPvJ xcdMfGSq0T83plGijyJMe3+UdCiUE/bY1PPRkU+f6NYK9ckH6BxT7cmNxnN4TY8wrunU Zgp0Xb77ABD7YMn7teg+SobEnyAhJBm3ix3nzq7LerWpndtQaK3pXieG4xNJbAibAVgX 3iZGHOqT3CXGuAYugml3GN8D+3JrhGVxPwoWuyP1SSjeFKY44dcECjKZyJ8iKOBATRc6 8TfA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=eOFYb/RTZy8MO7nlFfaeJozsL+6Jsio6dI6byv2M1AM=; fh=J7gOsGDLr3ma3OBd0OBQ5MYv8O44b0tkfe5EekOA2lU=; b=hK8dFzmyYevPk4d48oMeJnQaAIDxFa3fV/HYAmUYklw9+Av7A3LrxEhPu9oeMpcz0z pdZOPEgMJMBruOWlXqko+oNdyWa1zG6tWJKtCa8w3h4H0rWGpsdgl7xXvcvIa2PQXV5y Ui62WexsEqcPhtlx2nKeDuTB6/l3PmJtj+ZtBBN6fqYPNU4rYO9mfWk8mBXlgfZpcl+h 6iqYLnooTkef40dbIUx/LY9R00tFGyMusYmKefO22ww8NmU+YULPzPEEnNLoKWecO8dm TL87iD1aRkgnn6JQ2JbLwBgVXV4k+mZim4ZSRUDk6YnhhglflRpjOIKb94LuY/PN9lqT EybQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=ZlTm3ICR; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-31637-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31637-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a5-20020a1709063e8500b00a2a8b469164si8223941ejj.1034.2024.01.19.16.00.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 16:00:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-31637-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=ZlTm3ICR; arc=pass (i=1 spf=pass spfdomain=linuxfoundation.org dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-31637-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31637-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4740D1F22F83 for ; Sat, 20 Jan 2024 00:00:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 90A7059B69; Sat, 20 Jan 2024 00:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="ZlTm3ICR" Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B050F58AAE for ; Sat, 20 Jan 2024 00:00:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705708804; cv=none; b=iHdnDDEce+Z1P/FwX1yDd9qW5dyQewlR3U37xHuPJL7VM9+4EzvcfF6ZwhX8edtljgDhV1Z3757ix/frnl6Aq1QBBIZzqqaP4r6nQ/+9fZgDFBcdaWOXUEyHmFTMDBuiOJg2z4TEG2GbwY/to6MbO5dkHO+ReOHd+vyQLcgSzR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705708804; c=relaxed/simple; bh=2Q6PXCNZrdoKAZHFLazUfCoSdXno+GFbgX4A6oP8KSg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=aoGUSA5JY8LdLKfyTNDDXgSkdJkpFGYpPhStkxe4G+eSBkYpl+0ZeHlQomG41TRBoWOqYTk9YOB8BsIAZXW6XlBOxjCaC9CojBtXgnKKn+ZM4Vkmja/ChJpzc4653ipTNqaFurLwUEHnJsIetfmalkN9TMU8ErksnowIYg9jnvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=ZlTm3ICR; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a2d04888d3dso143268466b.2 for ; Fri, 19 Jan 2024 16:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1705708801; x=1706313601; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eOFYb/RTZy8MO7nlFfaeJozsL+6Jsio6dI6byv2M1AM=; b=ZlTm3ICR3ZRy0BgfySAy6axvWXSQt5OZO5B9Ol118+A9siYwKnWX9mSZBp0lJQYN1u gdKmE8BpVMknKVWR7HwutEGPUGCvwkrgjdO1g+XtNmV44XC6hsrWavTRRVA+wFhokcbx 80tY0AyvD/6WbcFCLH/LhmUWjvWdo6B1bIpYk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705708801; x=1706313601; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eOFYb/RTZy8MO7nlFfaeJozsL+6Jsio6dI6byv2M1AM=; b=TTsK16mv0XOb9iIvY0L48613EfK70WHrrNhIf1aRrsvfrElnTEM8aQHi0zD5NmuxQz 0b6RydDJCHEHZs7tpMGvbdJ18qz+YhBfLFdZ5zEjf2U8dGThpWFONb/zlB1b5YkTJcB5 EO/ZF2zmITCR/Lp3jSUgkTmpg4Klk4BZh4WWHutar6g/Pu+cAizhxtbR5vIrmN6NgK87 1a0JavbMG28xowUjo71auC+aVC/eopiBlaKOerZ3eHS2sDJcOKXAeQQg06ond8cxdTsg g9j9EGdziaBNXN5uELuKVM76mf9DrzQIEhTwNfRwUx67aSt8t7b1+VYybukhokYtz4ag Qr9A== X-Gm-Message-State: AOJu0Yxiyws1sIhuZjy/Zge+BhRHvk/EiucHzEtDIRduXVMBKfYIzc/z ew0Sz4lzPvlHagmLdqh5xugeMp2E0/2ecEGtxm8MOUYbkvcYSsQD8MNAoGWGWj6e9fqE1GdrT2I I6bnJcg== X-Received: by 2002:a17:906:f8db:b0:a2d:359b:b880 with SMTP id lh27-20020a170906f8db00b00a2d359bb880mr276107ejb.13.1705708800732; Fri, 19 Jan 2024 16:00:00 -0800 (PST) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com. [209.85.208.45]) by smtp.gmail.com with ESMTPSA id ce2-20020a170906b24200b00a26a0145c5esm10793433ejb.116.2024.01.19.15.59.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jan 2024 15:59:59 -0800 (PST) Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-55a44bb66d3so1518167a12.1 for ; Fri, 19 Jan 2024 15:59:59 -0800 (PST) X-Received: by 2002:a05:6402:228a:b0:559:b648:b954 with SMTP id cw10-20020a056402228a00b00559b648b954mr243986edb.47.1705708799556; Fri, 19 Jan 2024 15:59:59 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <202401191311.B6AA79D@keescook> <202401191450.CAF805687A@keescook> In-Reply-To: <202401191450.CAF805687A@keescook> From: Linus Torvalds Date: Fri, 19 Jan 2024 15:59:43 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] strlcpy removal for v6.8-rc1 To: Kees Cook Cc: linux-kernel@vger.kernel.org, Andrew Morton , Andy Shevchenko , Andy Whitcroft , Azeem Shaikh , Brian Foster , Dwaipayan Ray , Joe Perches , Kent Overstreet , linux-bcachefs@vger.kernel.org, linux-hardening@vger.kernel.org, Lukas Bulwahn Content-Type: text/plain; charset="UTF-8" On Fri, 19 Jan 2024 at 14:53, Kees Cook wrote: > > Sorry, I should have called that out in the PR, but the commit itself > had my rationale for intentionally leaving those in: > > Leave mentions in Documentation (about its deprecation), and in > checkpatch.pl (to help migrate host-only tools/ usage). Hmm. Yeah, I guess the host tooling is an issue, although there strlcpy makes a lot more sense since I think it exists in various user space libraries (while strscpy() is kernel-only). > If you feel like that's not right, I can either respin or send a > follow-up patch? Oh, I already took the pull request, I was just reacting to leftovers. This is not a big deal. Linus