Received-SPF: pass (google.com: domain of linux-kernel+bounces-31647-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <8511e5c6-eddb-4deb-932e-125e34cddba6@intel.com>
Date: Fri, 19 Jan 2024 16:35:08 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH bpf 1/3] x86/mm: Move is_vsyscall_vaddr() into
 mm_internal.h
Content-Language: en-US
To: Hou Tao <houtao@huaweicloud.com>, <x86@kernel.org>, <bpf@vger.kernel.org>
CC: Dave Hansen <dave.hansen@linux.intel.com>, Andy Lutomirski
	<luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner
	<tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov
	<bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>,
	<linux-kernel@vger.kernel.org>, xingwei lee <xrivendell7@gmail.com>, "Jann
 Horn" <jannh@google.com>, <houtao1@huawei.com>
References: <20240119073019.1528573-1-houtao@huaweicloud.com>
 <20240119073019.1528573-2-houtao@huaweicloud.com>
From: Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20240119073019.1528573-2-houtao@huaweicloud.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEhiU21QWW10MHViM2Q2cEg3Uzh6d1UxNlBGVEVHdUsyaEdGNWc5Yitoci9U?=
 =?utf-8?B?M1RJSGlIVzNsTTNUQnpTRWJqYTJYMVdoQXZEMGVFMm9tSkE4N2JVcjljQlli?=
 =?utf-8?B?K3VhcVZCaFd2UVcyR0ViY0N6b2NwNGQ5Sm1zVVlybm1FVGxpZVJza2I3RTJp?=
 =?utf-8?B?dXlQM1NhalprMExVQW1pUGFYMmk1V1VuVmFoQzBzVzlTeTR2anFvTEZqZnJX?=
 =?utf-8?B?QzUrSkxONDBqU3NxUnZDb0FHUThNbDEwNHFNalVqTlMxQ0tBa0NxL0xlL0No?=
 =?utf-8?B?d2Z0SjVRalNuRHVpU05seUFNYjhyQ3FZdHBBdzdlUEl4ak92SWN5K1pPaVdD?=
 =?utf-8?B?UFBLZzJab3pPWGdPaHhGZlI5U0pjM01TRHRIcVhpTDBzYUU1RDlrQUJyZjZj?=
 =?utf-8?B?T1pFZ0J3VDlLTERmMVY2bDFvTEJ3K1k4K1JNMG9vMERNc2REZVN0K1hldWxS?=
 =?utf-8?B?R1RqaytwN0RXaVFWOU5yQTNzOFMrMnM0ZnEza3cyMDJ5S1JkREF2My9hZFF4?=
 =?utf-8?B?UDUxdlo1dHdlNWViWGlaK0dWbk5CSnlwZk1OMlhNVklIcHNRUmpNeWx1Y0ZM?=
 =?utf-8?B?d0N0TzhtMXZEbENVblM1MHBRVmIraTh3NW9uSU5wS1QweHozYkdZYktBZ1pD?=
 =?utf-8?B?SGdTTTZqbnNBL0k2dUo1b1BQajlldkw2NE9RaFp5WG5LYTBBWEdFdlplayt5?=
 =?utf-8?B?TllRalRqQTY1dG5vS0VpTVpSRUJJU0xSY2Q0VUJrMnlZN09hZlpHcjFZaTk2?=
 =?utf-8?B?NitzY054bVppRTNaNzJjQkhBL3p5K3BHMWpTaG9jZGV6V1h3d0tXdWtSUUt1?=
 =?utf-8?B?UStBd0xiRDY4aE5iZFpBckgvTTI4RnpMc3Q5U0Eyb1QxaXJRRkhlZFZJRzcw?=
 =?utf-8?B?dVE3WmpaZGlLYlAyMTFmSG5nQng4MlNWOElzY3hldTJ1NHJ1NXhYOWMrNitP?=
 =?utf-8?B?Y0NWVWVFT1VOZ2xzZWROYStpU1ZJTGwzZjZuV2IzVjFCeU9TOEMzN0thUy9l?=
 =?utf-8?B?QkhUREpVNEx1UnpEbzZkeFB1MnlPS1FvMnJFRkFLL1VrV2xZZ2JCU0NFR3Jz?=
 =?utf-8?B?V1R6ZllubmdNdlIvMHYrV2MwVFNKOTdwOFN3MldlRzdrMlZ3R3kwdHMrL3BD?=
 =?utf-8?B?a21CZjBHMTdHc3JEZXFKY0tBYlhpcWNVMHJZdWRUU284NSszWVl2V0c1bUty?=
 =?utf-8?B?c1ZSdUE0RWlscG9nUWdSbmdUQkdYaHZoWHJCV2piNWZ4a1FXdlNXN0xrQ2RR?=
 =?utf-8?B?OFVjSFh5NVI3S1ZZYWRQcVJVWldla0J0VGZPWVRwMURjNDU1YmNKY3hhWTdt?=
 =?utf-8?B?RDNhSXBKaXYwY3AxZVZWQmRxTm80TGIxWXRwbStGUkVpNkdrRjdMcjVTWlZE?=
 =?utf-8?B?TWczUU1zQVl1eXBjYVRLR1hRak1vWnhPVm9NYWt5bHUvL0VPQkJzYmQ2MjZs?=
 =?utf-8?B?RVMzVDlnOTJJb01HZ09kRjFrU2N0aGhUTEFRS0JPUEsyVHNUdnJwOFpnYURq?=
 =?utf-8?B?YjFvZTFpZnNGWE1JU1k5V3dCc0NZRS9hV3dqR25sak16Z2J3Vk9yMkJUMlNV?=
 =?utf-8?B?eWlKMm0xWE54VElLcnpuNDhmMW54RVhnOHFqazVKOCtGK0ZTYVJpVnFKM050?=
 =?utf-8?B?OGQ2c0tWekpkWjMvNnhlZER1dm03RW1kNEVKNHNGbVUwalhDY3FZSFpKLzhp?=
 =?utf-8?B?SmFFMEFHU2owYkZQSHZMTDNmS2NtTWN5bFlhLzFKSzZxOUNudnFIOVdUZ1NK?=
 =?utf-8?B?Tm5sV1g1Y0pEb1NDRzF1KzF1QnlJcTF3Rml3WXBNWDRNVElJdTVoSndXaDFT?=
 =?utf-8?B?d0ZBS1pTMGtMdVorQkZEeGc3QklNVzgvZjl1cWJ3ZGZVU1YvQmJNdnJOVWNF?=
 =?utf-8?B?WEM3NTVFQWo2T0MvUStqM2h2aEcyRFZaNTlLN1dXaUJMMFp5Ni9hWTFyMGZQ?=
 =?utf-8?B?emtRL2VyZjYzWHJHZVBOWmZhODlEYWM0VFpiNVBJL1pTRzhhVFQwZ3dlNFdC?=
 =?utf-8?B?WjRtMEgvSG93aTlRUE5HT1NDSHpjTmdySWIyVnFDeGxQYlhHcXZ5VWovbEVw?=
 =?utf-8?B?M1l4Y0doNzdYZS9oSkJvQk1aQnJESlhDYkpLSFNGR1B3enFSQVVsVkR0UlFt?=
 =?utf-8?Q?n7+EXDIoVIa6Qvyynx8/kCSTA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dd6df397-93e4-4747-8d78-08dc194fa8a9
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2024 00:35:10.6702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PTNwUhEEg4bAtS9h7gaEyUWVwG6UMS6UFBUmpJFjZH4iAdUC9ZMvvltkDMEBCsj5S4wTNWnzc3JOYTTUjtoL7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7764
X-OriginatorOrg: intel.com

On 1/18/2024 11:30 PM, Hou Tao wrote:
> From: Hou Tao <houtao1@huawei.com>
> 
> Moving is_vsyscall_vaddr() into mm_internal.h to make it available for
> copy_from_kernel_nofault_allowed() in arch/x86/mm/maccess.c.
> 

Instead of mm_internal.h would a better place for is_vsyscall_vaddr() be
arch/x86/include/asm/vsyscall.h?

Sohil