Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp1350563rdb; Fri, 19 Jan 2024 17:09:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IGV/9PmqGdLbV3xq+gv1a6kgpDPw5YypCZZ/vpYU+ZbU3ioVtCfjGg9TCJ7MjGOUlLx0GHu X-Received: by 2002:a17:906:da03:b0:a28:fdc2:7f11 with SMTP id fi3-20020a170906da0300b00a28fdc27f11mr343764ejb.83.1705712944860; Fri, 19 Jan 2024 17:09:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705712944; cv=pass; d=google.com; s=arc-20160816; b=KK0c6RWw5y947UnZUx2OM2IuxUC1IKs+pmGRghMFFvzsRle1tgLjpjoN/TPRoRj+vq wy7VgBOaT9gqBC5Iw4EZsV0XNFEz8ygSsdVrfengLHgoeFFLuKJc1Hc7EBTpQ7gD7DmG zA0zk/pZ+mBbmUoCYeUcgRcT1VJvFgoMaNKSiKDLcrpVYGNeLiLQYeypy/KNFy2s9QwR fCL8WBtnaDmXV0368KeV0FJLPMOyOM+ramxy18dd1pIH3CFOs8OKoWoyWrTIAfkpeVuf 7dT0Bx6I8jP6WI6i1p37hCHbxrnPTQpRsKyf0zBpS2JREP7uF4k+fXU3hRs9jnhpTN7l 39HQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=hQpMBDa/SGuSKIQdLMIHYKIk+tXCd6t4BBAUn2QqMSU=; fh=wnRf64xgstFPB6OWrEB7YlD6Gsq6o8VOvzNFrsoAGDs=; b=SPtu1S6zr+RxcvoTj1ZwqTEaEzgrwAK/RT0A0WxzIfRcEJIiSNOAbHe3It2Do44KXo MosFUT4gI5GvUGWnd/HZgI1vmhNqXwW8J+wm1EUsyQwuF//SwKgPd74A9zT6Oi2JM6Pu fCzpbIUZ+gNordKXJyJHNG4w2LU+T7475nYmYoH+l6T/MdAicO2vR8VD/WUzDWR+btqa EWLy0AgFz0LM4C1Xkfp2m9p8YRgEv3UvFCrrRGW8Qw+kxS0Q1uksbQgzgT4E3QwTsAhm VyS3e7T58MYsEgOHLXDxOZhOLj2g80UVpxVhQa7nYQGwUE+Rl72rjt+/eSrZDyUov65U Phag== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=Jj8Vv4fv; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-31658-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31658-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id oq10-20020a170906cc8a00b00a2d5d42cb77si3785495ejb.276.2024.01.19.17.09.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 17:09:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-31658-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=Jj8Vv4fv; arc=pass (i=1 spf=pass spfdomain=kernel.dk dkim=pass dkdomain=kernel-dk.20230601.gappssmtp.com); spf=pass (google.com: domain of linux-kernel+bounces-31658-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31658-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5F3DC1F221F5 for ; Sat, 20 Jan 2024 01:09:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4BA681383; Sat, 20 Jan 2024 01:08:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="Jj8Vv4fv" Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A50F10EC for ; Sat, 20 Jan 2024 01:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705712932; cv=none; b=Hr84FfTIE6By8NJ4zgAQ+DfWGI9GO5X/tvkMYgmLTGj6zIs1yZuVExgQcLQHMXuboTghh9kAo4t7uq6cWGhFWQapkLmRiiobS9HTy6r07ZbXaBh88Ta3YUYRm7AO8zhv7gPdKds9rNLK5JeWWObqnvUfmJvoaGpcm+X9HEi4GsI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705712932; c=relaxed/simple; bh=lZQiNZgacSuuVY81zUxInYKxrcCFl6nLvZFElxAfs0c=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=Q+FlqquUd/9hIrJFeImfeK0b0FyevEwOLwF2yHtt5/Y4qwHNX3jw3OXMYXQpWapYCB81crTd5qDWsmsAO84Kv/9yhT3xjbfDR78CNgqJ7p6H37eetUbXyYZ+xw3ua5TpMMIpuIGxFgTh4yd699/+2qAygNRbX11ST4jJkIqOHKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=Jj8Vv4fv; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6d9b760610bso267388b3a.1 for ; Fri, 19 Jan 2024 17:08:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1705712929; x=1706317729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hQpMBDa/SGuSKIQdLMIHYKIk+tXCd6t4BBAUn2QqMSU=; b=Jj8Vv4fvjgzXEl/bjXPvlcWAYOqrbUmo/VdthNNJJqnkrRZxUZwZM6jbZlnFo/raUk P1aOW1+kzAkUcfhYZToX2SIsk8eTJQ7TEQbTZSl4fmfZ/V0yvJUk47g61AZ3ncaE9ZxE L1sVk8nOIPjH6pwxk8ra7GkqP2inopfvZEotbqetDuhRsmuDeZCQ44S7Ybl9xfkJcRyA ynGo0Jl47Y+cIORINgkaq3zewpDXNNQywKrB6zah7mXOPV/HQsRe7qz7D8Gcw2XXpGfi 7L2ysuPAnzVptUSa2yVZY9ejDwFqfEG5s9OpM8jYK0zhIRELr7jmK5kjdPNvkZIYvSOw uOJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705712929; x=1706317729; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hQpMBDa/SGuSKIQdLMIHYKIk+tXCd6t4BBAUn2QqMSU=; b=k/cSW2sJVoJo2r/0T6dMJ+UlBdZQroqUrPkb1QuZhsRJW/1qbtClrD/0bd4I9oPBc+ K0c0d+xu9kfPHzMS0/31RR4xkJxZJOcCvDlsmYkipMFPLkVhGPZpvXvngzcVSFiExQ9o S5uHXXYyW7yzvIWfJgminLiNweZK7cNqSE2PPuxQBXhbVy3r/moHlNVPAZMq2WY10L6q 39ej7TzHFXtfSlImG2rMRasu9lslv9QB97ppYTfWcHn6JW3DUJaYjnPON4nqCN3wiE+F W5Aw4aRYCRpzmC29HC5vNtw5wjqsNUEyQKBPpa5UHTmpJqMx5scop6jqaWg7VUpc79pq qdAg== X-Gm-Message-State: AOJu0YxJYPXjs6sNf1a8N/hL7GpfVfnotEIWg1ZnYK48VShEDBCyzrDT bYaLGZkfWRtViTGciEyZZuyKZh2n5ipbwB14ZCnSirfs6n2U06jqb0NSC3EV0xc= X-Received: by 2002:a05:6a20:43a1:b0:19b:7147:f7df with SMTP id i33-20020a056a2043a100b0019b7147f7dfmr1486502pzl.0.1705712929265; Fri, 19 Jan 2024 17:08:49 -0800 (PST) Received: from [127.0.0.1] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id fn19-20020a056a002fd300b006dbcc97dc7fsm338162pfb.95.2024.01.19.17.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 17:08:48 -0800 (PST) From: Jens Axboe To: allison.karlitskaya@redhat.com, hch@infradead.org, yukuai1@huaweicloud.com, Li Lingfeng Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, houtao1@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com In-Reply-To: <20240118130401.792757-1-lilingfeng@huaweicloud.com> References: <20240118130401.792757-1-lilingfeng@huaweicloud.com> Subject: Re: [PATCH] block: Move checking GENHD_FL_NO_PART to bdev_add_partition() Message-Id: <170571292805.1346839.6434955686837656985.b4-ty@kernel.dk> Date: Fri, 19 Jan 2024 18:08:48 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.5-dev-2aabd On Thu, 18 Jan 2024 21:04:01 +0800, Li Lingfeng wrote: > Commit 1a721de8489f ("block: don't add or resize partition on the disk > with GENHD_FL_NO_PART") prevented all operations about partitions on disks > with GENHD_FL_NO_PART in blkpg_do_ioctl() since they are meaningless. > However, it changed error code in some scenarios. So move checking > GENHD_FL_NO_PART to bdev_add_partition() to eliminate impact. > > > [...] Applied, thanks! [1/1] block: Move checking GENHD_FL_NO_PART to bdev_add_partition() commit: 6a1cf2468a9ba1f56de7478ee6ad0d54e0aa821a Best regards, -- Jens Axboe