Received-SPF: pass (google.com: domain of linux-kernel+bounces-31712-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <ZYbm5L7tw7bdpDpE@kernel.org>
In-Reply-To: <ZYbm5L7tw7bdpDpE@kernel.org>
From: Ian Rogers <irogers@google.com>
Date: Fri, 19 Jan 2024 22:09:10 -0800
Message-ID: <CAP-5=fWVQ-7ijjK3-w1q+k2WYVNHbAcejb-xY0ptbjRw476VKA@mail.gmail.com>
Subject: Re: perf test hybrid failing on 14700K
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Kan Liang <kan.liang@intel.com>, Adrian Hunter <adrian.hunter@intel.com>, 
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, linux-perf-users@vger.kernel.org, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 23, 2023 at 5:55=E2=80=AFAM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Hi Kan,
>
> I noticed the following problem, are you able to reproduce it?
>
> Happy solstice!
>
> - Arnaldo

Hi Arnaldo,

I'm seeing a test failure on Alderlake in perf-tools-next and wondered
if it was on your radar:
```
 32: Session topology                                                :
--- start ---
test child forked, pid 539222
templ file: /tmp/perf-test-HMet21
Using CPUID GenuineIntel-6-97-2
------------------------------------------------------------
perf_event_attr:
 type                             0 (PERF_TYPE_HARDWARE)
 config                           0x800000000
 disabled                         1
------------------------------------------------------------
sys_perf_event_open: pid 0  cpu -1  group_fd -1  flags 0x8 =3D 4
------------------------------------------------------------
perf_event_attr:
 type                             0 (PERF_TYPE_HARDWARE)
 config                           0x400000000
 disabled                         1
------------------------------------------------------------
sys_perf_event_open: pid 0  cpu -1  group_fd -1  flags 0x8 =3D 5
non matching sample_type
FAILED tests/topology.c:73 can't get session
test child finished with -1
---- end ----
Session topology: FAILED!
```

The code is hitting this line in evlist__valid_sample_type as
core.nr_entries is 2 on hybrid not 1:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tr=
ee/tools/perf/util/evlist.c?h=3Dperf-tools-next#n1215
this causes perf_session__open to fail:
https://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/tr=
ee/tools/perf/util/session.c?h=3Dperf-tools-next#n129

Thanks,
Ian