Received-SPF: pass (google.com: domain of linux-kernel+bounces-31813-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <df87e88a-adf6-4ba1-ba80-baccde2ecc28@gmail.com>
Date: Sat, 20 Jan 2024 19:39:40 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] iouring:added boundary value check for io_uring_group
 systl
Content-Language: en-US
To: Jens Axboe <axboe@kernel.dk>, corbet@lwn.net, asml.silence@gmail.com,
 ribalda@chromium.org, rostedt@goodmis.org, bhe@redhat.com,
 akpm@linux-foundation.org, matteorizzo@google.com, ardb@kernel.org,
 alexghiti@rivosinc.com, linux-doc@vger.kernel.org,
 linux-kernel@vger.kernel.org, io-uring@vger.kernel.org
References: <20240115124925.1735-1-subramanya.swamy.linux@gmail.com>
 <71ba9456-45a7-4042-8716-ccd68cc7329f@kernel.dk>
From: Subramanya Swamy <subramanya.swamy.linux@gmail.com>
In-Reply-To: <71ba9456-45a7-4042-8716-ccd68cc7329f@kernel.dk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Jens,

            Thank you for reviewing the patch.

On 17/01/24 03:02, Jens Axboe wrote:
> On 1/15/24 5:49 AM, Subramanya Swamy wrote:
>> diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c
>> index 09b6d860deba..0ed91b69643d 100644
>> --- a/io_uring/io_uring.c
>> +++ b/io_uring/io_uring.c
>> @@ -146,7 +146,9 @@ static void io_queue_sqe(struct io_kiocb *req);
>>   struct kmem_cache *req_cachep;
>>   
>>   static int __read_mostly sysctl_io_uring_disabled;
>> -static int __read_mostly sysctl_io_uring_group = -1;
>> +static unsigned int __read_mostly sysctl_io_uring_group;
>> +static unsigned int min_gid;
>> +static unsigned int max_gid  = 4294967294;  /*4294967294 is the max guid*/
> As per the compile bot, these need to be under CONFIG_SYSCTL. I'd
> recommend just moving them a few lines further down to do that.
>
> I think this would be cleaner:
>
> static unsigned int max_gid = ((gid_t) ~0U) - 1;
>
> however, as it explains why the value is what it is rather than being
> some magic constant.
Will add these changes in v2

-- 
Best Regards
Subramanya