Received-SPF: pass (google.com: domain of linux-kernel+bounces-31819-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <26ef811d-214c-4ce4-a9f8-4fa4cfdefe29@web.de>
Date: Sat, 20 Jan 2024 15:45:11 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] x86/xen: Add some null pointer checking to smp.c
To: Kunwu Chan <chentao@kylinos.cn>, xen-devel@lists.xenproject.org,
 kernel-janitors@vger.kernel.org, Boris Ostrovsky
 <boris.ostrovsky@oracle.com>, Borislav Petkov <bp@alien8.de>,
 Dave Hansen <dave.hansen@linux.intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
 Ingo Molnar <mingo@redhat.com>, =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?=
 <jgross@suse.com>, Thomas Gleixner <tglx@linutronix.de>, x86@kernel.org
Cc: kernel test robot <lkp@intel.com>, LKML <linux-kernel@vger.kernel.org>,
 Ilya Dryomov <idryomov@gmail.com>, Jean Delvare <jdelvare@suse.de>,
 Jonathan Corbet <corbet@lwn.net>
References: <20240119094948.275390-1-chentao@kylinos.cn>
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240119094948.275390-1-chentao@kylinos.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:kvTIFKx34dg=;JrM0jCAeZHWaii5y7r7dOydzsH/
 uXaPcxEWXRFr2x7CuC9tO4Fowq8H82DgAA9WsJE7G3dF/pGzBlBdX7yg/h3FW1dvxZ7L9Bwq9
 YZqtkhcz7oiOllmFXulWXXT8TUiwbuWCOGHS9iggwoMw/g+2VnSJGIUJmgTWjS4UzANjh/x8r
 eV+3HlqoINvOWjVtUuOHipjU4GMkO2781Z9VPLzD7KVuAjRjG1GbHXRkM/V6T+ySE6IBfW4z9
 yJBjfaG/o+nVaI4+cXQp4LaSAmTJL/mcxR8a1oLSaX/20AYUZtOAFtdXkrbH/zozqQPMVgBO0
 338sa0VkYV/U5B7/pshxyVNRbkPcVp1uLHN5CpFbRuo1VPKellG0ELlimWWqkEKK+raOwkm77
 65R5IG0fcJI7961Jef2v0osiTeQRTAr1bjx4sOTPNRKUzpn0NC1DNTjT9kgMtaIFA5l/AwkoV
 29NZ6m17PJdstEsfstnlaLUFQ+fWKSfE0e6No3OmLgbKXK0LKAauriHYkvhk3ewJ203myG2IU
 YJwi0gk9FezgwmACzyQT4pSCrgHf4impbKFaitG16dTeUqtdaTI8h6hEg9OkwoMivrwg+8bem
 6+xvc0SZnrruIWxGGmMczQKyCn5YwG432j8o8B6bIlMujwOgJJIb7JpRmCDwmhIRWF0qkEgU1
 JJ17vy64v+HUOs8t7BQFXbIGnlVXzzpLzhhUptkCMiM0HxkAFCTUf2nXlxRhGnOM91PfKNaQ+
 usRxHngFEVveI06mhCDkJaYP81rbsGAuYhsNKTGOYB2nRbgfO84AC+0J3ghEHIAY+qF8iYBF8
 nX4ixznIdAaK46dT0S7yj+0kPZyD0h4nXAp+qIF7aTGuuIH7FtFCxT8mO7hK6Qbs6uBydatL8
 H6fRRzibSyunhrkNZztI73denc0+gR0SCUWmQrnIQtgMFAqoZj5rayKloIyeG+f5/XW9QgxOf
 ra398Q==

> kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure. Ensure the allocation was successful
> by checking the pointer validity.

How do you think about to refer to the function name
instead of the file name in the patch subject?


=E2=80=A6
> +++ b/arch/x86/xen/smp.c
=E2=80=A6
> @@ -114,6 +124,8 @@ int xen_smp_intr_init(unsigned int cpu)
>
>  	return 0;
>
> + fail_mem:
> +	rc =3D -ENOMEM;
>   fail:
>  	xen_smp_intr_free(cpu);
>  	return rc;

Is it currently preferred to start labels in the first text column?

Regards,
Markus