Received-SPF: pass (google.com: domain of linux-kernel+bounces-31824-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 20 Jan 2024 20:46:48 +0530
From: Manivannan Sadhasivam <mani@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-arm-msm@vger.kernel.org,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] dt-bindings: PCI: qcom: move to dedicated schema
 (part one)
Message-ID: <20240120151648.GB6371@thinkpad>
References: <20240108-dt-bindings-pci-qcom-split-v1-0-d541f05f4de0@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240108-dt-bindings-pci-qcom-split-v1-0-d541f05f4de0@linaro.org>

On Mon, Jan 08, 2024 at 03:19:13PM +0100, Krzysztof Kozlowski wrote:
> Hi,
> 
> The qcom,pcie.yaml containing all devices results in huge allOf: section
> with a lot of if:then: clauses making review and changes quite
> difficult.
> 
> Split common parts into common schema and then move few devices to
> dedicated files, so that each file will be easier to review.
> 
> I did not split/move all devices yet, so if this gets accepted I plan to
> send more patches.
> 

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> Best regards,
> Krzysztof
> 
> ---
> Krzysztof Kozlowski (6):
>       dt-bindings: PCI: qcom,pcie-sm8550: move SM8550 to dedicated schema
>       dt-bindings: PCI: qcom,pcie-sm8450: move SM8450 to dedicated schema
>       dt-bindings: PCI: qcom,pcie-sm8250: move SM8250 to dedicated schema
>       dt-bindings: PCI: qcom,pcie-sm8150: move SM8150 to dedicated schema
>       dt-bindings: PCI: qcom,pcie-sm8350: move SM8350 to dedicated schema
>       dt-bindings: PCI: qcom,pcie-sc8280xp: move SC8280XP to dedicated schema
> 
>  .../devicetree/bindings/pci/qcom,pcie-common.yaml  |  98 ++++++++
>  .../bindings/pci/qcom,pcie-sc8280xp.yaml           | 180 ++++++++++++++
>  .../devicetree/bindings/pci/qcom,pcie-sm8150.yaml  | 157 ++++++++++++
>  .../devicetree/bindings/pci/qcom,pcie-sm8250.yaml  | 180 ++++++++++++++
>  .../devicetree/bindings/pci/qcom,pcie-sm8350.yaml  | 169 +++++++++++++
>  .../devicetree/bindings/pci/qcom,pcie-sm8450.yaml  | 215 +++++++++++++++++
>  .../devicetree/bindings/pci/qcom,pcie-sm8550.yaml  | 171 +++++++++++++
>  .../devicetree/bindings/pci/qcom,pcie.yaml         | 268 ---------------------
>  8 files changed, 1170 insertions(+), 268 deletions(-)
> ---
> base-commit: a0bf076e449e022944b440174491f5c583753d84
> change-id: 20240108-dt-bindings-pci-qcom-split-624737f7ba67
> 
> Best regards,
> -- 
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

-- 
மணிவண்ணன் சதாசிவம்