Received-SPF: pass (google.com: domain of linux-kernel+bounces-31821-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Erick Archer <erick.archer@gmx.com>
To: Oded Gabbay <ogabbay@kernel.org>,
	Marco Pagani <marpagan@redhat.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Erick Archer <erick.archer@gmx.com>,
	dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: [PATCH] accel/habanalabs: use kcalloc() instead of kzalloc()
Date: Sat, 20 Jan 2024 16:10:28 +0100
Message-Id: <20240120151028.11092-1-erick.archer@gmx.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:5162j+Gh7BE=;7MwV3GYQV4AF6w3g4fXl1qNIOgg
 klgJqKVusUiEanMLlbfQQShbn+gCqtIMdoGadz9LUHz//eQ01P4ou0oyfmWm2RIZx9xo+qdf6
 iFk/BhVZeQT9zKKd8ZAZT3KGWMfzjKILLLHKgdkzAQ8oPBiyrcJDTDpsnDB1NUkdbdSYRdX9S
 3q/8h1bjjXJAV4lql9Jl6Jk1zN93f3htBaRN6g4c5oe+7yJItNwvBVH9esgsjBA0xiYRfJWm+
 Okpb7vOSMl45/y+aMUc2kwr4S6dzX/a9H32AOU9oCnTtQI7WGHD6Av5wblmbF2VbxP4oRp/S8
 ZBS4T+zjks4InudF+AYjNE9Wt9O/Clxx4Hrd8cRLD+kQUCFq9w/pdI96RXRXZQByXliTNMs3I
 F2W4S8U2XDHn1od38zaVukTNjQ6G4QCgblXwi8P3311yK2YpYGXSRmF9TLz9bZDJ8hA92g/ZP
 RNNqDrTUUskXd9BE7m2Hx30l5ums7U4KjdEdx/VRnOQIHbQQFwYOC38qkZDAf/r7KE6QnfTJu
 jjTu0McZpz/za1RZdft/RamG7bU19QbEPIrJ1G4dMTxKyKf99UkpTF/THgv3gEtAv4H9O7snD
 SMiWLFik9l+ZLKDaWX0+eETjdtQvw7ILPcdk2pX9tjSYjPNBkj1KA3a/lN6nZmv+ctYSs8twR
 Fcl81hnurU4HFXsn/XWOve8qDyP2EvKmPBtzc6q/U/Q0XVg2xTHcYOe+3QQIXlyI3JTQ9xNUd
 n8NXfk7PiDP/GD82ZRhKwbgNdMOS6c5iQxYRWG+gMMBgEfQ41MId8RSnuE/6CxknDie41iRFj
 /WAPhit2ZwOLneFP1+nQOsKY/WbgYIsza1pAshlDCSlqvZ2GDDO7o7CQhT75dmd+k1mNm0FY2
 eaPTOaRN9VMJgUey/xfRaG7YvWYCsXDBA9UKgaQWy3AqHSk2Z9S2Yet4D4ZeKk0mvbytJnXNj
 GE/K9IaYaFIXj1mhDc+GCMeLzHE=

As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
size * count in the kzalloc() function.

Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-co=
ded-arithmetic-in-allocator-arguments [1]
Link: https://github.com/KSPP/linux/issues/162

Signed-off-by: Erick Archer <erick.archer@gmx.com>
=2D--
 drivers/accel/habanalabs/common/mmu/mmu_v1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/accel/habanalabs/common/mmu/mmu_v1.c b/drivers/accel/=
habanalabs/common/mmu/mmu_v1.c
index d925dc4dd097..e3d42cfead27 100644
=2D-- a/drivers/accel/habanalabs/common/mmu/mmu_v1.c
+++ b/drivers/accel/habanalabs/common/mmu/mmu_v1.c
@@ -232,7 +232,7 @@ static int dram_default_mapping_init(struct hl_ctx *ct=
x)
 	/* add hop1 and hop2 */
 	total_hops =3D num_of_hop3 + 2;

-	ctx->dram_default_hops =3D kzalloc(HL_PTE_SIZE * total_hops,  GFP_KERNEL=
);
+	ctx->dram_default_hops =3D kcalloc(total_hops, HL_PTE_SIZE,  GFP_KERNEL)=
;
 	if (!ctx->dram_default_hops)
 		return -ENOMEM;

=2D-
2.25.1