Received: by 2002:a05:7412:ba23:b0:fa:4c10:6cad with SMTP id jp35csp1646347rdb; Sat, 20 Jan 2024 07:25:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IG9O4K/N1kakCXMyMAOiSE6K5dp2ciYyMpJOh0Vhenj90GiOaWQUtoJP0AmIWDBgY+vxzg4 X-Received: by 2002:a05:6a20:9388:b0:19a:3cbb:8649 with SMTP id x8-20020a056a20938800b0019a3cbb8649mr2152476pzh.78.1705764310386; Sat, 20 Jan 2024 07:25:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705764310; cv=pass; d=google.com; s=arc-20160816; b=px9xG7iZ4Wgmb1Ks1Wc9BUyxVIUyiDSV1UG1Xq+txI6B8e3WvEJF0yCecmZpwKgoxN aNApTCocFpMhbhYN0RBfWkf6qsmB0jn3eD5qby42Q3Gf2bERPEtt4VHHVi+B137RKCs7 h/MZ2IugOXlFF1rNz6qybSRzyuQYLy22Fv0sXb66occVkJxfaqRFvE62ayx6wLvO4cWF 3k048V+mFr8P4TV3dLZczNv9nQ/6eIN/HxvugzkM4VqF4OKJzFUCzCMr6Q89XnXHKe5B WNYOdIgioJ4wPaPLjq8lXujdYE3g95VyC2bsu5fbuJYRFgLebPK1fPUrMrY6+nw/lvmg a3kQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bHHQkThnfJ5cmcN6+69YdOMe9BS75ktorkjHnggZnww=; fh=VpBWx3aAoqFhsjGoHX3K/ycPJA7wBkuCBGlpzvEYdaY=; b=uTcTgLy/KBbx/WGl1PAMYUCveYT2ntIVmIh2eJ2tsewVkSX+y7Jp+3KIaYvA5JKmGS eTU6nHEhkzOy0ZLwtSyo9IjUrmC7o20tEo5g8UXen+ev2b5BU7vNA6/9ZVku1ap8boLs 77ANs0/dl8lM/kFvLqoCRRGcrpUjxYVeq8fJxEyVlbDDxQ5+ql+Q/Zj8s8OMkE1QefR/ HAh9dYc7D/74z4JBJxsYvCmHq3cUxPNjIDxTIxrjGmRN/1Qe7fvVbuNAwhm+Zc2tvd0X bGAhdKr19AI8rYniUtbSSAPFWaVTb9JRrpaTbAWDBf80L1NC2RYY6HmC6y/7cyVXeFGE bYYw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S8vAovvF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-31829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ld20-20020a056a004f9400b006db752cf3c0si7721950pfb.257.2024.01.20.07.25.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Jan 2024 07:25:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-31829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=S8vAovvF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-31829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-31829-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 08E0B283D4C for ; Sat, 20 Jan 2024 15:25:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 668E4125C7; Sat, 20 Jan 2024 15:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S8vAovvF" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F7E111718; Sat, 20 Jan 2024 15:25:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705764300; cv=none; b=UQFMbaAw54WcfN5OI2VJf8YnLjWQeZcsGUMqsYLho6TfWR4Q0oAbiz4obQZlXYcE8fb/hppKdDXuqeq8msLCoiMgU16CijUMbDJ3lEp12hfgy5S2hQCyP3+qbO/97PNtLeFHkk/U2LFNnsYoPaxvVF1iFCHJbje3gVIwrGSB6YY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705764300; c=relaxed/simple; bh=pCRTUE89WbCCD8xmHX5KJpuh7NCmdjg63VnRI9107FQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eVkZh7/VIexs8sNavbviYXBM/gu5a0PM2SiVg3sxcALyr8qB/oDeVTs3H0y8el+CtzVi92zawZ8RWFRt6si+OBRhgFDgpJohptqnC2MIpcmW5dKZmEnn1+UH8sbOMo4m1bieVx/GqmJ1E2B0AGkD4ATzSOvBvsRUt8whLjER8R4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S8vAovvF; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9974C433C7; Sat, 20 Jan 2024 15:24:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705764300; bh=pCRTUE89WbCCD8xmHX5KJpuh7NCmdjg63VnRI9107FQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S8vAovvFDeNN/MP7eTI6VSNy9LiWfk8ZbgU6pAJhhVf+w1ITNlN+Ij9GF4IlwvwnN lslSdxTjpv8Djs59EUiEPxyo53WTOO9Od9DUpX02UJbPGiu+tbowG2hhvQSUVSk4IJ fpEOgx5hnKPKpus8MlHoIJ0ATAhBQvP44QVznFapKvi4ugRWaqmhPbyUPBiwpmhlek tPlFpWLsKImQ9tpRoAi+OWACE3IusA/H26YHQb6hCEj3xoTnUWN7UrP2afW9AA3+vE +4PKP4MDr94yQbcODV85VXNHgwtc3XLq7zO1MOwzwOpUfckPxCWNatCAHn8p7DWhlg Y+oisUAICe3pw== Date: Sat, 20 Jan 2024 16:24:55 +0100 From: Christian Brauner To: Alexander Mikhalitsyn Cc: mszeredi@redhat.com, stgraber@stgraber.org, linux-fsdevel@vger.kernel.org, Seth Forshee , Miklos Szeredi , Amir Goldstein , Bernd Schubert , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 7/9] fs/fuse: drop idmap argument from __fuse_get_acl Message-ID: <20240120-bersten-anarchie-3b0f4dc63b26@brauner> References: <20240108120824.122178-1-aleksandr.mikhalitsyn@canonical.com> <20240108120824.122178-8-aleksandr.mikhalitsyn@canonical.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240108120824.122178-8-aleksandr.mikhalitsyn@canonical.com> On Mon, Jan 08, 2024 at 01:08:22PM +0100, Alexander Mikhalitsyn wrote: > We don't need to have idmap in the __fuse_get_acl as we don't > have any use for it. > > In the current POSIX ACL implementation, idmapped mounts are > taken into account on the userspace/kernel border > (see vfs_set_acl_idmapped_mnt() and vfs_posix_acl_to_xattr()). > > Cc: Christian Brauner > Cc: Seth Forshee > Cc: Miklos Szeredi > Cc: Amir Goldstein > Cc: Bernd Schubert > Cc: > Signed-off-by: Alexander Mikhalitsyn > --- Ah, that probably became obsolete when I did the VFS POSIX ACL api. Thanks, Reviewed-by: Christian Brauner